Merged
Conversation
* docs(User): Mark name in UserUpdate as optional
Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
I needed to make these changes for a hackage release, and the seem generally beneficial to me.
This is a rather small change not deserving a change log.
This PR completely removes `UVerb` from the codebase, as well as the `EmptyResult` kludge that we needed to generate empty responses. Both are now replaced by `MultiVerb`. It also adds a mechanism for deriving `AsUnion` instances, as well as convenience functions `eitherToUnion` and `eitherFromUnion` that can be used to define an instance of `AsUnion` for a type of the form `Either a b`.
Also: * Mark old API to list unqualified conversation IDs as deprecated. * Introduce a new way of doing pagination using PagingState returned by Cassandra. Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com> Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
* bump hscim package version. * Fix flaky unit test. * Fix typo.
* Also remove obsolete part of login failure test. (This was testing that a user with only phone number and email, but without password, cannot login. However, we can't change the email any more now without logging in, and we test that elsewhere.)
Minor typo fix, on word "Successfully"
julialongtin
approved these changes
Aug 13, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2021-08-16]
Release Notes
This is a routine release requiring only the routine upgrade steps.
API Changes
POST /conversations/list-ids(Add new API to list paginated qualified conv ids #1686)GET /converstations/ids(Add new API to list paginated qualified conv ids #1686)Features
Bug fixes and other updates
missing-legalhold-consent. (Change http response code formissing-legalhold-consent. #1688)Federation changes (alpha feature, do not use yet)
Documentation
Internal changes
UVerbandEmptyResultwithMultiVerb(Finish integratingMultiVerb#1693)AsUnioninstances automatically (Finish integratingMultiVerb#1693)