Skip to content

Integration test coverage.#1704

Merged
fisx merged 2 commits intodevelopfrom
integration=test-coverage
Aug 13, 2021
Merged

Integration test coverage.#1704
fisx merged 2 commits intodevelopfrom
integration=test-coverage

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Aug 12, 2021 •
edited
Loading

Motivated by https://wearezeta.atlassian.net/browse/SQSERVICES-712

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx marked this pull request as ready for review August 12, 2021 18:26
@fisx fisx requested a review from mdimjasevic August 12, 2021 18:27
mdimjasevic
mdimjasevic approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@fisx fisx merged commit 6d626d0 into develop Aug 13, 2021
@fisx fisx deleted the integration=test-coverage branch August 13, 2021 05:49
@fisx fisx mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisx @mdimjasevic