Skip to content

hscim client#1699

Merged
fisx merged 9 commits intodevelopfrom
hscim-client
Aug 10, 2021
Merged

hscim client#1699
fisx merged 9 commits intodevelopfrom
hscim-client

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Aug 9, 2021

I need client functions for https://github.com/wireapp/ldap-scim-bridge. This PR introduces them to the hscim library.

Please read commit-by-commit.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

fisx added 5 commits August 9, 2021 11:29
(there was no reason to keep those things local, but we're going to
need them in a moment.)
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inlined.

@fisx
Copy link
Contributor Author

fisx commented Aug 10, 2021

Thanks, good feedback! I think I resolved everything, please unresolve the comments where you disagree.

@fisx fisx requested a review from mdimjasevic August 10, 2021 09:43
@fisx
Copy link
Contributor Author

fisx commented Aug 10, 2021

(should the process be that the reviewer resolves the comments, after the PR author has answered them? no strong opinion.)

@fisx fisx merged commit 4abfabb into develop Aug 10, 2021
@fisx fisx deleted the hscim-client branch August 10, 2021 11:43
@fisx fisx mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants