Skip to content

fix swagger: mark name in UserUpdate as optional#1691

Merged
fisx merged 3 commits intowireapp:developfrom
ffflorian:patch-1
Aug 3, 2021
Merged

fix swagger: mark name in UserUpdate as optional#1691
fisx merged 3 commits intowireapp:developfrom
ffflorian:patch-1

Conversation

@ffflorian
Copy link
Contributor

@ffflorian ffflorian commented Aug 2, 2021

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx changed the title docs(User): Mark name in UserUpdate as optional fix swagger: mark name in UserUpdate as optional Aug 2, 2021
@fisx
Copy link
Contributor

fisx commented Aug 2, 2021

Thanks for doing our job! :) I'll update the CHANGELOG separately. Can you try to push an empty commit though (--allow-empty), and see if the CI is picking it up?

@fisx
Copy link
Contributor

fisx commented Aug 3, 2021

I think the CI only picks up PRs living in wireapp/wire-server. I'll just risk it and mege... :)

thanks again!

@fisx fisx merged commit f31f79c into wireapp:develop Aug 3, 2021
@ffflorian ffflorian deleted the patch-1 branch August 3, 2021 11:01
@pcapriotti pcapriotti mentioned this pull request Aug 3, 2021
2 tasks
@fisx fisx mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants