Fix the Order of Arguments to a Test Assertion#1696
Merged
mdimjasevic merged 1 commit intodevelopfrom Aug 6, 2021
Merged
Conversation
fisx
approved these changes
Aug 6, 2021
Contributor
Contributor
Author
And their arguments are swapped! Because of this, I always end up having to look up the documentation to see which argument is which. I spotted this error only because I was copy-pasting the affected test, had an unfinished implementation, and noticed my test failing, but with an unexpected expected value. |
pcapriotti
approved these changes
Aug 6, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rather small and insignificant change, hence I haven't added a change log.
The one-line change just puts the expected and actual value arguments to
(@?=)in the correct order in a federation test.Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.