Skip to content

Fix the Order of Arguments to a Test Assertion#1696

Merged
mdimjasevic merged 1 commit intodevelopfrom
mdimjasevic/fed-fix-test-assertion
Aug 6, 2021
Merged

Fix the Order of Arguments to a Test Assertion#1696
mdimjasevic merged 1 commit intodevelopfrom
mdimjasevic/fed-fix-test-assertion

Conversation

@mdimjasevic
Copy link
Contributor

This is a rather small and insignificant change, hence I haven't added a change log.

The one-line change just puts the expected and actual value arguments to (@?=) in the correct order in a federation test.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.

@mdimjasevic mdimjasevic requested a review from pcapriotti August 6, 2021 06:14
@mdimjasevic mdimjasevic changed the title Fix the order of Arguments to a Test Assertion Fix the Order of Arguments to a Test Assertion Aug 6, 2021
@fisx
Copy link
Contributor

fisx commented Aug 6, 2021

This is hillarious: HUnit has both @?= and @=?, just in case anybody's not confused enough by the one option. :')

@mdimjasevic
Copy link
Contributor Author

This is hillarious: HUnit has both @?= and @=?, just in case anybody's not confused enough by the one option. :')

And their arguments are swapped!

Because of this, I always end up having to look up the documentation to see which argument is which. I spotted this error only because I was copy-pasting the affected test, had an unfinished implementation, and noticed my test failing, but with an unexpected expected value.

@mdimjasevic mdimjasevic merged commit 01d3b2b into develop Aug 6, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/fed-fix-test-assertion branch August 6, 2021 09:22
@fisx fisx mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants