Add post_itag_gcafs file for the GCAFS model#2929
Conversation
…us a bug fix to the Thompson scheme PR ufs-community#882 (ufs-community#503) * change ccpp-physics branch to feature/p8c_pbl_cp branch * change ccpp/physics in feature/p8c_pbl_cp branch * revised GFS_typedefs.F90 for the paramters in the saSAS scheme * sync upp * Revert "sync upp" This reverts commit 429d0469c92d200fa058aca6c6bd17adac7f9568. * sync upp to 0185bb9 * Merge remote-tracking branch remote/main for ccpp-physics and update .gitmodules
* Reset to zero coupling arrays for accumulated snow, large scale rain, and convective rain at the end of each coupling step if coupling with chemistry model. * Properly set kind type of literal constants defining zero and one. * Initialize to zero canopy resistance output variablein noah/osu land-surface model subdriver. * Re-implement radiation diagnostic output involving spectral band layer cloud optical depths (0.55 and 10 mu channels) to prevent floating invalid errors due to uninitialized optical depth arrays. * Temporarily disable filling export fields during the NUOPC Realize phase since it breaks coupling with aerosol component. * Increase maximum number of input aerosol scavenging factors to accommodate AQM/CMAQ 5.2.1 chemical tracers. * Remove inst_pres_height_surface from chemistryFieldNames as its imported already elsewhere Co-authored-by: Raffaele Montuoro <raffaele.montuoro@noaa.gov>
* Add explict treatment of convective cloud to RRTMGP. * Some cleanup and bug fixes from previous commit. working now with Thompson MP plus radiatively active convective cloud. * Updated physics. New interstitials. * Added explicit MYNN-EDMF cloud coupling to RRTMGP. * Added switches for sgs clouds in GP. * Replaced cld_mynn_ naming convention with cld_pbl_ * Fixed inconsistency between G/GP in Thompson MP. * Some more cleanup of cloud-fraction... * Pulled in Qingfu's changes to ccpp-physics * Synced physics with main * Updated physics. * Revert change from previous commits (sampling of different cloud types). New SDFs for p8c * Changed arguments to implied shape. * Renamed scheme file in SDF. Now common to both RRTMG and RRTMGP SDFs * Syntax error in ccpp-physics * Revert changes to names * Renamed p8_rrtmgp SDFs * Added bounding to temperature at layer-interface used by RRTMGP. * Reorder loop * Combined gp sw and lw aerosol routines. Modest speedup (~4%)
…apabilities (ufs-community#501) * Add the storm-following or specified moving-nesting capability for both the regional and global configuration. * Expand the UFS/HAFS FV3ATM-HYCOM ocean coupling to support the static and moving nesting configuration. * Expand the write grid component to support outputting the moving nest domain properly. * Five HAFS related moving-nesting regression tests are added to test these newly added features. The regional_hafs RT was removed. Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Grant Firl <grantf@ucar.edu> Co-authored-by: Daniel Rosen <daniel.rosen@noaa.gov> Co-authored-by: man.zhang <Man.Zhang@noaa.gov> Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov> Co-authored-by: Ufuk Turuncoglu <ufuk.turuncoglu@noaa.gov> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: A-Kyle <kyle.ahern@noaa.gov> Co-authored-by: Gerhard Theurich <theurich@sourcespring.net> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
…ccpp_types (ufs-community#508) * Split GFS_typedefs.F90: move GFS_interstitial_type to CCPP_typedefs.F90; Rename CCPP_interstitial to GFDL_interstitial; Import ccpp_t from ccpp_types instead of ccpp_api * Add bugfix in ccpp/data/GFS_typedefs.meta: mark input_nml_file as active only if the number of lines in the file is greater than zero
…s-community#516) * Pass SPP namelist entries outside of stochastic physics routines. * Fixes to SPP metadata * Add active attribute to spp_prt_list * Add active metadata flag to spp_stddev_cutoff * Add active metadata flag for spp_var_list
… moisture property calculation (ufs-community#520)
…ional veg (ufs-community#513) Updates to allow land perturbation scheme to be applied for Noah-MP. Main code changes: -added lsm_noahmp model option to lndp_type==2 land perturbation scheme (fv3-atm, stochastic_physics) -updated comments -cleaned up the namelists to make the different options clearer. Removed misleading lndp_each_step variable from gfs_physics_nml, and replaced it with "lndp_model_type" in the nam_sfcperts namelist for the different forecast types (cycling DA, short forecasts, perturbing only initial conditions) (fv3-atm, stochastic_physics, ufs-weather-model) NOTE: see note below, re: specification of smc perturbation for RAP/HRRR/etc (lndp_model_type==2) -revised code in stochastic_physics_wrapper to only allocate arrays that will be used when passed into lndp_apply_perts (fv3-atm) -deleted unused albedo arrays in stochastic_physics_wrapper and lndp_apply_perts (fv3-atm, stochastic_physics) -fixed bug causing precision errors when calculating the soil moisture ice content (often ~0.0; stochastic_physics) -fixed bug in which lndp_apply_perts wasn't called for nscyc = 0. (fv3-atm) -increased max_nvar_lndp at Jeff Ator's request (fv3-atm) -added a new test for the Noah-MP and lndp==2 combination (ufs-weather-model)
…ommunity#524) Combined PROD and REPRO build modes into 'Release' build type. Now only 'Debug' and 'Release' build type are supported. Both build types must produce bit-for-bit reproducible outputs using different number of threads, mpi tasks, different domain decomposition, have reproducible restarts etc.
* Unify global and regional inline posts and add bug fix for dx/dy computation. * Update upp revision to dc8bc68 * Set up different configurations of read max/min 2m T for global and regional FV3.
* Change RRTMGP to RRTMG in suite_FV3_GFS_v17_p8 and suite_FV3_GFS_v17_coupled_p8 * deleted or modified some SDFs related to RRTMGP or Thompson schemes * added a new SDF file for P8 with rrtmgp
Merge in GSL institutional fork
* Changes to ccpp to support 32-bit physics in NRL Neptune model
* update downstream submodules * updating ccpp/physics submodule and coupling fields * update ccpp/physics submodule, restart capability * Update submodules and restart files * updates submodule * addressing some review comments * update submodules fetch upstream * update ccpp/physics submodule * change conditional check to <= for saftey * addressing some review comments * removing wclosureflg * Allow CA to run on non-uniform blocksizes * cleaning and updating submodules * updating submodules * update atmos_cubed_sphere * updating submodule atmos_cubed_sphere * .gitmodules * updating atmos_cubed_sphere * updating submodules * merge with develop * merging with submodules * updating ccpp/framework and upp submodules * address some review comments, bug in active, correct initialization in ccpp/physics * put back some diagnostic fields * merge upstream cppp/physics * resolving some conflicts * remove check to allow CA to be used with non-divisible blocksize * Add active flag for conditional variables in meta data, update ccpp/physics submodule * merge submodule ccpp/physics upstream * merge with ccpp/physics main * revert .gitmodules and add the merged ccpp/physics code
The current logic in CCPP_driver does not allow for buckets to be emptied every time-step. This one-line modification fixes that.
* 20220505 Jesse Meng create branch upp_unify_inline_2d from * 20220610 Jesse Meng update upp url
… temperatures (ufs-community#552) * typo caused potential temperature calculation to use exponentiation instead of multiplication
* ccpp physics: Fix RAP (Grell Freitas) decomp b4b issues; moninshoc.meta missing mfpbl.f dependency * dycore: Fixes failure of decomposition test for regional case with nrows_blend > 0. Also fixes a bug where nrows_blend=1 caused a crash. Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov>
…munity#550) * Add 'time_iso' variable to 6-tile history files * Add '_Encoding' attribute to time_iso Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>
…unity#556) * Update atmos_model and FV3GFS_io read performance when io_layout=1,1 and allow one to override data integrity checks in FMS restart logic Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
ufs-community#525) * Added coupling of GOCART aerosols with radiation related to issue#899 in NCAR/ccpp-physics * Updated ccpp/physics to include Barry Baker's updates for wet deposition in the Thompson scheme * Updated physics/rte-rrtmgp with the latest commit in ccpp/physics * Update ccpp/physics to include the updates of precipitation fluxes outputs in the Thompson microphysics scheme * Updated ccpp/physics for fixing a bug in mp_thompson.F90
…ufs-community#558) * update upp revision to 8767929 * modify dx/dy calculation for RRFS with domain over north pole
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
|
@gspetro-NOAA Thanks very much. Here is what I am doing. I git clone the develop branch of WM, I checkout the latest UPP module to the most recent version under UFSATM, then I added my new file of "post_itag_gcafs" to tests/parm in the WM, and created a new branch as "PR-UPP". Then I tried the RT using the commands that you suggested. Do you remember that I first PR also failed by using the default version in the global workflow with the same updates as I mentioned. Currently, I am trying "nohup ./rt.sh -a naqfc -e &" , looks like it crashed again:/scratch4/BMC/gsd-fv3-dev/lzhang/GCAFS/PR/global-workflow/sorc/ufs_model.fd/tests/log_output rt_utils.sh: ECFLOW tasks completed, cleaning up suite REGRESSION TEST RESULT: FAILURE |
|
Ok, that actually looks like reasonable output to me. If you look at The "UNABLE TO COMPLETE COMPARISON" failures listed suggests that there may be baseline changes in this PR. If that is not what you want/expect, then it's a problem. But if those tests can reasonably be expected to change due to your PR changes, then it is not a problem. We'd just need to relabel the PR as baseline changing. But you need to be sure that those changes are expected. The "UNABLE TO START TEST" changes are normal for a restart test if the control it is based on failed controls (e.g., due to comparison error). And the "TEST TIMED OUT" failures sometimes happen but usually pass when the test is rerun another time or two. So the main question is whether you expect these tests to change results:
If these baseline changes are expected, then you can push the log and test changes file. If they are not expected, then you'll need to check the logs for the individual tests (under |
|
@gspetro-NOAA Thanks very much again for your help. I think because I update the UPP module to the most recent version (I did not make any code change, just update the harsh), suppose that would be some changes in the grib2 data output, will the PR also compare the grib2 output? But i am not sure whether this may impact on the following PR. While the file I added should not impact any of them. I am including UPP code manager @WenMeng-NOAA here, to see if she may know more about it. @gspetro-NOAA Could you please suggest how to move forward for my PR? cpld_control_gefs_intel |
|
Checking the rt_* files, it seems that only the Grb files have changed I suspect this is reasonal given the update in UPP? |
@DeniseWorthen Yes. Because my update in adding the new file will not cause any changes in these RT results. |
|
For the global RTs, it may be easier just to wait until UPP update is merged in #2932 |
|
@NickSzapiro-NOAA @gspetro-NOAA @DeniseWorthen Could you please advise how I should proceed with this PR and RT run? I only need to add one file to the Weather Model, but this change depends on the latest UPP module, since related updates are in UPP. |
|
I think Nick is right. The current PR will update UPP to 4a5d595 it looks like. I assume w/ that update, your PR will no longer change baselines. Is that what you expect? |
|
Correct. I think so.
…On Thu, Oct 23, 2025 at 12:02 PM Denise Worthen ***@***.***> wrote:
*DeniseWorthen* left a comment (ufs-community/ufs-weather-model#2929)
<#2929 (comment)>
I think Nick is right. The current PR will update UPP to 4a5d595 it looks
like. I assume w/ that update, your PR will no longer change baselines. Is
that what you expect?
—
Reply to this email directly, view it on GitHub
<#2929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APJPDRDUTGBQXFQRYZQ5OS33ZEJYBAVCNFSM6AAAAACI3ZWZH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGQYDANBQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
UPP is particular as developments and commits happen outside of ufs-weather-model commit queue. So even if the added file alone would not change results, updating UPP can change answers/variables/... I would wait until after #2932 is merged (today?). Do you need to update UPP past 4a5d595?
|
|
@NickSzapiro-NOAA @gspetro-NOAA @DeniseWorthen @WenMeng-NOAA Thanks for all your helps and suggestion. I will wait for your merge of #2932 to do the RT and submit my PR. |
|
@gspetro-NOAA @NickSzapiro-NOAA @DeniseWorthen I rerun the RT after merging the UPP PR. This is the RT path at URSA: /scratch4/BMC/gsd-fv3-dev/lzhang/GCAFS/PR/global-workflow/sorc/ufs_model.fd/tests, but the RT failed with the following 2 runs. But the new file I added should not impact on these runs, can you help to check what happen? Thanks. |
|
cpld_warmstart_c48_5deg_intel timed out. This happens frequently nowadays and doesn't mean anything is wrong with your PR. Please push the logs/RegressionTests_ursa.log and test_changes.list to your branch. Once they pass, you can append the platform log and empty test_changes.list |
|
@NickSzapiro-NOAA @BrianCurtis-NOAA @jkbk2004 Perhaps we can merge the contents of this one into Dusan's to process tomorrow? This one's high-priority for GFS v17 and non-baseline changing, so it seems like the best way to get it in would be combining with #2941 or #2942. |
|
I think this is for GCAFS (aerosols) not GFS. But please correct me @zhanglikate |
|
@NickSzapiro-NOAA I think you're right, sorry! But it is also labeled high priority. |
Yes. This is GCAFS, not GFS. @gspetro-NOAA @NickSzapiro-NOAA |
|
and agreed @gspetro-NOAA, very good candidate to combine for merge |
|
@gspetro-NOAA @NickSzapiro-NOAA I have push logs/RegressionTests_ursa.log and test_changes.list to my branch. Can I open a new PR now? BTW, I am just submit the retry run (rt_retry.conf). Thanks. |
I tried, it failed again: /scratch4/BMC/gsd-fv3-dev/lzhang/GCAFS/PR/global-workflow/sorc/ufs_model.fd/tests |
|
Tests ran but answers changed (see Is this (https://github.com/zhanglikate/ufs-weather-model/tree/PR-upp) the ufs-weather-model branch you're using? |
Yes. I git clone from the WM develop branch after you merging the UPP PR. |
|
Your PR-upp branch works for me: |
|
May I know which command you are using to submit the PR? I did it on URSA.
Thanks.
Kate
…On Tue, Oct 28, 2025 at 1:50 AM Nicholas Szapiro ***@***.***> wrote:
*NickSzapiro-NOAA* left a comment (ufs-community/ufs-weather-model#2929)
<#2929 (comment)>
Your PR-upp branch works for me:
====START OF URSA REGRESSION TESTING LOG====
UFSWM hash used in testing:
0284e0c
Submodule hashes used in testing:
9265006502a859d2d3f21029fbb86107ba50ce0e AQM (v0.2.0-54-g9265006)
642e81395472d5887b54f601b60ee607ed39bf09 AQM/src/model/CMAQ (CMAQv5.2.1_07Feb2018-6194-g642e81395)
9f53664ef2e607ad25d6b6c939f2eac9ec818ee6 CDEPS-interface/CDEPS (cdeps0.4.17-432-g9f53664)
90ed2522ba8dd04d75237a77aae6b49e7acca523 CICE-interface/CICE (CICE6.0.0-432-g90ed252)
6a5c51e9e6c643da0760a315e452755661d7d745 CICE-interface/CICE/icepack (Icepack1.1.0-220-g6a5c51e)
374373588e22cd86f1b8eb670d489c2967a6b40a CMEPS-interface/CMEPS (cmeps_v0.4.1-2324-g3743735)
9b7652c75b40d9cbb40e52b824f8c0a423922757 CMakeModules (v1.0.0-33-g9b7652c)
9ff3df9545dd582f415f682d3297e8c6c841e5cb GOCART (sdr_v2.1.2.6-291-g9ff3df9)
bcf7777bb037ae2feb2a8a8ac51aacb3511b52d9 HYCOM-interface/HYCOM (2.3.00-122-gbcf7777)
c4d2337d8607ec994b3cd61179eb974e0a237841 LM4-driver (baseline_change_240904-6-gc4d2337)
c03c4f68816030f726785daf0db6150aa1e9cc6f LM4-driver/LM4 (land_lad2_2021.02)
9c8b26c2d870636f359f2ef62ef775639132b3ba MOM6-interface/MOM6 (dev/master/repository_split_2014.10.10-10723-g9c8b26c2d)
65ef5c73bc7f5663d5688f75c3855d431da4baea MOM6-interface/MOM6/pkg/CVMix-src (65ef5c7)
29e64d652786e1d076a05128c920f394202bfe10 MOM6-interface/MOM6/pkg/GSW-Fortran (29e64d6)
a0363fd82ba2c4a44b3e80904f550868b321024c NOAHMP-interface/noahmp (v3.7.1-466-ga0363fd)
062acd6 UFSATM (remotes/origin/production/HREF.v3beta-404-g062acd6)
11359cb04a420fc87e4cf0f035f4d1215ab24488 UFSATM/ccpp/framework (2025-01-06-dev-5-g11359cb)
cf752f71b838f3d78c49c449c60fc928e9c62a0d UFSATM/ccpp/physics (EP4-2008-gcf752f71)
c62efd27caa26f660edf24232f33f154e608b77a UFSATM/ccpp/physics/physics/MP/TEMPO/TEMPO (c62efd2)
41c5fcd950fed09b8afe186dede266824eca7fd3 UFSATM/ccpp/physics/physics/Radiation/RRTMGP/rte-rrtmgp (41c5fcd)
7e24e739182281717607b341a1c2ffdba473616f UFSATM/fv3/atmos_cubed_sphere (201912_public_release-424-g7e24e73)
38d2177aef842a5c6abe26ffe876804b95fd9e0a UFSATM/mpas/MPAS-Model (remotes/origin/develop-226-g38d2177a)
4a5d595fdbf6c3d658f4becc045af1b6d0b65a5a UFSATM/upp (upp_v10.2.0-319-g4a5d595f)
-179cae1dd84401cf25d250bd9102e66560a9d328 UFSATM/upp/sorc/libIFI.fd
-3d35332fe66e3e63a285cc8d96facdf255a33481 UFSATM/upp/sorc/ncep_post.fd/post_gtg.fd
91c20381ffe0357001a6626b3af1d37354b77cc8 WW3 (6.07.1-471-g91c20381)
05cad173feeb598431e3ef5f17c2df6562c8d101 fire_behavior (v0.2.0-1-g05cad17)
97b24f8e40f1de0980388c8326c48b442e5a5e61 stochastic_physics (ufs-v2.0.0-282-g97b24f8)
NOTES:
[Times](Memory) are at the end of each compile/test in format [MM:SS](Size).
The first time is for the full script (prep+run+finalize).
The second time is specifically for the run phase.
Times/Memory will be empty for failed tests.
BASELINE DIRECTORY: /scratch4/NAGAPE/epic/role-epic/UFS-WM_RT/NEMSfv3gfs/develop-20251021
COMPARISON DIRECTORY: /scratch4/NCEPDEV/stmp/Nick.Szapiro/RT_RUNDIRS/Nick.Szapiro/FV3_RT/rt_3310446
RT.SH OPTIONS USED:
* (-a) - HPC PROJECT ACCOUNT: nems
* (-l) - USE CONFIG FILE: rt_retry.conf
* (-e) - USE ECFLOW
PASS -- COMPILE 's2sw_pdlib_intel' [14:11, 12:58] ( 1 warnings 1036 remarks )
PASS -- TEST 'cpld_warmstart_c48_5deg_intel' [03:39, 01:38](3021 MB)
PASS -- TEST 'cpld_restart_c48_5deg_intel' [02:30, 00:52](2469 MB)
SYNOPSIS:
Starting Date/Time: 20251028 07:24:39
Ending Date/Time: 20251028 07:46:26
Total Time: 00h:21m:51s
Compiles Completed: 1/1
Tests Completed: 2/2
NOTES:
A file 'test_changes.list' was generated but is empty.
If you are using this log as a pull request verification, please commit 'test_changes.list'.
Result: SUCCESS
====END OF URSA REGRESSION TESTING LOG====
—
Reply to this email directly, view it on GitHub
<#2929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APJPDRFV2JRM6XGVPVGOJXL3Z4N4TAVCNFSM6AAAAACI3ZWZH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJVGA2DAMZQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Those two tests passed on Ursa for me (at |
|
@NickSzapiro-NOAA My RT run is success : /scratch4/BMC/gsd-fv3-dev/lzhang/GCAFS/PR/global-workflow/sorc/ufs_model.fd/tests Performing Cleanup... |
|
Great! Yes...please feel free to open PR any time. Sorry for the troubles |
@gspetro-NOAA @NickSzapiro-NOAA @gspetro-NOAA I really appreciate all your helps to guide me for this RT runs and PR. |
|
NOTE: This PR is replaced by PR #2957 . |
20 participants
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
Commit Message:
Priority:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: