Skip to content

Add 'netcdf' and 'grib2' to input 'source' options in regional IC/LBC routines#526

Closed
chan-hoo wants to merge 12 commits into
ufs-community:developfrom
chan-hoo:feature/ic_netcdf
Closed

Add 'netcdf' and 'grib2' to input 'source' options in regional IC/LBC routines#526
chan-hoo wants to merge 12 commits into
ufs-community:developfrom
chan-hoo:feature/ic_netcdf

Conversation

@chan-hoo
Copy link
Copy Markdown
Contributor

@chan-hoo chan-hoo commented Apr 15, 2021

Description

  • Add 'netcdf' and 'grib2' to the input 'source' option in the regional IC/LBC routines of atmos_cubed_sphere.
  • Since the logic of 'netcdf' or 'grib2' in the code is the same as that of 'nemsio', these three types are put in the same category.

Issue(s) addressed

Testing

  • Passed the regression test of the ufs weather model on WCOSS (dell/cray) and Hera with intel compiler.
  • Completed a LAMDA test successfully with 'netcdf' input files from GFS.

Regression tests:

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

Contributors

@JamesAbeles-NOAA, @EricRogers-NOAA

@DeniseWorthen DeniseWorthen added the No Baseline Change No Baseline Change label Apr 15, 2021
@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

@chan-hoo You PR is next in line. Can you please make sure your fv3atm and ufs-weather-model repositories are up to date with the latest develop branch?

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

@chan-hoo , please update the FV3 submodule in your ufs-weather-model branch as well

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

DusanJovic-NOAA commented May 10, 2021

fv3atm branch https://github.com/chan-hoo/fv3atm/tree/feature/ic_netcdf is not up to date with upstream

@chan-hoo
Copy link
Copy Markdown
Contributor Author

@DusanJovic-NOAA @MinsukJi-NOAA , due to a critical technical issue, I'll close this PR and re-open it.

@chan-hoo chan-hoo closed this May 10, 2021
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
Merge in GSL institutional fork
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…n Hera (#526)

* Modifications to scripts to allow the workflow to run to completion
with the GNU build on Hera.  The python/miniconda3 module must be
unloaded prior to running the executable.

* "module" is not the best name for a variable, changed to a_module

* Address comments:

- Clarify message about why modules are being unloaded
- Remove print message if nothing is unloaded to reduce clutter in log file
- Rename "module_to_unload" to "modules_to_unload"
- Change "a_module" to "module_to_unload" for clarity

* Clarify purpose of the unload_python.sh function.

* Add the "why"
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
This PR adds the ensemble (GDAS and GEFS) datasets as options for the SRW App and is part of a bigger effort to merge in RRFS capabilities into the develop branch.

Currently, the workflow ensemble tasks all use the same initial conditions. Because of the addition of the ensemble datasets, each ensemble task can now have its own initial conditions with the global ensemble number mapping to the SRW App ensemble number (i.e. GDAS mem002 corresponds to SRW App mem002).

The appropriate logic was added to these files so that the GEFS and GDAS datasets can run with the workflow without breaking existing functionality. A number of changes were made in the retrieve_data.py script to handle the --members argument and GEFS filename list. A GEFS function was added to the exregional_get_extrn_mdl_files.sh file to merge the GEFS files and update the summary extrn_mdl_var_defns.sh script.

---------

Co-authored-by: Edward Snyder <Edward.Snyder@noaa.com>
Co-authored-by: Michael Lueken <michael.lueken@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

4 participants