Update Thompson MP from gsl/develop, minor CCPP updates, minor regression test script updates by climbfuji · Pull Request #498 · ufs-community/ufs-weather-model

climbfuji · 2021-03-30T14:33:30Z

PR Checklist

Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR contains a whole lot of unrelated changes from various contributors

Updates to auto-rt in PR Add automated baseline jobs to automated regression testing #491 from @BrianCurtis-NOAA
Fixes to the regression testing scripts in branch https://github.com/DusanJovic-NOAA/ufs-weather-model/tree/rt_log_dir_fix from @DusanJovic-NOAA
Change baseline location on gaea to where emc.nemspara can write
Update of submodule pointers for fv3atm, ccpp-framework and ccpp-physics, and new Thompson MP lookup tables for the changes described in the associated PRs below
Remove tests fv3_gfs_v15p2_RRTMGP and fv3_gfs_v15p2_RRTMGP_debug from tests/rt_gnu.conf (same errors as with other GFS v15p2 tests previously, compute_qs: saturation vapor pressure table overflow)

New baselines are required, because all regression tests using Thompson MP or RUC LSM will have different answers.

New input data is required, which can be added to the existing input data directory input-data-20210324:

./FV3_input_data_gsd/*V2.dat
./FV3_regional_input_data/*V2.dat
./FV3_input_data_regional_esg/*V2.dat

New input data copied to:

Issue(s) addressed

Fixes #499
Fixes #496
Fixes #484
Fixes #485
Closes #491

Testing

Code compiles on Hera with Intel and GNU for all CCPP suites.

Regression tests pass against the existing baselines on hera.gnu and hera.intel unless Thompson MP or RUC LSM is used, as expected.

New baselines will be created after this verification is complete.

Baselines created and results verified on:

Dependencies

NCAR/ccpp-framework#357
NCAR/ccpp-physics#600
NOAA-EMC/ufsatm#267
#498

…ranch

Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>

@SMoorthi-emc

* Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) * point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh * Update CICE, Move regression test input outside baseline directory (ufs-community#270) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR ufs-community#312) Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Revert change to .gitmodules and update submodule pointer for fv3atm Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: jiandewang <jiande.wang@noaa.gov> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>

…er updates and bugfixes (ufs-community#52)

…fs-community#55) Code is identical to original/current code in the authoritative repository (NOAA-PSD, branch master)

* Add regression tests with stochastic land perturbations for suites FV3_GSD_v0 and FV3_GSD_noah Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>

…perturbed variables (ufs-community#61) * Updates to regression tests fv3_ccpp_gsd_lndp and fv3_ccpp_gsd_noah_lndp * Bug fix for tests/parm/ccpp_gsd_sar.nml.IN

@SMoorthi-emc

* Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) * point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh * Update CICE, Move regression test input outside baseline directory (ufs-community#270) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR ufs-community#312) Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) * Build on wcoss2 (acorn) * Use -march=core-avx2 instead of -xCORE-AVX2 on wcoss2 * Updates to build for JEDI linking/control * Removed unnecessary include files and INLINE POST setting * Updated to address PR suggestions. * Add rt_acorn.conf. Change /lfs/h2 to /lfs/h1. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * regression test results * Updated .gitmodules and removed extraneous file * Fixed .gitmodules and updated pointer for FV3 * Updated pointer to NEMS repo Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Add GFS v16 beta restart test, update stochastics test * Update regression test baseline date tag to 20201214; skip-ci * tests/rt.conf: bugfix, add missing 'fv3' to new stochy tests; skip-ci * Regression test logs for gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Run GFS v16beta tests also on wcoss; regression test logs for wcoss; skip-ci * Regression test logs for cheyenne.intel and cheyenne.gnu * Revert change to .gitmodules and update submodule pointer for fv3atm * Add optional bulk flux calculation in ufs-datm (ufs-community#266) * Update NEMS DATM and CMEPS to allow the optional bulk flux formulation; add two tests using the option * Update top level CMakeList.txt to have compile flags for MOM6 and CICE6 identical for ufs-cpld and ufs-datm * Add optional configuration variable to nems.configure to specify the directory where CMEPS will write restarts * Adds cheyenne tasking variables to default_vars and sets WW3_COMP to cheyenne for platform cheyenne.intel *NOTE: Baselines develop-20201215 exist on all platforms, regression tests were run against exactly that baseline on all systems except cheyenne.intel. On cheyenne.intel the tests were run against 20201214, and this baseline is identical to 20201215 (as per "diff -r develop-20201214 develop-20201215"). Co-authors: @DusanJovic-NOAA @aerorahul @JessicaMeixner-NOAA skip-ci * Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) * Add the following 2 tests: datm_restart_cfsr, datm_debug_cfsr * Add wcoss_dell_p3.log. * Add Hera log, Orion log, wcoss_dell_p3 log. * RRTMGP and Thompson MP coupling (ufs-community#323) * Feature branch with RRTMGP and Thompson MP * Updated FV3/ccpp-physics. Added namelist and configuration for RRTMGP RTs using GSD physics. * Updated FV3 * Update physics in FV3 * Updated baselines in rt.sh * Updated RT logs. Updated FV3 physics submodule pointer. * Updated FV3 hash and .gitmodules * Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) * Update modules with hpc-stack v1.1.0 (ufs-community#319) * Update modules with hpc-stack v1.1.0 * Minor bug fixes to CCPP UGWP Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) * Replace old FV3_GFS_2017_gfdlmp_regional SDF for regional tests with FV3_GFS_v15_thompson_mynn. * Final path to IC's and new results. Also, input.nml updated. * Update RegressionTests_wcoss_dell_p3.log * Update RegressionTests_wcoss_cray.log * Update RegressionTests_hera.intel.log * Update RegressionTests_jet.intel.log * Update RegressionTests_orion.intel.log * Update RegressionTests_cheyenne* logs. * Update RegressionTests_hera.gnu.log * Feature/ww3update (ufs-community#334) This updates the WW3 submodule pointer to point to the top of the WW3 develop branch. The path to WW3 inputs is changed to input-data-20201201/WW3_input_data_20201207/ * Remove IPD (step 1) (ufs-community#331) Make CCPP=Y the default in tests/compile.sh. Remove CCPP=Y from tests/rt*.conf and adjust formatting. Update submodule pointer for MOM6 to include PR ufs-community#341 ("Update MOM6 to GFDL's 20201218 commit") Add modulefiles/wcoss_cray/fv3_debug (identical to modulefiles/wcoss_cray/fv3) Fix broken utest (see ufs-community#348) * Update the format of rt.conf (ufs-community#349) Update the format of MACHINES column in rt.conf (and other .conf files). This column can be either empty, which means a test will run on all supported machines, or start with - or + sign to exclude or include specified machines explicitly. * Add checkpoint restarts for ufs-cpld (ufs-community#342) * Adds 3 checkpoint restart tests for the ufs-cpld model * Drops the existing c92mx025 restart test * Adds cheyenne.intel as tested configuration for ufs-cpld and ufs-datm * Fixes instances of srf_data* in various fv3_conf files * add frac grid input, update and add additional cpld tests (ufs-community#354) * Updates FV3_input_frac to add both benchmark dates and L127 files * Adds additional tests and restart tests for coupled model * Sets all cpld tests to use frac grid input by default * Removes all instances of USE_LA_LI2016=True except for benchmark+wave configurations * Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) * Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5 * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Remove tests/rt_acorn.conf and run GFS v15p2 and GFS v16beta DEBUG tests on all platforms * Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update submodule pointer for fv3atm; skip-ci * Don't try to compile all suites in DEBUG mode on cheyenne.intel, weird bug on compute nodes; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_cray; skip-ci * Regression test logs for cheyenne.gnu, cheyenne.intel, gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_dell_p3; skip-ci * Regression test logs for wcoss_cray and wcoss_dell_p3 * Revert change to .gitmodules and update submodule pointer for fv3atm * Update CMEPS (ufs-community#345) * Update CMEPS for recent changes, including addition of new run "post" run phases to eliminate redundant mapping, multiple ice sheet capability and ocn->land ice dynamic mapping * Add a new test fv3_gfs_v16_RRTMGP_c192L127 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Remove IPD steps 3 and 5 (ufs-community#357) Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5; skip-ci * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Update usage in rt.sh, add modulefiles/jet.intel/fv3_debug; skip-ci * CCPP is default in cmake build * Add debug modulefiles for linux.gnu and macosx.gnu * Update submodule pointer for fv3atm * Change logic in CMakeLists.txt and tests/compile.sh so that 32BIT=ON automatically sets DYN32=ON; skip-ci * Move logic to set DYN32 - depending on 32BIT setting - to fv3atm * Remove -DCCPP=ON from tests/compile.sh; update submodule pointer for fv3atm; skip-ci * point fv3 to EMC develop branch (ufs-community#377) * update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) * update CMEPS, fix character length error for gnu compile * add Dusan's fix for rt_utils.sh * update cpl gfsv16 tests, replace seaice_newland.grb with global_slmask.t1534.3072.1536.grb, recover input.mom6.nml.IN, update input directory, update global thread and decomp tests, update fdiag for global control * point to Dustins rrtmgp fix branch * update input directory Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces ufs-community#47) (ufs-community#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (ufs-community#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (ufs-community#57) * dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) * Update fv3atm * update ccpp control test forecast length to 24h * remove rename command * Add CI related changes * Update RT logs * Update RT log files * Add the gaea RT log file * Update the point of fv3atm * Update fv3atm Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> * MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) * implements two MOM6 bugfixes in the NUOPC MOM6 cap to allow restart reproducibility when USE_LA_LI2016=True and to change the sign of the latent heat flux associated with frozen precipitation (fprec) exported to MOM6 * updates MOM6 to include the GFDL 20210120 main branch which contains EMC's wave coupling code, alone with some minor code standardization and documentation * updates the cdmbgwd namelist settings for FV3 standalone tests at C96 and implements resolution dependent values for ufs-cpld tests Co-authored-by: Ali <ali.abdolali@noaa.gov> * Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) * Update .gitmodules and submodule pointers for fv3atm and NEMS * Remove Python 2.7 support from top-level CMakeLists.txt * Reduce forecast length of test fv3_ccpp_gfs_v16_RRTMGP_c192L127 from 24h to 12h * Rename v16beta to v16 everywhere except the public release documentation * Bugfixes and missing changes * Remove 'export CCPP_LIB_DIR=ccpp/lib' from all regression tests * Update regression test baseline date tag to 20210128; skip-ci * Update ecflow-python environment on cheyenne and jet; skip-ci * Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) * Add HAFS support in NOAA-EMC/CMEPS * Add coupled and datm tests for Gaea.intel Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> * Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) * Regression test logs for all tier=1 platforms * updates FMS to 2020.04.01 (ufs-community#392) * updates FMS to 2020.04.01 * fixes fms_files.cmake * removes extra horiz_interp * Workaround for FMS 2020.04.01 for Cheyenne with GNU 9.1.0, incl. regression test log Co-authored-by: Mikyung Lee <mlee@Orion-login-1.HPC.MsState.Edu> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> * add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) *Implements an optional setting in the cpld and datm nems.configure files to specify whether the MOM6 cap should use a mesh or a grid *Adds configurable settings for min_seaice to gfs_physics_nml and dz_min to fv_core_nml. * UGWP v0 v1 combined (ufs-community#396) - combines the changes in PRs ufs-community#360 and ufs-community#382 - adds three regression tests `fv3_ccpp_gfsv16_ugwpv1 `, `fv3_ccpp_gfsv16_ugwpv1_warmstart` and `fv3_ccpp_gfsv16_ugwpv1_debug` - contains updates and bugfixes for `nc_compare.py` and the CI tests from @MinsukJi-NOAA - update Python3 environment on jet.intel, gaea.intel, cheyenne.{intel,gnu} - turn off (again) test `fv3_ccpp_decomp` on jet.intel, this test didn't work in the past, but recently it "passed", because the error checking with `nc_compare.py` failed silently and we didn't notice it Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> * Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) * Add one regional regression test in DEBUG mode. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update regression tests from GFSv15+Thompson to GFSv16+Thompson * Combine several COMPILE lines in tests/rt.conf and tests/rt_gnu.conf * Regression test log for cheyenne.{gnu,intel},gaea.intel, hera.gnu, jet.intel,hera.intel,orion.intel;wcoss_cray and wcoss_dell_p3; Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: jiandewang <jiande.wang@noaa.gov> Co-authored-by: Denise Worthen <denise.worthen@noaa.gov> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Mark Potts <33099090+mark-a-potts@users.noreply.github.com> Co-authored-by: BinLi-NOAA <bin.li@noaa.gov> Co-authored-by: dustinswales <dustin.swales@noaa.gov> Co-authored-by: Kyle Gerheiser <3209794+kgerheiser@users.noreply.github.com> Co-authored-by: RatkoVasic-NOAA <37597874+RatkoVasic-NOAA@users.noreply.github.com> Co-authored-by: Ali.Abdolali <37336972+aliabdolali@users.noreply.github.com> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> Co-authored-by: XiaqiongZhou-NOAA <48254930+XiaqiongZhou-NOAA@users.noreply.github.com> Co-authored-by: Ali <ali.abdolali@noaa.gov> Co-authored-by: Bin Li <Bin.Li@gaea13.ncrc.gov> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: valery.yudin <valery.yudin@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov> Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov>

…ufs-community#64) * Update submodule pointer for fv3atm

…community#65) * Update submodule pointer for fv3atm * Copy new Thompson tables from temporary location

…-model into develop

…_from_master_20210316 Update gsl/develop from develop 20210316

…script

…AA/ufs-weather-model into feature/autort-bl

…s it should not before starting the job

DeniseWorthen · 2021-03-31T19:02:17Z

 #BSUB -eo err
 #BSUB -J @[JBNME]
-#BSUB -W 00:45
+#BSUB -W 01:00:00


Using #BSUB -W 00:50 allowed both compile 16 and 17 to complete--about 2800 secs each.

Ok, let me make this change.

climbfuji · 2021-03-31T19:12:08Z

All, noting that the CI tests passed after I added the fix suggested by @MinsukJi-NOAA. No need to run again at the end.

…ss_dell_p3; set to 50 mins

climbfuji · 2021-03-31T19:15:02Z

Also noting that I fixed rt_ccpp_dev.conf and successfully created a personal baseline and verified against it on Hera using both GNU and Intel.

rt_ccpp_dev_hera_gnu_create.log
rt_ccpp_dev_hera_gnu_verify.log
rt_ccpp_dev_hera_intel_create.log
rt_ccpp_dev_hera_intel_verify.log

…ssion test logs for jet.intel, wcoss_dell_p3, wcoss_cray

DeniseWorthen

Approved on the basis of RTs passing.

climbfuji · 2021-03-31T20:02:09Z

Thanks @DeniseWorthen for running the tests on WCOSS.

climbfuji · 2021-03-31T20:22:08Z

@BrianCurtis-NOAA auto-bl/auto-rt on gaea worked. I also ran the tests manually against your baseline, and they also passed. That system seems to work. Do I need to pull in updates from your branch before we merge this PR?

…aa/ufs-weather-model into update_thompson_mp_from_gsl_develop_and_more

…//github.com/climbfuji/ufs-weather-model into update_thompson_mp_from_gsl_develop_and_more

BrianCurtis-NOAA

baseline/RT passed. Approved

junwang-noaa

The .gitmodules needs to be updated after fv3 is committed

climbfuji · 2021-03-31T20:47:27Z

Ready to merge!

* Add explict treatment of convective cloud to RRTMGP. * Some cleanup and bug fixes from previous commit. working now with Thompson MP plus radiatively active convective cloud. * Updated physics. New interstitials. * Added explicit MYNN-EDMF cloud coupling to RRTMGP. * Added switches for sgs clouds in GP. * Replaced cld_mynn_ naming convention with cld_pbl_ * Fixed inconsistency between G/GP in Thompson MP. * Some more cleanup of cloud-fraction... * Pulled in Qingfu's changes to ccpp-physics * Synced physics with main * Updated physics. * Revert change from previous commits (sampling of different cloud types). New SDFs for p8c * Changed arguments to implied shape. * Renamed scheme file in SDF. Now common to both RRTMG and RRTMGP SDFs * Syntax error in ccpp-physics * Revert changes to names * Renamed p8_rrtmgp SDFs * Added bounding to temperature at layer-interface used by RRTMGP. * Reorder loop * Combined gp sw and lw aerosol routines. Modest speedup (~4%)

* update build process img * update img * Revert changes This reverts commit b839658. * BuildSRW updates - esp mac/linux * remove Contributor's Guide * update Glossary and RunSRW * update build/run process images * remove outdated images; add new * Components & CCPP updates, misc * ConfigWflow updates * Container updates * update FAQ * graphics updates * I/O updates * Intro updates * Grid ch updates * Grid ch updates * Quickstart Updates * Rocoto edits * WE2E ch * update supported tests * update fix file list * minor update * minor edits * minor edits * misc minor fixes * change /home to /Users/gillianpetro * fix geopotential height * update hpc-stack doc link * nperlin changes * nperlin changes Co-authored-by: gspetro <gillian.s.petro@gmail.com>

climbfuji and others added 30 commits November 25, 2020 13:33

Update .gitmodules and submodule pointer for fv3atm for gsl/develop b…

ff98902

…ranch

Update submodule pointer for fv3atm / ccpp-physics - MYNN surface lay…

d5fa4c1

…er updates and bugfixes (ufs-community#52)

Update stochastic_physics submodule to point to NOAA-GSL gsl/develop (u…

57a8258

…fs-community#55) Code is identical to original/current code in the authoritative repository (NOAA-PSD, branch master)

Land stochastic perturbations (ufs-community#57)

72d48f3

* Add regression tests with stochastic land perturbations for suites FV3_GSD_v0 and FV3_GSD_noah Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>

Stochastic land perturbations: add roughness length over land to the …

77f56a4

…perturbed variables (ufs-community#61) * Updates to regression tests fv3_ccpp_gsd_lndp and fv3_ccpp_gsd_noah_lndp * Bug fix for tests/parm/ccpp_gsd_sar.nml.IN

Remove inconsistencies in computation of air density with Thompson MP (…

99bd3e4

…ufs-community#64) * Update submodule pointer for fv3atm

Update thompson mp 20210213 (ufs-community#567) for gsl/develop (ufs-…

98fa7cc

…community#65) * Update submodule pointer for fv3atm * Copy new Thompson tables from temporary location

Merge branch 'gsl/develop' of https://github.com/NOAA-GSL/ufs-weather…

630faf9

…-model into develop

Revert change to .gitmodules and update submodule pointer for fv3atm

6563784

Merge pull request ufs-community#67 from climbfuji/update_gsl_develop…

f204bfd

…_from_master_20210316 Update gsl/develop from develop 20210316

Save rt timing logs in current working dir from job_card and compile …

34b73e8

…script

update rt.sh

e71a31c

minor change in compile.sh

5b7f8d2

Old repo went stale, trying fresh

dbd2b50

Check for BL_DATE in PR body BEFORE getting far into the Job

c7ca541

Raised error at wrong point in get_bl_date()

de8a812

BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210324

b68615f

change rt.sh to work for code

c91b9d6

Merge branch 'feature/autort-bl' of https://github.com/BrianCurtis-NO…

8c5cdf9

…AA/ufs-weather-model into feature/autort-bl

Make logging better in update_rt_sh

4134be2

Lets not go through with the BL job if the directory already exists a…

1447195

…s it should not before starting the job

BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210331

29f1944

Search for BL_DATE= not BL_DATE as the latter is not unique

58da308

need to test date that doesn't match code

a256db4

BL JOBS PASSED: hera.gnu. Updated rt.sh with new develop date: 20210331

7798cac

Adjusting to upstream date for test with RT

1168e41

RT JOBS PASSED: hera.gnu. Log file uploaded. skip-ci

2bce7e4

BrianCurtis-NOAA added gaea-intel-BL and removed gaea-intel-BL labels Mar 31, 2021

DeniseWorthen reviewed Mar 31, 2021

View reviewed changes

climbfuji added 2 commits March 31, 2021 13:12

Fix typo in syntax for walltime in tests/fv3_conf/compile_bsub.IN_wco…

e60bcb3

…ss_dell_p3; set to 50 mins

Regression test logs for orion.intel

488335a

Update path to regression test baseline for jet in tests/rt.sh; regre…

cf50a3a

…ssion test logs for jet.intel, wcoss_dell_p3, wcoss_cray

DeniseWorthen approved these changes Mar 31, 2021

View reviewed changes

DusanJovic-NOAA approved these changes Mar 31, 2021

View reviewed changes

RT JOBS PASSED: gaea.intel. Log file uploaded.

41a97a3

BrianCurtis-NOAA and others added 3 commits March 31, 2021 20:25

Fixes from Gaea tests

db102d0

Merge branch 'feature/autort-bl' of https://github.com/briancurtis-no…

a9e921c

…aa/ufs-weather-model into update_thompson_mp_from_gsl_develop_and_more

Merge branch 'update_thompson_mp_from_gsl_develop_and_more' of https:…

ba25b4d

…//github.com/climbfuji/ufs-weather-model into update_thompson_mp_from_gsl_develop_and_more

BrianCurtis-NOAA approved these changes Mar 31, 2021

View reviewed changes

junwang-noaa approved these changes Mar 31, 2021

View reviewed changes

Revert change to .gitmodules and update submodule pointer for fv3atm

28f4ad2

climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 31, 2021

DusanJovic-NOAA merged commit f89f5be into ufs-community:develop Mar 31, 2021

climbfuji mentioned this pull request Mar 31, 2021

Update gsl/develop from develop 2021/03/31 NOAA-GSL/ufs-weather-model#69

Merged

epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023

Modify fix-file list for Thompson scheme (#498)

d068071

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Thompson MP from gsl/develop, minor CCPP updates, minor regression test script updates#498

Update Thompson MP from gsl/develop, minor CCPP updates, minor regression test script updates#498
DusanJovic-NOAA merged 64 commits into
ufs-community:developfrom
climbfuji:update_thompson_mp_from_gsl_develop_and_more

climbfuji commented Mar 30, 2021 •

edited

Loading

Uh oh!

DeniseWorthen Mar 31, 2021

Uh oh!

climbfuji Mar 31, 2021

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

DeniseWorthen left a comment

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

BrianCurtis-NOAA left a comment

Uh oh!

junwang-noaa left a comment

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

climbfuji commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Description

Issue(s) addressed

Testing

Dependencies

Uh oh!

DeniseWorthen Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

climbfuji Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

DeniseWorthen left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

junwang-noaa left a comment

Choose a reason for hiding this comment

Uh oh!

climbfuji commented Mar 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

climbfuji commented Mar 30, 2021 •

edited

Loading