Skip to content

Update input data consistent with P6#537

Merged
DeniseWorthen merged 59 commits into
ufs-community:developfrom
DeniseWorthen:feature/update_input
May 13, 2021
Merged

Update input data consistent with P6#537
DeniseWorthen merged 59 commits into
ufs-community:developfrom
DeniseWorthen:feature/update_input

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 20, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • Updates FV3_input_frac oro data and IC for full lakes only, consistent with input used for P6: Source directory: /scratch2/BMC/gsd-fv3-dev/FV3-MOM6-CICE5/inputdata_lakeint_p6/FV3_input_frac

  • Sets nst_anl=.true for benchmark v16 tests

  • Switches to using a mesh for MOM6 in the cap (use_mommesh is set true). See original issue #398

  • adds 2 additional suites: suite_FV3_GFS_v16_coupled_noahmp.xml, suite_FV3_GFS_v16_coupled_nsstNoahmp.xml

  • A new input-data-20210518 has been staged on on platforms. This was created by first rsync'ing the current input-data-20210428 and then updating the files in the FV3_input_frac and the mesh.mx100.nc files in the CICE_FIX directories.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Related issue #564. When na_init=1, the bottom fields exported by ATM are expected to depend on dt. The fact that changing the timestep to 300s in P6 appeared to fix many of the cases which failed on startup is most likely due to chance. When dt was changed, the change in the bottom fields happened to remove the negative zbot which was sent to ICE.

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Pre-commit testing on Gaea: a temporary baseline was created using the updated data and then verified against that baseline. All coupled and DATM tests passed. Standalone ATM tests were not run.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

GFDL_atmos_cubed_sphere PR #102
fv3atm PR#294

co-author: @shansun6
co-author: @XiaqiongZhou-NOAA

@DeniseWorthen DeniseWorthen self-assigned this Apr 20, 2021
@DeniseWorthen DeniseWorthen added Baseline Updates Current baselines will be updated. Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. labels Apr 20, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Machine: jet
Compiler: intel
Job: BL
Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/619583652/20210512180203/ufs-weather-model
Please manually delete: /lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT/rt_174184
Test cpld_debug 017 failed in run_test failed
Test cpld_debugfrac 018 failed in run_test failed
Test cpld_control 001 failed in run_test failed
Test cpld_controlfrac 002 failed in run_test failed
Test cpld_satmedmf 003 failed in run_test failed
Test cpld_ca 004 failed in run_test failed
Test cpld_controlfrac_c192 006 failed in run_test failed
Test cpld_bmarkfrac_v16 011 failed in run_test failed
Test cpld_bmarkfrac_v16_nsst 012 failed in run_test failed
Test cpld_control_c384 007 failed in run_test failed
Test cpld_bmarkfrac 010 failed in run_test failed
Test cpld_bmark 009 failed in run_test failed
Test cpld_controlfrac_c384 008 failed in run_test failed
Test cpld_control_wave 016 failed in run_test failed
Test cpld_control_c192 005 failed in run_test failed
Test cpld_bmarkfrac_wave_v16 015 failed in run_test failed
Test cpld_bmarkfrac_wave 014 failed in run_test failed
Test cpld_bmark_wave 013 failed in run_test failed
Test fv3_stretched 034 failed in run_test failed
Test fv3_stretched_nest 035 failed in run_test failed
Test fv3_regional_quilt 038 failed in run_test failed
Test fv3_regional_quilt_hafs 039 failed in run_test failed
Test fv3_regional_quilt_RRTMGP 041 failed in run_test failed
Test fv3_regional_control 036 failed in run_test failed
Test fv3_regional_quilt_netcdf_parallel 040 failed in run_test failed
Test fv3_csawmg 045 failed in run_test failed
Test fv3_rrfs_v1alpha 052 failed in run_test failed
Test fv3_gsd 051 failed in run_test failed
Test fv3_thompson 053 failed in run_test failed
Test fv3_thompson_no_aero 054 failed in run_test failed
Test fv3_gfdlmprad_gwd 043 failed in run_test failed
Test fv3_gfs_v16_RRTMGP 057 failed in run_test failed
Test fv3_gfs_v16_stochy 056 failed in run_test failed
Test fv3_gfs_v16 055 failed in run_test failed
Test fv3_gfs_v16_RRTMGP_debug 068 failed in run_test failed
Test fv3_gfs_v16_debug 067 failed in run_test failed
Test fv3_gfsv16_csawmgt 059 failed in run_test failed
Test fv3_gfsv16_csawmg 058 failed in run_test failed
Test fv3_rrfs_v1beta_debug 076 failed in run_test failed
Test fv3_gsd_diag3d_debug 073 failed in run_test failed
Test fv3_thompson_debug 074 failed in run_test failed
Test fv3_gsd_debug 072 failed in run_test failed
Test fv3_regional_control_debug 069 failed in run_test failed
Test fv3_stretched_nest_debug 071 failed in run_test failed
Test fv3_rrfs_v1alpha_debug 077 failed in run_test failed
Test fv3_thompson_no_aero_debug 075 failed in run_test failed
Test fv3_gfsv16_ugwpv1 064 failed in run_test failed
Test fv3_gfsv16_ugwpv1_warmstart 065 failed in run_test failed
Test fv3_HAFS_v0_hwrf_thompson 062 failed in run_test failed
Test fv3_esg_HAFS_v0_hwrf_thompson 063 failed in run_test failed
Test fv3_gfs_v16_ras 066 failed in run_test failed
Test fv3_esg_HAFS_v0_hwrf_thompson_debug 079 failed in run_test failed
Test fv3_gfsv16_ugwpv1_debug 080 failed in run_test failed
Test fv3_HAFS_v0_hwrf_thompson_debug 078 failed in run_test failed
Test fv3_gfs_v16_ras_debug 081 failed in run_test failed
Test fv3_gocart_clm 060 failed in run_test failed
Test fv3_gfs_v16_flake 061 failed in run_test failed
Test datm_debug_cfsr 088 failed in run_test failed
Test datm_cdeps_debug_cfsr 095 failed in run_test failed
Test datm_control_cfsr 082 failed in run_test failed
Test datm_bulk_cfsr 084 failed in run_test failed
Test datm_mx025_cfsr 086 failed in run_test failed
Test datm_mx025_gefs 087 failed in run_test failed
Test datm_bulk_gefs 085 failed in run_test failed
Test datm_control_gefs 083 failed in run_test failed
Test datm_cdeps_control_cfsr 089 failed in run_test failed
Test datm_cdeps_bulk_cfsr 091 failed in run_test failed
Test datm_cdeps_mx025_cfsr 093 failed in run_test failed
Test datm_cdeps_bulk_gefs 092 failed in run_test failed
Test datm_cdeps_mx025_gefs 094 failed in run_test failed
Test datm_cdeps_control_gefs 090 failed in run_test failed
Test fv3_gfdlmprad 096 failed in run_test failed
Test fv3_gfdlmprad_atmwav 097 failed in run_test failed
Please make changes and add the following label back:
jet-intel-BL

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented May 12, 2021

There appears to be a problem with the new input data directory. Some files are missing, some directories I can't ls. Since the entire auto-BL seems to have failed, I will re-sync the input from Hera.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented May 12, 2021

There is not enough space to rsync the input directory from my local directory (where I transferred from Globus) to the baseline area.

5.2G	./Minsuk.Ji
2.7T	./Bin.Li
106G	./Brian.Curtis
2.1G	./Mikyung.Lee
230G	./Denise.Worthen
1.4G	./Jun.Wang
8.8T	./emc.nemspara
24K	./Dusan.Jovic
12T	.

I've clean out (removed the rt_*) in /mnt/lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT and emc.nemspara is now down to 2.0T.

@binli2337 please delete what you can.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

There is not enough space to rsync the input directory from my local directory (where I transferred from Globus) to the baseline area.

5.2G	./Minsuk.Ji
2.7T	./Bin.Li
106G	./Brian.Curtis
2.1G	./Mikyung.Lee
230G	./Denise.Worthen
1.4G	./Jun.Wang
8.8T	./emc.nemspara
24K	./Dusan.Jovic
12T	.

I've clean out (removed the rt_*) in /mnt/lfs4/HFIP/h-nems/emc.nemspara/RT_RUNDIRS/emc.nemspara/FV3_RT and emc.nemspara is now down to 2.0T.

@binli2337 please delete what you can.

I deleted my files.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Machine: orion
Compiler: intel
Job: BL
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/619583652/20210512124508/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_55918
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/619583652/20210512222251/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_297177
Test cpld_restart_bmark 018 failed failed
Test cpld_restart_bmark 018 failed in run_test failed
Test cpld_restart_bmarkfrac_v16 023 failed failed
Test cpld_restart_bmarkfrac_v16 023 failed in run_test failed
Please make changes and add the following label back:
orion-intel-BL

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

Still waiting for the two failed orion jobs. Since the restart jobs were the ones that failed, this will actually require 4 jobs to complete.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

At this point since we think it's just a system problem and not a code problem, we should just move on without those two tests?

* repeated two tests after initial failure; both passed
* cpld_restart_bmark, cpld_restart_bmarkfrac_v16
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

All RTs are complete and pass. My FV3 branch now points to updated dycore (3720aea). After fv3 is merged I will revert my submodules and run-ci.

@junwang-noaa
Copy link
Copy Markdown
Collaborator

junwang-noaa commented May 13, 2021 via email

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fv3atm has is correct, changes look good

@DeniseWorthen DeniseWorthen merged commit 6572e78 into ufs-community:develop May 13, 2021
@DeniseWorthen DeniseWorthen deleted the feature/update_input branch May 25, 2021 12:23
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* WE2E test for MET validation.

* Add a header to the config file.

* Update config.MET_validation.sh

* Change 'validation' to 'verification'

Co-authored-by: JeffBeck-NOAA <55201531+JeffBeck-NOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

7 participants