Skip to content

Bring in flake updates from ccpp-physics. Compile issue with esmf 810bs47 debug on WCOSS_Cray.#532

Merged
junwang-noaa merged 17 commits into
ufs-community:developfrom
BrianCurtis-NOAA:flake_from_yihua
Apr 19, 2021
Merged

Bring in flake updates from ccpp-physics. Compile issue with esmf 810bs47 debug on WCOSS_Cray.#532
junwang-noaa merged 17 commits into
ufs-community:developfrom
BrianCurtis-NOAA:flake_from_yihua

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Apr 16, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

Bring in changes from upstream fv3/ccpp/physics for flake model

Issue(s) addressed

Resolves #512

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

Depends NOAA-EMC/ufsatm#270
Depends NCAR/ccpp-physics#588

ISSUE

WCOSS Cray will not compile with esmf 810bs47 debug

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review April 16, 2021 20:46
@BrianCurtis-NOAA BrianCurtis-NOAA added enhancement New feature or request No Baseline Change No Baseline Change cheyenne-gnu-RT and removed cheyenne-intel-RT labels Apr 16, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

WCOSS Cray compile failure:
Working dir: /gpfs/hps3/stmp/Brian.Curtis/FV3_RT/rt_29515
Test compile 014 failed failed
Test compile 012 failed failed
Test compile 013 failed failed

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

Looking through all 3 compiles have the same error:

CMake Error at CMakeModules/Modules/FindESMF.cmake:89 (message):
  Neither the dynamic nor the static ESMF library was found
Call Stack (most recent call first):
  CMakeLists.txt:135 (find_package)

Looking through the log it shows 39) esmf/810bs47-debug being loaded

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

In case there's another commit, it says all 10 run-ci checks have passed.

@junwang-noaa
Copy link
Copy Markdown
Collaborator

junwang-noaa commented Apr 19, 2021 via email

@junwang-noaa
Copy link
Copy Markdown
Collaborator

Brian, can you update the dependencies in this PR?

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of the PR regarding the failing debug tests on wcoss_cray due to the library being reinstalled, other than that ok.

@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Flake from yihua Bring in flake updates from ccpp-physics. Compile issue with esmf 810bs47 debug on WCOSS_Cray. Apr 19, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

Updated PR title and description. Let me know if title edit too much info.

@climbfuji
Copy link
Copy Markdown
Collaborator

Ok with me, ready to merge. Thanks for updating the PR description.

@junwang-noaa junwang-noaa merged commit 39febc2 into ufs-community:develop Apr 19, 2021
@BrianCurtis-NOAA BrianCurtis-NOAA deleted the flake_from_yihua branch March 22, 2023 13:07
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
* Changes to ccpp to support 32-bit physics in NRL Neptune model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update flake physics

3 participants