Bring in flake updates from ccpp-physics. Compile issue with esmf 810bs47 debug on WCOSS_Cray.#532
Merged
junwang-noaa merged 17 commits intoApr 19, 2021
Conversation
Collaborator
Author
|
WCOSS Cray compile failure: |
Collaborator
Author
|
Looking through all 3 compiles have the same error: Looking through the log it shows |
Collaborator
Author
|
In case there's another commit, it says all 10 run-ci checks have passed. |
Collaborator
|
It looks to me that esmf/8_1_0_beta_snapshot_47 lib was re-installed (issue
#192 <NOAA-EMC/hpc-stack#192>). nceplibs needs to
fix it.
…On Sun, Apr 18, 2021 at 10:02 PM Brian Curtis ***@***.***> wrote:
In case there's another commit, it says all 10 run-ci checks have passed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#532 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TML5SUY2DSQMWZ7AF3TJOFMZANCNFSM43CDZXFQ>
.
|
Collaborator
|
Brian, can you update the dependencies in this PR? |
junwang-noaa
approved these changes
Apr 19, 2021
climbfuji
approved these changes
Apr 19, 2021
Collaborator
climbfuji
left a comment
There was a problem hiding this comment.
Please update the description of the PR regarding the failing debug tests on wcoss_cray due to the library being reinstalled, other than that ok.
Collaborator
Author
|
Updated PR title and description. Let me know if title edit too much info. |
Collaborator
|
Ok with me, ready to merge. Thanks for updating the PR description. |
13 tasks
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model
that referenced
this pull request
Apr 4, 2023
* Changes to ccpp to support 32-bit physics in NRL Neptune model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
Bring in changes from upstream fv3/ccpp/physics for flake model
Issue(s) addressed
Resolves #512
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
Depends NOAA-EMC/ufsatm#270
Depends NCAR/ccpp-physics#588
ISSUE
WCOSS Cray will not compile with esmf 810bs47 debug