Skip to content

Merge HAFSv1 related developments back to the develop branch#1518

Merged
jkbk2004 merged 42 commits into
ufs-community:developfrom
hafs-community:feature/mn_cleanup_202211
Dec 15, 2022
Merged

Merge HAFSv1 related developments back to the develop branch#1518
jkbk2004 merged 42 commits into
ufs-community:developfrom
hafs-community:feature/mn_cleanup_202211

Conversation

@BinLiu-NOAA
Copy link
Copy Markdown
Contributor

@BinLiu-NOAA BinLiu-NOAA commented Dec 4, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Bring in HAFSv1 related developments back to ufs-weather-model develop branch.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

  • Regression testing were conducted at the ufs-weather-model level and the HAFS application level.
  • Only HAFS related regression tests get changing results (which is expected). All other regression tests got identical results. This does indicate new baseline will need be created at least for the HAFS related RTs.
  • Note: No updates for input data

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

BinLiu-NOAA and others added 25 commits April 14, 2022 21:25
netcdf_parallel) write_grid_component option for HAFS RTs.
…t the cap

driver time steps (coupling time steps)
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: BL
[BL] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1144582046/20221213070011/ufs-weather-model
Please make changes and add the following label back: orion-intel-BL

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: BL
[BL] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1144582046/20221213130017/ufs-weather-model
Please make changes and add the following label back: jet-intel-BL

@jkbk2004
Copy link
Copy Markdown
Collaborator

All tests are done. We can start merging process.

Note: need another round of FV3 submodule update before the PR merge.
@jkbk2004
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA fv3atm pr was merged. We can finish merging the pr. Please, update the fv3atm submodule pointer.

@BinLiu-NOAA
Copy link
Copy Markdown
Contributor Author

@jkbk2004, done, all the submodules are up to date now. Thanks a lot!

@jkbk2004
Copy link
Copy Markdown
Collaborator

@jkbk2004, done, all the submodules are up to date now. Thanks a lot!

@BinLiu-NOAA Great to see heavy changes finalized. merging now.

@jkbk2004 jkbk2004 merged commit c81a2f1 into ufs-community:develop Dec 15, 2022
@BinLiu-NOAA BinLiu-NOAA deleted the feature/mn_cleanup_202211 branch November 26, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring in HAFSv1 related developments Modularization of moving nest and storm tracker functionality.

7 participants