Refactor surface restart logic in FV3GFS_io.F90 to not use hard-coded indices.

[SamuelTrahanNOAA]

PR Checklist

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.

• Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

• New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

The surface restart used hard-coded indices, which makes it difficult to add new restart variables, especially if different land surface schemes need different numbers of variables. This is problematic for developer @tanyasmirnova who has that exact problem.

Issue(s) addressed

NOAA-EMC/ufsatm#604

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• acorn.intel
• opnReqTest for newly added/changed feature
• CI

Dependencies

fv3atm = NOAA-EMC/ufsatm#605

[jkbk2004]

@BrianCurtis-NOAA can we double check on wcoss2? I am going to test on other machines.

[SamuelTrahanNOAA]

The automatic checks are failing due to a strange error:

Run helper_id=$(cat ~/id_file)
cat: /home/runner/id_file: No such file or directory
Error: Process completed with exit code 1.

[BrianCurtis-NOAA]

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1127767038/20221219203009/ufs-weather-model
Please make changes and add the following label back: jet-intel-RT

[SamuelTrahanNOAA]

Are the tests running? I don't see any jobs under emc.nemspara on Jet, and the github checks are failing because of an internal error.

[jkbk2004]

@zach1221 is manually testing on jet. I am running on cheyenne as well.

[jkbk2004]

The automatic checks are failing due to a strange error:

Run helper_id=$(cat ~/id_file)
cat: /home/runner/id_file: No such file or directory
Error: Process completed with exit code 1.

I don't worry about this error. It tries to pick up git workflow run id. It was used in run-ci to handle the label.

[jkbk2004]

jet is very slow. Tests are running ok but only halfway overnight. We can skip jet. @SamuelTrahanNOAA we can start merging process.

[jkbk2004]

@SamuelTrahanNOAA fv3atm dependency was merged. we can merge in this pr with submodule update and revert in gitmodules.

[SamuelTrahanNOAA]

I'm pointing to the NOAA-EMC fv3atm develop now.