Momentum flux fix for HAFS FV3ATM-HYCOM coupling#3
Merged
Conversation
HYCOM coupling. The momentum flux received from CMEPS/FV3ATM are from sea to air (friction to air). However, the momentum flux expected and used in HYCOM should be air to sea (wind stress). Thus, we need to reverse the sign when retrieving taux/y in NUOPC/hycom_couple.F90.
This was referenced Dec 4, 2022
BinLiu-NOAA
requested review from
MariaAristizabal-NOAA,
danrosen25 and
hyunsookkim-NOAA
Collaborator
|
The fix should be preferably done in CMEPS not in the NUOPC cap for HYCOM. Given additional code required at the CMEPS level , this quick and easy fix would serve the purpose for now. |
Collaborator
MariaAristizabal-NOAA
left a comment
MariaAristizabal-NOAA
left a comment
There was a problem hiding this comment.
This looks good to me. Also the explanation makes it very clear why the sign change was necessary. This pull request can be merged.
danrosen25
approved these changes
Dec 9, 2022
danrosen25
left a comment
danrosen25
left a comment
There was a problem hiding this comment.
I believe this makes sense. I think we added taux10 and tauy10 as fields and we can modify them as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to correctly use momentum flux received from CMEPS/FV3ATM for HAFS HYCOM coupling. The momentum flux received from CMEPS/FV3ATM are from sea to air (friction to air). Whereas, the momentum flux expected and used in HYCOM should be air to sea (wind stress). Thus, we need to reverse the sign when retrieving taux/y in NUOPC/hycom_couple.F90.