Add the tc_pbl option used by HAFSv1 for GFS TKE EDMF PBL scheme#27
Merged
grantfirl merged 11 commits intoDec 14, 2022
Merged
Conversation
Updated Physics Files
Add a tc_pbl option for the GFS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling
This was referenced Dec 4, 2022
BinLiu-NOAA
requested review from
ChunxiZhang-NOAA and
grantfirl
as code owners
AndrewHazelton
suggested changes
Dec 5, 2022
AndrewHazelton
left a comment
AndrewHazelton
left a comment
There was a problem hiding this comment.
Doesn't GFS_typedefs.F90 need to change as well? Or has that already been updated?
AndrewHazelton
approved these changes
Dec 5, 2022
chxmoonlight
reviewed
Dec 5, 2022
chxmoonlight
suggested changes
Dec 5, 2022
Collaborator
chxmoonlight
left a comment
chxmoonlight
left a comment
There was a problem hiding this comment.
I suggest moving the line 1205-1209 after line 1199. This change is related to the configuration of HAFS-A (under tc_pbl=0) and do not need to be included for HAFS-B since our changes already have this function.
grantfirl
reviewed
Dec 7, 2022
grantfirl
reviewed
Dec 7, 2022
grantfirl
reviewed
Dec 7, 2022
grantfirl
reviewed
Dec 7, 2022
…the tc_pbl option.
Collaborator
|
Bfac is used in the PBL height definition. Source: Vogelezang, D. H. P.,
and A. A. M. Holtslag, 1996: Evaluation
and model impacts of alternative boundary-layer height
formulations. Bound.-Layer Meteor., 81, 245–269, https://doi.
org/10.1007/BF02430331.
We could leave it as 100 as it is the best result in the paper.
Mfac is for the tapering off of MF.
…-Xiaomin
On Wed, Dec 7, 2022 at 2:39 PM Bin Liu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/satmedmfvdifq.F
<#27 (comment)>
:
> @@ -242,6 +249,8 @@ subroutine satmedmfvdifq_run(im,km,progsigma,ntrac,ntcw,ntrw, &
real(kind=kind_phys) qlcr, zstblmax, hcrinv
!
real(kind=kind_phys) h1
+
+ real(kind=kind_phys) bfac, mffac
@chxmoonlight <https://github.com/chxmoonlight> or @AndrewHazelton
<https://github.com/AndrewHazelton>, could you help to answer/address
@grantfirl <https://github.com/grantfirl>'s comments/questions here?
Thanks!
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APW7FERX2L2CAKATS5CK2NLWMDRYTANCNFSM6AAAAAASSB5DME>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
parameter (according to @grantfirl's suggestion).
|
@JongilHan66 Please review this PR at your convenience. |
… to PR review comments/suggestions.
|
all regression tests are done on ufs wm pr 1518. please, go ahead to start merging in this pr. |
grantfirl
approved these changes
Dec 14, 2022
ChunxiZhang-NOAA
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the tc_pbl option for GFS TKE EDMF PBL scheme, which is used by HAFSv1B configuration.
This modifications are LES-based changes for tropical cyclone simulation (from @chxmoonlight and @AndrewHazelton, from AOML). Reference: Chen et al., (2022, https://doi.org/10.1175/WAF-D-21-0168.1).
Related Issues and/or Pull Requests