Add SPP to the SRW App by JeffBeck-NOAA · Pull Request #685 · ufs-community/regional_workflow

JeffBeck-NOAA · 2022-02-26T03:43:47Z

DESCRIPTION OF CHANGES:

This PR adds SPP to the SRW App. Options exist to perturb RUC and Noah LSM (with the &nam_sfcperts namelist block) and MYNN PBL, MYNN SFC, Thompson MP, RRTMG, and GSL GWD (with the &nam_sppperts namelist block). Default values for these namelist entries can be found in config_defaults.sh. For a full description of SPP, please refer to the ufs-weather-model PR here and related GitHub issue here.

TESTS CONDUCTED:

Simulations were run on Hera with and without SPP from both namelist blocks using the RRFS_CONUS_3km and the "ensemble_2mems" WE2E tests. All tests completed successfully.

DEPENDENCIES:

PR #218 in ufs-srweather-app depends on this PR.

DOCUMENTATION:

A PR updating the Users' Guide for SPP will be opened in the ufs-srweather-app repo once major documentation changes associated with PR #212 are merged.

CONTRIBUTORS (optional):

Thanks are due to @gsketefian for his help with namelist entry creation and @ericaligo-NOAA for help with nems.configure.

… into feature/spp

… namelist when not using SPP.

…alues are now handled in the generate script if using SPP.

…SAR SDF

… into HEAD

… into feature/spp

… LSM SPP is turned on.

… into feature/spp

…now.

… into feature/spp

…orkflow into feature/spp

…separate PR.

…tation changes.

JeffBeck-NOAA · 2022-03-03T23:48:21Z

 "gfs_phys",    "skebu_wts",     "skebu_wts",     "fv3_history",  "all", .false., "none", 2
 "gfs_phys",    "skebv_wts",     "skebv_wts",     "fv3_history",  "all", .false., "none", 2
-"dynamics",    "diss_est",      "diss_est",      "fv3_history",  "all", .false., "none", 2
 "gfs_phys",    "shum_wts",      "shum_wts",      "fv3_history",  "all", .false., "none", 2


Remove tendency-based stochastic physics dissipation estimate (diss_est) from diag_table files. It doesn't exist (yet).

JeffBeck-NOAA · 2022-03-03T23:50:28Z

-    do_shum = .false.
-    do_skeb = .false.
-    do_sppt = .false.
    dspheat = .true.


Remove stochastic physics settings from the input namelist template file, as they are not static values applicable to all potential configurations of the SRW App. They are filled in based on choices made by the user in config.sh.

These are default values in the model, anyway, no? Removing them makes sense. :)

Yep, exactly!

JeffBeck-NOAA · 2022-03-03T23:50:48Z

    ltaerosol = .true.
    lwhtr = .true.
-    n_var_lndp = 0
    nsradar_reset = 3600


Same comment as above for lndp_type and n_var_lndp.

JeffBeck-NOAA · 2022-03-03T23:51:32Z

+/
+
+&nam_sppperts
 /


The &nam_sfcperts stanza (LSM-based SPP) should be empty and only filled in based on user-defined settings in the config.sh file.

JeffBeck-NOAA · 2022-03-03T23:52:24Z

-    lndp_prt_list = 0.2,0.1,
+/
+
+&nam_sppperts


The &nam_sppperts namelist stanza is set to be empty in the namelist template file and only used for MYNN PBL, MYNN SFC, GSL GWD, Thompson MP, and RRTMG SPP based on user-defined options in the config.sh file.

JeffBeck-NOAA · 2022-03-03T23:53:29Z

 runSeq::
   ATM
 ::
+logKindFlag:            ESMF_LOGKIND_MULTI_ON_ERROR


Update to nems.configure file required to suppress PET file output in the run directory with new(er) hash of ufs-weather-model.

christinaholtNOAA

Looks good!

christinaholtNOAA · 2022-03-04T16:08:47Z

-    do_shum = .false.
-    do_skeb = .false.
-    do_sppt = .false.
    dspheat = .true.


These are default values in the model, anyway, no? Removing them makes sense. :)

…orkflow into feature/spp

…al_workflow into feature/spp

gsketefian · 2022-03-02T23:18:48Z

+# soon, at which point, this requirement can be removed from regional_workflow. 
+#
+#-----------------------------------------------------------------------
+#


Since the variables N_VAR_LNDP, LNDP_TYPE, and FHCYC_LSM_SPP_OR_NOT are used in at least one other script (generate_FV3LAM_wflow.sh), they are not local variables. So we should treat them as experiment variables and record them in var_defns.sh (at the end of setup.sh).

gsketefian · 2022-03-02T23:24:28Z

+#
+settings="$settings
+'nam_sppperts': {"
+if [ "${DO_SPP}" = "TRUE" ]; then 


Indent settings="$settings" line.

gsketefian · 2022-03-02T23:24:48Z

+#
+settings="$settings
+'nam_sfcperts': {"
+if [ "${DO_LSM_SPP}" = "TRUE" ]; then 


Indent settings="$settings" line.

gsketefian · 2022-03-02T23:26:19Z

 runSeq::
   ATM
 ::
+logKindFlag:            ESMF_LOGKIND_MULTI_ON_ERROR


What does this line do?

gsketefian · 2022-03-03T00:26:12Z

+# an "FHCYC_LSM_SPP" variable to 0 and set it to 999 if LSM SPP is turned
+# on.  This requirement is necessary since LSM SPP cannot run with 
+# FHCYC=0 at the moment, but FHCYC cannot be set to anything less than the
+# length of the forecast either.  A bug fix will be issued ufs-weather-model 


issued "in" ufs-weather-model

gsketefian · 2022-03-05T01:10:31Z

+     [ "${#SPP_STDDEV_CUTOFF[@]}" != "${N_VAR_SPP}" ] || \
+     [ "${#ISEED_SPP[@]}" != "${N_VAR_SPP}" ]; then
+  print_err_msg_exit "\
+All MYNN PBL, MYNN SFC, GSL GWD, Thompson MP, or RRTMG SPP-related namelist 


In the message, replace config.sh with ${CONFIG_FN} so that it changes in case the name of the config file is changed.

gsketefian · 2022-03-05T01:10:46Z

+     [ "${#LSM_SPP_LSCALE[@]}" != "${N_VAR_LNDP}" ] || \
+     [ "${#LSM_SPP_TSCALE[@]}" != "${N_VAR_LNDP}" ]; then
+  print_err_msg_exit "\
+All Noah or RUC-LSM SPP-related namelist variables (except ISEED_LSM_SPP) 


Same as above for config.sh.

…al_workflow into feature/spp

…orkflow into feature/spp

…al_workflow into feature/spp

…settings in config.sh

… SPP, LSM SPP, SPPT, SHUM, or SKEB.

JeffBeck-NOAA added 30 commits January 13, 2021 04:21

Add default namelist with SPP entries.

beeb04b

Changes necessary to run with SPP

48bcacc

Typo fix in generate script.

03b4aa8

Changes to implement SPP.

abddc04

Add comment regarding use of SPP.

2950904

Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workflow…

ea9f387

… into feature/spp

Pass N_VAR_SPP to the var_defns.sh file.

89eb7ba

Add spp_wts_pbl to the FV3_GSD_SAR SDF diag_table file

6e4814d

Remove the contents of the &nam_spperts stanza and n_var_spp from the…

61c3727

… namelist when not using SPP.

Remove SPP namelist entries from the template input.nml file. These v…

b178707

…alues are now handled in the generate script if using SPP.

Add MYNN SFC pattern variable to the diag_table file for the FV3_GSD_…

b239954

…SAR SDF

Add 'sfc' perturbation option to SPP

13418b7

Add iseed array to namelist generation

f2bf18e

Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workflow…

eede48a

… into HEAD

Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workflow…

6f4f22d

… into feature/spp

Changes to add "rad" and "gwd" SPP perturbations.

a635561

Add SPP and ad-hoc stochastic physics to SDFs.

4cccb68

Add LSM SPP functionality to the SRW App.

024e83a

Add random number generation for LSM SPP iseeds in ensemble mode.

988fe33

Fix undeclared variable for LSM SPP.

906fc90

Add if statement for LSM SPP namelist entries and set fhcyc to 999 if…

f69f8ae

… LSM SPP is turned on.

Modify how namelist settings are applied for LSM SPP.

8a2f11e

Fix implementation of fhcyc changes.

d59f271

Typo fix.

df4e097

Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workflow…

ba7fb50

… into feature/spp

Add do_gsl* namelist entries to YAML file for FV3_HRRR SDF.

d75788c

Remove diss_est from the diag table files since it's unavailable for …

e24cef5

…now.

Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workflow…

3450cd2

… into feature/spp

Change LSM SPP perturbation seed to be the same as all other SPP.

0a9eae7

Changes to FV3_HRRR field_table

f6ee1ec

gsketefian reviewed Mar 2, 2022

View reviewed changes

Comment thread ush/templates/diag_table.FV3_GSD_v0

JeffBeck-NOAA added 5 commits March 2, 2022 23:01

Merge branch 'develop' of https://github.com/ufs-community/regional_w…

c799e8c

…orkflow into feature/spp

Add back FV3_GSD_SAR and FV3_GSD_v0 SDFs. Will be removed in future, …

cc997ab

…separate PR.

Requested modifications to the input.nml template and in-line documen…

ed9f5a7

…tation changes.

Fix check for LSM SPP namelist settings

732999e

Fix to LSM SPP namelist check.

bc6cc28

JeffBeck-NOAA commented Mar 3, 2022

View reviewed changes

christinaholtNOAA approved these changes Mar 4, 2022

View reviewed changes

JeffBeck-NOAA added 2 commits March 4, 2022 23:57

Merge branch 'develop' of https://github.com/ufs-community/regional_w…

010c1d9

…orkflow into feature/spp

Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…

05d8849

…al_workflow into feature/spp

gsketefian reviewed Mar 7, 2022

View reviewed changes

gsketefian approved these changes Mar 7, 2022

View reviewed changes

JeffBeck-NOAA added 9 commits March 8, 2022 03:35

Changes request based on PR review.

d91836e

Changes requested in PR review.

d80dd3e

Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…

54bfd42

…al_workflow into feature/spp

Variable descriptions.

7599e48

Fix comment formatting.

4b9bde0

Merge branch 'develop' of https://github.com/ufs-community/regional_w…

7b95df1

…orkflow into feature/spp

Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…

ac4ef74

…al_workflow into feature/spp

Fix MET/METplus/obs paths in machine files to allow for user-defined …

ca0a8fc

…settings in config.sh

Only add/modify stochastic physics namelist entries when running with…

45b56d9

… SPP, LSM SPP, SPPT, SHUM, or SKEB.

JeffBeck-NOAA merged commit 03a0eed into ufs-community:develop Mar 9, 2022

mkavulich mentioned this pull request Mar 15, 2022

Non-SPP ensemble tests fail #702

Closed

JeffBeck-NOAA mentioned this pull request Mar 28, 2022

Update SRW Documentation ufs-community/ufs-srweather-app#212

Merged

chunhuazhou mentioned this pull request May 6, 2022

Adopting stochastic physics changes from ufs-community regional workflow NOAA-GSL/regional_workflow#381

Merged

Conversation

JeffBeck-NOAA commented Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DESCRIPTION OF CHANGES:

TESTS CONDUCTED:

DEPENDENCIES:

DOCUMENTATION:

CONTRIBUTORS (optional):

Uh oh!

Uh oh!

JeffBeck-NOAA Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeffBeck-NOAA Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christinaholtNOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JeffBeck-NOAA commented Feb 26, 2022 •

edited

Loading

JeffBeck-NOAA Mar 3, 2022 •

edited

Loading

JeffBeck-NOAA Mar 3, 2022 •

edited

Loading