-
Notifications
You must be signed in to change notification settings - Fork 87
Add SPP to the SRW App #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JeffBeck-NOAA
merged 60 commits into
ufs-community:develop
from
JeffBeck-NOAA:feature/spp
Mar 9, 2022
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
beeb04b
Add default namelist with SPP entries.
JeffBeck-NOAA 48bcacc
Changes necessary to run with SPP
JeffBeck-NOAA 03b4aa8
Typo fix in generate script.
JeffBeck-NOAA abddc04
Changes to implement SPP.
JeffBeck-NOAA 2950904
Add comment regarding use of SPP.
JeffBeck-NOAA ea9f387
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA 89eb7ba
Pass N_VAR_SPP to the var_defns.sh file.
JeffBeck-NOAA 6e4814d
Add spp_wts_pbl to the FV3_GSD_SAR SDF diag_table file
JeffBeck-NOAA 61c3727
Remove the contents of the &nam_spperts stanza and n_var_spp from the…
JeffBeck-NOAA b178707
Remove SPP namelist entries from the template input.nml file. These …
JeffBeck-NOAA b239954
Add MYNN SFC pattern variable to the diag_table file for the FV3_GSD_…
JeffBeck-NOAA 13418b7
Add 'sfc' perturbation option to SPP
JeffBeck-NOAA f2bf18e
Add iseed array to namelist generation
JeffBeck-NOAA eede48a
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA 6f4f22d
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA a635561
Changes to add "rad" and "gwd" SPP perturbations.
JeffBeck-NOAA 4cccb68
Add SPP and ad-hoc stochastic physics to SDFs.
JeffBeck-NOAA 024e83a
Add LSM SPP functionality to the SRW App.
JeffBeck-NOAA 988fe33
Add random number generation for LSM SPP iseeds in ensemble mode.
JeffBeck-NOAA 906fc90
Fix undeclared variable for LSM SPP.
JeffBeck-NOAA f69f8ae
Add if statement for LSM SPP namelist entries and set fhcyc to 999 if…
JeffBeck-NOAA 8a2f11e
Modify how namelist settings are applied for LSM SPP.
JeffBeck-NOAA d59f271
Fix implementation of fhcyc changes.
JeffBeck-NOAA df4e097
Typo fix.
JeffBeck-NOAA ba7fb50
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA d75788c
Add do_gsl* namelist entries to YAML file for FV3_HRRR SDF.
JeffBeck-NOAA e24cef5
Remove diss_est from the diag table files since it's unavailable for …
JeffBeck-NOAA 3450cd2
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA 0a9eae7
Change LSM SPP perturbation seed to be the same as all other SPP.
JeffBeck-NOAA f6ee1ec
Changes to FV3_HRRR field_table
JeffBeck-NOAA 22d8dd0
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA 89714aa
Change to the FV3_HRRR field_table file
JeffBeck-NOAA 0175fb5
Merge branch 'develop' of https://github.com/NOAA-EMC/regional_workfl…
JeffBeck-NOAA 671ef73
Update name for SPP block in input.nml
JeffBeck-NOAA 9b39fa8
Change SPP_LSM_* to LSM_SPP_*
JeffBeck-NOAA f098395
Remove space.
JeffBeck-NOAA 5130a86
Update descriptions of LSM perturbations.
JeffBeck-NOAA 95a8102
Shut off PET file generation.
JeffBeck-NOAA 08ee469
Modifications for land and SPP perturbations (templates, namelists, d…
JeffBeck-NOAA af6d543
Merge branch 'develop' of https://github.com/ufs-community/regional_w…
JeffBeck-NOAA e4173df
Remove diss_est from diag_table files and remove the FV3_GSD_SAR and …
JeffBeck-NOAA eb702ef
Fix in setup.sh for LSM SPP
JeffBeck-NOAA bf82e6c
Update Thompson MP SPP settings.
JeffBeck-NOAA ee3957d
Merge branch 'develop' of https://github.com/ufs-community/regional_w…
JeffBeck-NOAA c799e8c
Merge branch 'develop' of https://github.com/ufs-community/regional_w…
JeffBeck-NOAA cc997ab
Add back FV3_GSD_SAR and FV3_GSD_v0 SDFs. Will be removed in future,…
JeffBeck-NOAA ed9f5a7
Requested modifications to the input.nml template and in-line documen…
JeffBeck-NOAA 732999e
Fix check for LSM SPP namelist settings
JeffBeck-NOAA bc6cc28
Fix to LSM SPP namelist check.
JeffBeck-NOAA 010c1d9
Merge branch 'develop' of https://github.com/ufs-community/regional_w…
JeffBeck-NOAA 05d8849
Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…
JeffBeck-NOAA d91836e
Changes request based on PR review.
JeffBeck-NOAA d80dd3e
Changes requested in PR review.
JeffBeck-NOAA 54bfd42
Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…
JeffBeck-NOAA 7599e48
Variable descriptions.
JeffBeck-NOAA 4b9bde0
Fix comment formatting.
JeffBeck-NOAA 7b95df1
Merge branch 'develop' of https://github.com/ufs-community/regional_w…
JeffBeck-NOAA ac4ef74
Merge branch 'feature/spp' of https://github.com/JeffBeck-NOAA/region…
JeffBeck-NOAA ca0a8fc
Fix MET/METplus/obs paths in machine files to allow for user-defined …
JeffBeck-NOAA 45b56d9
Only add/modify stochastic physics namelist entries when running with…
JeffBeck-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -784,6 +784,12 @@ settings="\ | |
| 'do_shum': ${DO_SHUM}, | ||
| 'do_sppt': ${DO_SPPT}, | ||
| 'do_skeb': ${DO_SKEB}, | ||
| 'do_spp': ${DO_SPP}, | ||
| 'n_var_spp': ${N_VAR_SPP}, | ||
| 'n_var_lndp': ${N_VAR_LNDP}, | ||
| 'lndp_type': ${LNDP_TYPE}, | ||
| 'lndp_each_step': ${LSM_SPP_EACH_STEP}, | ||
| 'fhcyc': ${FHCYC_LSM_SPP_OR_NOT}, | ||
| } | ||
| 'nam_stochy': { | ||
| 'shum': ${SHUM_MAG}, | ||
|
|
@@ -855,7 +861,42 @@ done | |
| # | ||
| settings="$settings | ||
| }" | ||
|
|
||
| # | ||
| # Add the relevant SPP namelist variables to "settings" when running with | ||
| # SPP turned on. Otherwise only include an empty "nam_sppperts" stanza. | ||
| # | ||
| settings="$settings | ||
| 'nam_sppperts': {" | ||
| if [ "${DO_SPP}" = "TRUE" ]; then | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indent |
||
| settings="$settings | ||
| 'iseed_spp': [ $( printf "%s, " "${ISEED_SPP[@]}" ) ], | ||
| 'spp_lscale': [ $( printf "%s, " "${SPP_LSCALE[@]}" ) ], | ||
| 'spp_prt_list': [ $( printf "%s, " "${SPP_MAG_LIST[@]}" ) ], | ||
| 'spp_sigtop1': [ $( printf "%s, " "${SPP_SIGTOP1[@]}" ) ], | ||
| 'spp_sigtop2': [ $( printf "%s, " "${SPP_SIGTOP2[@]}" ) ], | ||
| 'spp_stddev_cutoff': [ $( printf "%s, " "${SPP_STDDEV_CUTOFF[@]}" ) ], | ||
| 'spp_tau': [ $( printf "%s, " "${SPP_TSCALE[@]}" ) ], | ||
| 'spp_var_list': [ $( printf "%s, " "${SPP_VAR_LIST[@]}" ) ]," | ||
| fi | ||
| settings="$settings | ||
| }" | ||
| # | ||
| # Add the relevant LSM SPP namelist variables to "settings" when running with | ||
| # LSM SPP turned on. | ||
| # | ||
| settings="$settings | ||
| 'nam_sfcperts': {" | ||
| if [ "${DO_LSM_SPP}" = "TRUE" ]; then | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indent |
||
| settings="$settings | ||
| 'lndp_type': ${LNDP_TYPE}, | ||
| 'lndp_tau': [ $( printf "%s, " "${LSM_SPP_TSCALE[@]}" ) ], | ||
| 'lndp_lscale': [ $( printf "%s, " "${LSM_SPP_LSCALE[@]}" ) ], | ||
| 'iseed_lndp': [ $( printf "%s, " "${ISEED_LSM_SPP[@]}" ) ], | ||
| 'lndp_var_list': [ $( printf "%s, " "${LSM_SPP_VAR_LIST[@]}" ) ], | ||
| 'lndp_prt_list': [ $( printf "%s, " "${LSM_SPP_MAG_LIST[@]}" ) ]," | ||
| fi | ||
| settings="$settings | ||
| }" | ||
| print_info_msg $VERBOSE " | ||
| The variable \"settings\" specifying values of the weather model's | ||
| namelist variables has been set as follows: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.