-
Notifications
You must be signed in to change notification settings - Fork 87
Add SPP to the SRW App #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 49 commits
beeb04b
48bcacc
03b4aa8
abddc04
2950904
ea9f387
89eb7ba
6e4814d
61c3727
b178707
b239954
13418b7
f2bf18e
eede48a
6f4f22d
a635561
4cccb68
024e83a
988fe33
906fc90
f69f8ae
8a2f11e
d59f271
df4e097
ba7fb50
d75788c
e24cef5
3450cd2
0a9eae7
f6ee1ec
22d8dd0
89714aa
0175fb5
671ef73
9b39fa8
f098395
5130a86
95a8102
08ee469
af6d543
e4173df
eb702ef
bf82e6c
ee3957d
c799e8c
cc997ab
ed9f5a7
732999e
bc6cc28
010c1d9
05d8849
d91836e
d80dd3e
54bfd42
7599e48
4b9bde0
7b95df1
ac4ef74
ca0a8fc
45b56d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -770,6 +770,12 @@ settings="\ | |
| 'do_shum': ${DO_SHUM}, | ||
| 'do_sppt': ${DO_SPPT}, | ||
| 'do_skeb': ${DO_SKEB}, | ||
| 'do_spp': ${DO_SPP}, | ||
| 'n_var_spp': ${N_VAR_SPP}, | ||
| 'n_var_lndp': ${N_VAR_LNDP}, | ||
| 'lndp_type': ${LNDP_TYPE}, | ||
| 'lndp_each_step': ${LSM_SPP_EACH_STEP}, | ||
| 'fhcyc': ${FHCYC_LSM_SPP_OR_NOT}, | ||
| } | ||
| 'nam_stochy': { | ||
| 'shum': ${SHUM_MAG}, | ||
|
|
@@ -841,7 +847,42 @@ done | |
| # | ||
| settings="$settings | ||
| }" | ||
|
|
||
| # | ||
| # Add the relevant SPP namelist variables to "settings" when running with | ||
| # SPP turned on. Otherwise only include an empty "nam_sppperts" stanza. | ||
| # | ||
| settings="$settings | ||
| 'nam_sppperts': {" | ||
| if [ "${DO_SPP}" = "TRUE" ]; then | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indent |
||
| settings="$settings | ||
| 'iseed_spp': [ $( printf "%s, " "${ISEED_SPP[@]}" ) ], | ||
| 'spp_lscale': [ $( printf "%s, " "${SPP_LSCALE[@]}" ) ], | ||
| 'spp_prt_list': [ $( printf "%s, " "${SPP_MAG_LIST[@]}" ) ], | ||
| 'spp_sigtop1': [ $( printf "%s, " "${SPP_SIGTOP1[@]}" ) ], | ||
| 'spp_sigtop2': [ $( printf "%s, " "${SPP_SIGTOP2[@]}" ) ], | ||
| 'spp_stddev_cutoff': [ $( printf "%s, " "${SPP_STDDEV_CUTOFF[@]}" ) ], | ||
| 'spp_tau': [ $( printf "%s, " "${SPP_TSCALE[@]}" ) ], | ||
| 'spp_var_list': [ $( printf "%s, " "${SPP_VAR_LIST[@]}" ) ]," | ||
| fi | ||
| settings="$settings | ||
| }" | ||
| # | ||
| # Add the relevant LSM SPP namelist variables to "settings" when running with | ||
| # LSM SPP turned on. | ||
| # | ||
| settings="$settings | ||
| 'nam_sfcperts': {" | ||
| if [ "${DO_LSM_SPP}" = "TRUE" ]; then | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indent |
||
| settings="$settings | ||
| 'lndp_type': ${LNDP_TYPE}, | ||
| 'lndp_tau': [ $( printf "%s, " "${LSM_SPP_TSCALE[@]}" ) ], | ||
| 'lndp_lscale': [ $( printf "%s, " "${LSM_SPP_LSCALE[@]}" ) ], | ||
| 'iseed_lndp': [ $( printf "%s, " "${ISEED_LSM_SPP[@]}" ) ], | ||
| 'lndp_var_list': [ $( printf "%s, " "${LSM_SPP_VAR_LIST[@]}" ) ], | ||
| 'lndp_prt_list': [ $( printf "%s, " "${LSM_SPP_MAG_LIST[@]}" ) ]," | ||
| fi | ||
| settings="$settings | ||
| }" | ||
| print_info_msg $VERBOSE " | ||
| The variable \"settings\" specifying values of the weather model's | ||
| namelist variables has been set as follows: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -204,6 +204,9 @@ DO_SKEB=$(boolify $DO_SKEB) | |
|
|
||
| check_var_valid_value "DO_SPP" "valid_vals_DO_SPP" | ||
| DO_SPP=$(boolify $DO_SPP) | ||
|
|
||
| check_var_valid_value "DO_LSM_SPP" "valid_vals_DO_LSM_SPP" | ||
| DO_LSM_SPP=$(boolify $DO_LSM_SPP) | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
|
|
@@ -227,8 +230,9 @@ fi | |
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # If running with SPP, count the number of entries in SPP_VAR_LIST to | ||
| # correctly set N_VAR_SPP, otherwise set it to zero. | ||
| # If running with SPP in MYNN PBL, MYNN SFC, GSL GWD, Thompson MP, or | ||
| # RRTMG, count the number of entries in SPP_VAR_LIST to correctly set | ||
| # N_VAR_SPP, otherwise set it to zero. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
|
|
@@ -239,6 +243,72 @@ fi | |
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # If running with Noah or RUC-LSM SPP, count the number of entries in | ||
| # LSM_SPP_VAR_LIST to correctly set N_VAR_LNDP, otherwise set it to zero. | ||
| # Also set LNDP_TYPE to 2 for LSM SPP, otherwise set it to zero. Finally, | ||
| # initialize an "FHCYC_LSM_SPP" variable to 0 and set it to 999 if LSM SPP | ||
| # is turned on. This requirement is necessary since LSM SPP cannot run with | ||
| # FHCYC=0 at the moment, but FHCYC cannot be set to anything less than the | ||
| # length of the forecast either. A bug fix will be issued ufs-weather-model | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issued "in" ufs-weather-model |
||
| # soon, at which point, this requirement can be removed from regional_workflow. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the variables |
||
| N_VAR_LNDP=0 | ||
| LNDP_TYPE=0 | ||
| FHCYC_LSM_SPP_OR_NOT=0 | ||
| if [ "${DO_LSM_SPP}" = "TRUE" ]; then | ||
| N_VAR_LNDP=${#LSM_SPP_VAR_LIST[@]} | ||
| LNDP_TYPE=2 | ||
| FHCYC_LSM_SPP_OR_NOT=999 | ||
| fi | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # If running with SPP, confirm that each SPP-related namelist value | ||
| # contains the same number of entries as N_VAR_SPP (set above to be equal | ||
| # to the number of entries in SPP_VAR_LIST). | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| if [ "${DO_SPP}" = "TRUE" ]; then | ||
| if [ "${#SPP_MAG_LIST[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#SPP_LSCALE[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#SPP_TSCALE[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#SPP_SIGTOP1[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#SPP_SIGTOP2[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#SPP_STDDEV_CUTOFF[@]}" != "${N_VAR_SPP}" ] || \ | ||
| [ "${#ISEED_SPP[@]}" != "${N_VAR_SPP}" ]; then | ||
| print_err_msg_exit "\ | ||
| All MYNN PBL, MYNN SFC, GSL GWD, Thompson MP, or RRTMG SPP-related namelist | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the message, replace |
||
| variables set in config.sh must be equal in number of entries to what is | ||
| found in SPP_VAR_LIST: | ||
| Number of entries in SPP_VAR_LIST = \"${#SPP_VAR_LIST[@]}\"" | ||
| fi | ||
| fi | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # If running with LSM SPP, confirm that each LSM SPP-related namelist | ||
| # value contains the same number of entries as N_VAR_LNDP (set above to | ||
| # be equal to the number of entries in LSM_SPP_VAR_LIST). | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| if [ "${DO_LSM_SPP}" = "TRUE" ]; then | ||
| if [ "${#LSM_SPP_MAG_LIST[@]}" != "${N_VAR_LNDP}" ] || \ | ||
| [ "${#LSM_SPP_LSCALE[@]}" != "${N_VAR_LNDP}" ] || \ | ||
| [ "${#LSM_SPP_TSCALE[@]}" != "${N_VAR_LNDP}" ]; then | ||
| print_err_msg_exit "\ | ||
| All Noah or RUC-LSM SPP-related namelist variables (except ISEED_LSM_SPP) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above for |
||
| set in config.sh must be equal in number of entries to what is found in | ||
| SPP_VAR_LIST: | ||
| Number of entries in SPP_VAR_LIST = \"${#LSM_SPP_VAR_LIST[@]}\"" | ||
| fi | ||
| fi | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| check_var_valid_value "SUB_HOURLY_POST" "valid_vals_SUB_HOURLY_POST" | ||
| SUB_HOURLY_POST=$(boolify $SUB_HOURLY_POST) | ||
| # | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -275,7 +275,6 @@ | |
| "gfs_phys", "sppt_wts", "sppt_wts", "fv3_history", "all", .false., "none", 2 | ||
| "gfs_phys", "skebu_wts", "skebu_wts", "fv3_history", "all", .false., "none", 2 | ||
| "gfs_phys", "skebv_wts", "skebv_wts", "fv3_history", "all", .false., "none", 2 | ||
| "dynamics", "diss_est", "diss_est", "fv3_history", "all", .false., "none", 2 | ||
| "gfs_phys", "shum_wts", "shum_wts", "fv3_history", "all", .false., "none", 2 | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove tendency-based stochastic physics dissipation estimate (diss_est) from diag_table files. It doesn't exist (yet). |
||
| #============================================================================================= | ||
| # | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.