Add SPP to the SRW App#218
Merged
Merged
Conversation
JeffBeck-NOAA
requested review from
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
jkbk2004,
jwolff-ncar,
mark-a-potts,
mkavulich,
panll,
willmayfield and
ywangwof
as code owners
JeffBeck-NOAA
added
ci-jet-intel-build
jwolff-ncar
approved these changes
Mar 4, 2022
gsketefian
reviewed
Mar 5, 2022
gsketefian
approved these changes
Mar 9, 2022
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/ufs-srweather-app
that referenced
this pull request
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This PR updates the hash of ufs-weather-model to near the HEAD to support SPP in the SRW App. In addition, two SDFs previously supported by the SRW App (FV3_GSD_SAR and FV3_GSD_v0) were removed from the list of suites to build with the App, since they've been removed from the authoritative repository. Note that the forked regional_workflow repo and branch listed in the Externals.cfg file will be updated to point to the authoritative regional_workflow and specific hash once the companion PR #685 is merged, but before this PR is merged.
TESTS CONDUCTED:
Build tested successfully on Hera.
WE2E testing:
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp - FAILED; also failed with previous hash of ufs-weather-model
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional - FAILED; also failed with previous hash of ufs-weather-model
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - SUCCEEDED
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 - SUCCEEDED
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR - SUCCEEDED
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_CPT_v0 - FAILED; also failed with previous hash of ufs-weather-model
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_2017_gfdlmp - FAILED; also failed with previous hash of ufs-weather-model
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2 - SUCCEEDED
grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v16 - FAILED; also failed with previous hash of ufs-weather-model
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_HRRR - SUCCEEDED
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta - SUCCEEDED
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_HRRR - SUCCEEDED
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1alpha - SUCCEEDED
grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - SUCCEEDED
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_HRRR - FAILED; also failed with previous hash of ufs-weather-model; NAM data likely too old for chgres_cube
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_RRFS_v1beta - FAILED; also failed with previous hash of ufs-weather-model; NAM data likely too old for chgres_cube
grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_HRRR_all_stoch - SUCCEEDED
DEPENDENCIES:
Must merge regional_workflow PR #685 before merging this PR.