[triton-ext] Drop LLVM_BUILD_SHARED_LIBS, enable libtriton visibility through TRITON_EXT_ENABLED#9783
Merged
Merged
Conversation
Contributor
Author
|
@ThomasRaoux @neildhar jFYI |
neildhar
reviewed
Mar 20, 2026
Collaborator
neildhar
left a comment
neildhar
left a comment
There was a problem hiding this comment.
Just some comments on the details, but makes sense to me overall.
plotfi
commented
Mar 20, 2026
neildhar
reviewed
Mar 20, 2026
Collaborator
|
Looks good from my side, but I'll let @ThomasRaoux approve |
plotfi
force-pushed
the
plotfi-neils-shared-cleanup
branch
from
236e521 to
462e844
Compare
ThomasRaoux
reviewed
Mar 24, 2026
Collaborator
ThomasRaoux
left a comment
ThomasRaoux
left a comment
There was a problem hiding this comment.
I think that's reasonable although I'm still confused about the triton-opt-ext story
neildhar
reviewed
Mar 24, 2026
ThomasRaoux
reviewed
Mar 24, 2026
Collaborator
ThomasRaoux
left a comment
ThomasRaoux
left a comment
There was a problem hiding this comment.
LGTM, one last question
ThomasRaoux
approved these changes
Mar 24, 2026
Collaborator
ThomasRaoux
left a comment
ThomasRaoux
left a comment
There was a problem hiding this comment.
LGTM unless there is any more comments from @neildhar
(cherry picked from commit 4dfb7ee)
…ITON_EXT_ENABLED), remove LLVM_BUILD_SHARED_LIBS shared builds option
…by plugin Also, provide a fake libtriton.so as a LD_PRELOAD for plugin tests for now, until we can find another solution. This is because plugins are linked against libtriton.so. add fake plugin (cherry picked from commit eb094d7)
Co-authored-by: neildhar <neildhar@users.noreply.github.com>
Co-authored-by: neildhar <neildhar@users.noreply.github.com>
(cherry picked from commit e78e393c12f645e3ea4a7ed589f105acc372bb5c)
…lugins" This reverts commit 61bd85f.
…g plugins built the new way (cherry picked from commit 6500c1394b7599270afef4d73f3733fb95479d44)
…r lit tests This commit drops the loading of plugins from triton-opt, its better to use a example tool for lit tests.
plotfi
force-pushed
the
plotfi-neils-shared-cleanup
branch
from
e2dc92e to
1c9c6f9
Compare
This was referenced Mar 24, 2026
jvican
pushed a commit
to jvican/triton
that referenced
this pull request
Mar 27, 2026
… through TRITON_EXT_ENABLED (triton-lang#9783)
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
… through TRITON_EXT_ENABLED (triton-lang#9783) (cherry picked from commit 6cb8445)
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
… through TRITON_EXT_ENABLED (triton-lang#9783) (cherry picked from commit 6cb8445) (cherry picked from commit d9f8bb9)
Merged
atalman
pushed a commit
that referenced
this pull request
Apr 10, 2026
[triton-ext] Update plugin extension changes for release 3.7.x cherry-picking the following plugin extension changes since January: - **[triton-ext] Fix garbage string in reported errors (#9687)** - **[triton-ext] add string arguments to addPass API (#9691)** - **[triton-ext][FrontEnd] Custom DSL Plugin Ops (#9626)** - **[triton-ext] Drop LLVM_BUILD_SHARED_LIBS, enable libtriton visibility through TRITON_EXT_ENABLED (#9783)** - **[triton-ext] Pass a single `PluginInfo *` pointer (#9748)** - **[triton-ext] plugin extension's version check (#9937)** --------- Co-authored-by: Andrew Brown <andrew@kernelize.ai> Co-authored-by: Corbin Robeck <robeck@meta.com>
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
… through TRITON_EXT_ENABLED (triton-lang#9783)
quinnlp
added a commit
to intel/intel-xpu-backend-for-triton
that referenced
this pull request
May 4, 2026
This reverts commit 006159c. We do not need this patch anymore because triton-lang/triton#9783 introduced a similar build option (`TRITON_EXT_ENABLED`), which is OFF by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pulls from @neildhar's work on #9549 (exposes libtriton.so symbols for plugin extensions) and my own triton-opt exposure PR #9550 (exposes symbols, and does a trick to load a fake libtriton).
This PR adds a build flag to control if we enable all of this, and if we build any of the example plugins and run the plugin extension testing using
TRITON_EXT_ENABLED; this PR also drops LLVM shared builds because they are no longer needed.Co-Authored w/ @neildhar