[triton-ext] add string arguments to addPass API#9691
Merged
Conversation
Contributor
Author
|
jFYI: Pulled these unrelated changes to addPasses API out of #9626, @ThomasRaoux |
raymondtay
pushed a commit
to raymondtay/triton
that referenced
this pull request
Mar 22, 2026
This is to support add pass cases that take arguments like this one: https://github.com/triton-lang/triton/blob/48079178730beab98330d15e7d672fc1abb3193f/third_party/nvidia/backend/compiler.py#L262 ie ```python passes.ttir.add_convert_to_ttgpuir(pm, f"cuda:{capability}", opt.num_warps, 32, opt.num_ctas) ... passes.ttgpuir.add_f32_dot_tc(pm, emuTF32) ... passes.ttgpuir.add_optimize_dot_operands(pm, capability >= 80) ``` This is handled generically by passing a list of strings, so it would work more like: ```python passes.plugin.add_convert_to_ttgpuir(pm, { f"cuda:{capability}", str(opt.num_warps), '32', str(opt.num_ctas) }) ``` This wasn't added to the registerPasses API because these sort of options should be handled using an llvm `cl::opt`
jvican
pushed a commit
to jvican/triton
that referenced
this pull request
Mar 27, 2026
This is to support add pass cases that take arguments like this one: https://github.com/triton-lang/triton/blob/48079178730beab98330d15e7d672fc1abb3193f/third_party/nvidia/backend/compiler.py#L262 ie ```python passes.ttir.add_convert_to_ttgpuir(pm, f"cuda:{capability}", opt.num_warps, 32, opt.num_ctas) ... passes.ttgpuir.add_f32_dot_tc(pm, emuTF32) ... passes.ttgpuir.add_optimize_dot_operands(pm, capability >= 80) ``` This is handled generically by passing a list of strings, so it would work more like: ```python passes.plugin.add_convert_to_ttgpuir(pm, { f"cuda:{capability}", str(opt.num_warps), '32', str(opt.num_ctas) }) ``` This wasn't added to the registerPasses API because these sort of options should be handled using an llvm `cl::opt`
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
This is to support add pass cases that take arguments like this one: https://github.com/triton-lang/triton/blob/48079178730beab98330d15e7d672fc1abb3193f/third_party/nvidia/backend/compiler.py#L262 ie ```python passes.ttir.add_convert_to_ttgpuir(pm, f"cuda:{capability}", opt.num_warps, 32, opt.num_ctas) ... passes.ttgpuir.add_f32_dot_tc(pm, emuTF32) ... passes.ttgpuir.add_optimize_dot_operands(pm, capability >= 80) ``` This is handled generically by passing a list of strings, so it would work more like: ```python passes.plugin.add_convert_to_ttgpuir(pm, { f"cuda:{capability}", str(opt.num_warps), '32', str(opt.num_ctas) }) ``` This wasn't added to the registerPasses API because these sort of options should be handled using an llvm `cl::opt` (cherry picked from commit 8ecbfb0)
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
This is to support add pass cases that take arguments like this one: https://github.com/triton-lang/triton/blob/48079178730beab98330d15e7d672fc1abb3193f/third_party/nvidia/backend/compiler.py#L262 ie ```python passes.ttir.add_convert_to_ttgpuir(pm, f"cuda:{capability}", opt.num_warps, 32, opt.num_ctas) ... passes.ttgpuir.add_f32_dot_tc(pm, emuTF32) ... passes.ttgpuir.add_optimize_dot_operands(pm, capability >= 80) ``` This is handled generically by passing a list of strings, so it would work more like: ```python passes.plugin.add_convert_to_ttgpuir(pm, { f"cuda:{capability}", str(opt.num_warps), '32', str(opt.num_ctas) }) ``` This wasn't added to the registerPasses API because these sort of options should be handled using an llvm `cl::opt` (cherry picked from commit 8ecbfb0) (cherry picked from commit 6584c33)
Merged
atalman
pushed a commit
that referenced
this pull request
Apr 10, 2026
[triton-ext] Update plugin extension changes for release 3.7.x cherry-picking the following plugin extension changes since January: - **[triton-ext] Fix garbage string in reported errors (#9687)** - **[triton-ext] add string arguments to addPass API (#9691)** - **[triton-ext][FrontEnd] Custom DSL Plugin Ops (#9626)** - **[triton-ext] Drop LLVM_BUILD_SHARED_LIBS, enable libtriton visibility through TRITON_EXT_ENABLED (#9783)** - **[triton-ext] Pass a single `PluginInfo *` pointer (#9748)** - **[triton-ext] plugin extension's version check (#9937)** --------- Co-authored-by: Andrew Brown <andrew@kernelize.ai> Co-authored-by: Corbin Robeck <robeck@meta.com>
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
This is to support add pass cases that take arguments like this one: https://github.com/triton-lang/triton/blob/48079178730beab98330d15e7d672fc1abb3193f/third_party/nvidia/backend/compiler.py#L262 ie ```python passes.ttir.add_convert_to_ttgpuir(pm, f"cuda:{capability}", opt.num_warps, 32, opt.num_ctas) ... passes.ttgpuir.add_f32_dot_tc(pm, emuTF32) ... passes.ttgpuir.add_optimize_dot_operands(pm, capability >= 80) ``` This is handled generically by passing a list of strings, so it would work more like: ```python passes.plugin.add_convert_to_ttgpuir(pm, { f"cuda:{capability}", str(opt.num_warps), '32', str(opt.num_ctas) }) ``` This wasn't added to the registerPasses API because these sort of options should be handled using an llvm `cl::opt`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support add pass cases that take arguments like this one:
triton/third_party/nvidia/backend/compiler.py
Line 262 in 4807917
ie
This is handled generically by passing a list of strings, so it would work more like:
This wasn't added to the registerPasses API because these sort of options should be handled using an llvm
cl::opt