Revert "Disable example plugins on Windows (#6281)"#6470
Conversation
|
It is not safe to merge this revert yet. We need to protect the Windows build from attempting to build the example plugin targets (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/23516214516/job/68449149368). A commit like 39e06ed is needed (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/23517022781). |
|
Do not merge until we can pull in triton-lang/triton#9842 from the upstream repo. |
FYI @quinnlp it's merged |
The plugins requirement for these tests will be removed by #6470.
The plugins requirement for these tests will be removed by #6470.
This reverts commit 006159c.
quinnlp
force-pushed
the
quinnlp/revert-option
branch
from
937ffaf to
7185a16
Compare
|
Do not squash. We want 2 commits, the revert and the cherry-pick from upstream PR: triton-lang/triton#9842 |
quinnlp
force-pushed
the
quinnlp/revert-option
branch
2 times, most recently
from
22cf5d4 to
7185a16
Compare
|
Actually, it looks like triton-lang/triton#9922 recently implemented the change that we need to merge this. Let's wait until triton-lang/triton@fdfded1 is merged. |
3 participants
This reverts commit 006159c.
We do not need this patch anymore because triton-lang/triton#9783 introduced a similar build option (
TRITON_EXT_ENABLED), which is OFF by default.