Testing triton-lang/triton#9549#6191
Conversation
But not for MSVC.
9c2f786 to
bfe95a6
Compare
|
I ran into some errors applying the patch. The following describes the errors and solutions. I am not confident that these are the preferred solutions. 84b89a9This commit adds a compilation option to ignore attribute failures when compiling bfe95a6Windows symbol exporting and linking is different from Linux. My understanding of the issue is that,
|
|
Probably https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html is the way forward for Windows. I don't have a ready windows environment yet, so I just open a PR to test it: #6248. @quinnlp if you already have windows environment to test - it's better to try it locally. |
|
Thanks for taking a look @anmyachev! Unfortunately, I also don't have access to a Windows environment at the moment. |
|
triton-lang/triton#9783 has replaced triton-lang/triton#9549. See #6470 about what changes to make when pulling in triton-lang/triton#9783. |
Creating this Draft PR to test the impact of pulling in triton-lang/triton#9549, which reverts triton-lang/triton#3879.