[triton-ext] plugin extension's version check#9937
Merged
CRobeck merged 14 commits intoApr 8, 2026
Conversation
…define arg, but as a file that standalone plugin builds can use
Contributor
Author
CRobeck
added a commit
to CRobeck/triton
that referenced
this pull request
Apr 8, 2026
7 tasks
CRobeck
added a commit
to CRobeck/triton
that referenced
this pull request
Apr 8, 2026
CRobeck
added a commit
to CRobeck/triton
that referenced
this pull request
Apr 8, 2026
CRobeck
added a commit
to CRobeck/triton
that referenced
this pull request
Apr 8, 2026
7 tasks
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
This PR adds version checking. If `TRITON_PLUGIN_VERSION_CHECK` is unset then only the release version will be checked (ie that both the plugin and Triton were built on version say "3.7.0"). However is `TRITON_PLUGIN_VERSION_CHECK=on` then both the release version and the git hash built on will be checked to match, and finally if `TRITON_PLUGIN_VERSION_CHECK=off` no version checking other than the plugin api version itself will be checked. (cherry picked from commit 8497c84)
plotfi
added a commit
to plotfi/triton
that referenced
this pull request
Apr 8, 2026
This PR adds version checking. If `TRITON_PLUGIN_VERSION_CHECK` is unset then only the release version will be checked (ie that both the plugin and Triton were built on version say "3.7.0"). However is `TRITON_PLUGIN_VERSION_CHECK=on` then both the release version and the git hash built on will be checked to match, and finally if `TRITON_PLUGIN_VERSION_CHECK=off` no version checking other than the plugin api version itself will be checked. (cherry picked from commit 8497c84) (cherry picked from commit 4ea5b77)
Merged
atalman
pushed a commit
that referenced
this pull request
Apr 10, 2026
[triton-ext] Update plugin extension changes for release 3.7.x cherry-picking the following plugin extension changes since January: - **[triton-ext] Fix garbage string in reported errors (#9687)** - **[triton-ext] add string arguments to addPass API (#9691)** - **[triton-ext][FrontEnd] Custom DSL Plugin Ops (#9626)** - **[triton-ext] Drop LLVM_BUILD_SHARED_LIBS, enable libtriton visibility through TRITON_EXT_ENABLED (#9783)** - **[triton-ext] Pass a single `PluginInfo *` pointer (#9748)** - **[triton-ext] plugin extension's version check (#9937)** --------- Co-authored-by: Andrew Brown <andrew@kernelize.ai> Co-authored-by: Corbin Robeck <robeck@meta.com>
abrown
added a commit
to abrown/triton
that referenced
this pull request
Apr 13, 2026
PR triton-lang#9937 adds a way for Triton extensions to check the version they were compiled against; unfortunately, it did not include the `Version.h` header in the installation package created with `make install`. This change expands the pattern of included files so that `*.h` files (i.e., `Version.h`) are present when Triton extensions are compiled. This fixes a [failure] found with triton-ext's recurring CI workflow. [failure]: https://github.com/triton-lang/triton-ext/actions/runs/24354242395/job/71116786361?pr=65#step:11:80
abrown
added a commit
to abrown/triton
that referenced
this pull request
Apr 14, 2026
PR triton-lang#9937 adds a way for Triton extensions to check the version they were compiled against; unfortunately, it did not include the `Version.h` header in the installation package created with `make install`. This change expands the pattern of included files so that `*.h` files (i.e., `Version.h`) are present when Triton extensions are compiled. This fixes a [failure] found with triton-ext's recurring CI workflow. [failure]: https://github.com/triton-lang/triton-ext/actions/runs/24354242395/job/71116786361?pr=65#step:11:80
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
This PR adds version checking. If `TRITON_PLUGIN_VERSION_CHECK` is unset then only the release version will be checked (ie that both the plugin and Triton were built on version say "3.7.0"). However is `TRITON_PLUGIN_VERSION_CHECK=on` then both the release version and the git hash built on will be checked to match, and finally if `TRITON_PLUGIN_VERSION_CHECK=off` no version checking other than the plugin api version itself will be checked.
ThomasRaoux
pushed a commit
that referenced
this pull request
Apr 15, 2026
PR #9937 adds a way for Triton extensions to check the version they were compiled against; unfortunately, it did not include the `Version.h` header in the installation package created with `make install`. This change expands the pattern of included files so that `*.h` files (i.e., `Version.h`) are present when Triton extensions are compiled. This fixes a [failure] found with triton-ext's recurring CI workflow. [failure]: https://github.com/triton-lang/triton-ext/actions/runs/24354242395/job/71116786361?pr=65#step:11:80 Co-authored-by: peterbell10 <peterbell10@openai.com>
abrown
added a commit
to triton-lang/triton-ext
that referenced
this pull request
Apr 15, 2026
After [#9937] we need these additional fields in `PluginInfo` or Triton will reject the plugin. [#9937]: triton-lang/triton#9937
abrown
added a commit
to triton-lang/triton-ext
that referenced
this pull request
Apr 15, 2026
After [#9937] we need these additional fields in `PluginInfo` or Triton will reject the plugin. [#9937]: triton-lang/triton#9937
raymondtay
pushed a commit
to raymondtay/triton
that referenced
this pull request
Apr 18, 2026
PR triton-lang#9937 adds a way for Triton extensions to check the version they were compiled against; unfortunately, it did not include the `Version.h` header in the installation package created with `make install`. This change expands the pattern of included files so that `*.h` files (i.e., `Version.h`) are present when Triton extensions are compiled. This fixes a [failure] found with triton-ext's recurring CI workflow. [failure]: https://github.com/triton-lang/triton-ext/actions/runs/24354242395/job/71116786361?pr=65#step:11:80 Co-authored-by: peterbell10 <peterbell10@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds version checking. If
TRITON_PLUGIN_VERSION_CHECKis unset then only the release version will be checked (ie that both the plugin and Triton were built on version say "3.7.0"). However isTRITON_PLUGIN_VERSION_CHECK=onthen both the release version and the git hash built on will be checked to match, and finally ifTRITON_PLUGIN_VERSION_CHECK=offno version checking other than the plugin api version itself will be checked.