Add support for user/password auth #4165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Jun 23, 2020
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
would be nice to have a product test for this
Member
There was a problem hiding this comment.
verify the two configs are mutually exclusive
Member
Author
There was a problem hiding this comment.
From this code's point of view, it doesn't matter, I think. Both could be supplied and it should just work.
kokosing
approved these changes
Jun 23, 2020
presto-elasticsearch/src/main/java/io/prestosql/elasticsearch/ElasticsearchConfig.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@findepi, added a test. |
findepi
approved these changes
Jun 24, 2020
presto-elasticsearch/src/test/java/io/prestosql/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
presto-elasticsearch/src/test/java/io/prestosql/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
...csearch/src/test/java/io/prestosql/elasticsearch/TestElasticsearch7IntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
presto-elasticsearch/src/test/java/io/prestosql/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
Member
|
CI failed -- #3161 (comment) |
llmuculusll
added a commit
to llmuculusll/presto
that referenced
this pull request
Aug 30, 2020
Adding "X-Pack/Basic Authentication" section to elasticsearch connector documentation according to trinodb#4165 pull request.
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
May 25, 2021
Cherry-pick of trinodb/trino#4165 and trinodb/trino#2591 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Dec 17, 2022
Cherry-pick of trinodb/trino#4165 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
zhenxiao
pushed a commit
to prestodb/presto
that referenced
this pull request
Dec 20, 2022
Cherry-pick of trinodb/trino#4165 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.