Supporting basic authentication for Elasticsearch connector

[mobini-majid]

Starting from elasticsearch 7.x.x, basic authentication using username and password is supported through its x-pack.

In this pull request, if the user set elasticsearch.security to X_PACK (instead of AWS), he's able to connect to a secured elastic search by setting elasticsearch.username and elasticsearch.password variables in catalog file.

You can bring up a secured elasticsearch like this and test it if needed.

version: '3.4'
services:
  elasticsearch:
    image: docker.elastic.co/elasticsearch/elasticsearch:7.4.0
    environment:
      cluster.name: elasticsearch
      discovery.type: single-node
      xpack.security.enabled: 'true'
      ELASTIC_USERNAME: elastic
      ELASTIC_PASSWORD: magic-word
    ports:
      - '9200:9200'
      - '9300:9300'
    volumes:
      - ./esdata01:/path/to/elasticsearch/data

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

[martint]

Thanks for implementing this! I have a few comments about naming and how to better structure the change.

Also, please make sure to submit a signed CLA so we can merge it: https://github.com/prestosql/cla

[martint]

Let's put these in a separate config similar to how we handle io.prestosql.elasticsearch.AwsSecurityConfig

[martint]

Once you move the configs to a separate object similar to AwsSecurityConfig, we'll need an additional Optional<XPackSecurityConfig> argument to this method and this check will need to be adjusted.

[martint]

We should this to "Password Authentication". X-Pack is a plugin framework for Elasticsearch. From the point of view of Presto, this is about using simple user/password scheme to authenticate with ES.

[martint]

Superseded by #4165