Migrate elasticsearch tests to testcontainers#2591
Merged
martint merged 3 commits intotrinodb:masterfrom Jan 24, 2020
Merged
Conversation
martint
force-pushed
the
elastic-testcontainers
branch
from
0a52149 to
e8350ba
Compare
ebyhr
reviewed
Jan 23, 2020
presto-elasticsearch/src/test/java/io/prestosql/elasticsearch/ElasticsearchServer.java
Outdated
Show resolved
Hide resolved
...icsearch/src/test/java/io/prestosql/elasticsearch/TestElasticsearchIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
elastic-testcontainers
branch
from
e8350ba to
1c02560
Compare
Member
Author
|
@ebyhr, updated |
martint
force-pushed
the
elastic-testcontainers
branch
2 times, most recently
from
48f8d06 to
b495a75
Compare
ebyhr
approved these changes
Jan 24, 2020
...icsearch/src/test/java/io/prestosql/elasticsearch/TestElasticsearchIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
The address is used to address Elasticsearch nodes. When running in a container environment, the published address may not match the public address of the container. This option makes the connector ignore the published address and use the configured address, instead.
martint
force-pushed
the
elastic-testcontainers
branch
from
b495a75 to
bd4b3dd
Compare
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
May 25, 2021
Cherry-pick of trinodb/trino#4165 and trinodb/trino#2591 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2391