Adding "X-Pack/Basic Authentication" section to elasticsearch connector documentation#5021
Adding "X-Pack/Basic Authentication" section to elasticsearch connector documentation#5021llmuculusll wants to merge 2 commits intotrinodb:masterfrom
Conversation
Adding "X-Pack/Basic Authentication" section to elasticsearch connector documentation according to trinodb#4165 pull request.
fix a typo
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
I submitted CLA to cla@prestosql.io |
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Thanks! Just a few minor comments.
| ``elasticsearch.aws.secret-key`` AWS secret key to use to connect to the Elasticsearch domain. | ||
| ================================================ ================================================================== | ||
|
|
||
| X-Pack/Basic Authentication |
There was a problem hiding this comment.
This should say just "password authentication". "X-Pack" is an Elasticsearch extension framework and, as such, it's an implementation detail of Elasticsearch.
| X-Pack/Basic Authentication | ||
| --------------------------- | ||
|
|
||
| To enable basic authentication using X-Pack, the ``elasticsearch.security`` option needs to be set to ``PASSWORD``. |
There was a problem hiding this comment.
| To enable basic authentication using X-Pack, the ``elasticsearch.security`` option needs to be set to ``PASSWORD``. | |
| To enable password authentication, the ``elasticsearch.security`` option needs to be set to ``PASSWORD``. |
| ``elasticsearch.auth.user`` Elasticsearch username for basic authentication. | ||
| ``elasticsearch.auth.password`` Elasticsearch password for basic authentication. |
There was a problem hiding this comment.
| ``elasticsearch.auth.user`` Elasticsearch username for basic authentication. | |
| ``elasticsearch.auth.password`` Elasticsearch password for basic authentication. | |
| ``elasticsearch.auth.user`` Elasticsearch username for password authentication. | |
| ``elasticsearch.auth.password`` Elasticsearch password for password authentication. |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Elasticsearch documentation has already been updated. |
3 participants
Adding "X-Pack/Basic Authentication" section to elasticsearch connector documentation according to #4165 pull request.