Support the elasticSearch authentication for elasticsearch connector#2311
Closed
ellieshen wants to merge 1 commit intotrinodb:masterfrom
ellieshen:master
Closed
Support the elasticSearch authentication for elasticsearch connector#2311ellieshen wants to merge 1 commit intotrinodb:masterfrom ellieshen:master
ellieshen wants to merge 1 commit intotrinodb:masterfrom
ellieshen:master
Conversation
martint
requested changes
Dec 26, 2019
Member
There was a problem hiding this comment.
Thanks for working on this. It's a great start! We should adjust how the configuration is wired and handled, though. Here's how to approach it. It should be implemented like we do for AWS security:
- There should be another entry in ElasticsearchConfig.Security (e.g.,
PASSWORD) - There should be a separate class to capture the user/password config (e.g.,
PasswordConfig, similar toAwsSecurityConfig) ElasticSearchConnectorModuleshould conditionally bindPasswordConfigif security is set toPASSWORDElasticsearchClientshould take anOptional<PasswordConfig>and act accordingly. See how it handlesAwsSecurityConfig.
Member
|
@ellieshen, let me know if you need any help with this. |
Member
|
Superseded by #4165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the elasticsearch authentication for elasticsearch connector(fix issue prestosql#2127) , it worked in our cluster with this fix.