Repository navigation
refactor: extract main window registry and context ownership - #80
Closed
teamleaderleo wants to merge 3 commits into
Closed
teamleaderleo wants to merge 3 commits into
teamleaderleo wants to merge 3 commits into
Conversation
This was referenced Sep 19, 2026
Owner
Author
|
Keeping the branch as implementation history; upstream delivery will be rebased onto manaflow-ai/cmux:main as part of a foundations slice. |
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give main-window state explicit ownership instead of keeping the registry and model nested inside
AppDelegate.MainWindowRegistryowns identity indexing and lifecycle mutation.CmuxMainWindowContextis the independent model type (with the existingMainWindowContextcompatibility alias). Test-only window mutations now use the same registry path, preserving production side effects and preventing the test seam from drifting.Validation
swiftc -D DEBUG -parseover the changed Swift sourcesscripts/check-pbxproj.shgit diff --checkA full Xcode build remains blocked in this checkout because
vendor/bonsplit/Package.swiftis not present.