Repository navigation
refactor: extract terminal Cmd-click UI test coordinator - #70
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The terminal Cmd-click UI-test fixture was an ~800-line state machine embedded in
AppDelegate, including fixture setup, terminal seeding, token geometry, command execution, polling, notifications, screenshots, and manifest writes.Change
Extract it into
TerminalCmdClickUITestCoordinator, with dedicated configuration and manifest-writer types.AppDelegatenow composes the coordinator with weak closures for tab/window resolution, manager diagnostics, and terminal text setup. The exact environment names, manifest keys, and fixture timing behavior are preserved.This PR is stacked on #67.
Validation
swiftc -D DEBUG -parse Sources/Debug/UITests/TerminalCmdClickUITestConfiguration.swift Sources/Debug/UITests/TerminalCmdClickUITestManifestWriter.swift Sources/Debug/UITests/TerminalCmdClickUITestCoordinator.swift Sources/AppDelegate.swiftgit diff --checkA full
xcodebuildwas attempted but blocked before compilation because this fork worktree is missingvendor/bonsplit/Package.swift(uninitialized dependency).