Repository navigation
refactor: extract UI test socket sanity coordinator - #74
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppDelegatecontained two copies of UI-test socket probing: diagnostics payload generation and the delayed sanity/restart sequence. The extraction history also exposed invalidreturn payloadstatements in two void helpers.Change
Extract the probe and restart lifecycle into
UITestSocketSanityCoordinator. It preserves the exact diagnostics keys, synchronous probe behavior, restart source, and 750 ms ordering delays. New scheduling uses cancellableContinuousClocktasks. The existing void helpers are corrected to return normally when disabled.This PR is stacked on #73.
Validation
swiftc -D DEBUG -parse Sources/Debug/UITests/UITestSocketSanityCoordinator.swift Sources/AppDelegate.swiftgit diff --checkA full
xcodebuildremains blocked by the fork worktree's missingvendor/bonsplit/Package.swiftdependency.