Repository navigation
refactor: extract UI test diagnostics writer - #65
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
teamleaderleo
force-pushed
the
refactor/appdelegate-uitest-harness
branch
from
September 19, 2026 00:48
f8ac82e to
762bba1
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppDelegateowned UI-test diagnostics manifest writing, window/display state serialization, render stats, and portal stats alongside application lifecycle code.Change
Extract that responsibility into
UITestDiagnosticsWriterunderSources/Debug/UITests.AppDelegatenow supplies only narrow socket and focused-render closures and forwards diagnostics writes to the writer. The new source is wired into the Xcode project.Validation
swiftc -D DEBUG -parse Sources/Debug/UITests/UITestDiagnosticsWriter.swift Sources/AppDelegate.swiftgit diff --checkA full
xcodebuildwas blocked before compilation because this fork worktree is missingvendor/bonsplit/Package.swift(uninitialized dependency).