Skip to content

refactor: extract UI test diagnostics writer - #65

Closed
teamleaderleo wants to merge 1 commit into
mainfrom
refactor/appdelegate-uitest-harness
Closed

teamleaderleo wants to merge 1 commit into
mainfrom
refactor/appdelegate-uitest-harness

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Problem

AppDelegate owned UI-test diagnostics manifest writing, window/display state serialization, render stats, and portal stats alongside application lifecycle code.

Change

Extract that responsibility into UITestDiagnosticsWriter under Sources/Debug/UITests. AppDelegate now supplies only narrow socket and focused-render closures and forwards diagnostics writes to the writer. The new source is wired into the Xcode project.

Validation

  • swiftc -D DEBUG -parse Sources/Debug/UITests/UITestDiagnosticsWriter.swift Sources/AppDelegate.swift
  • git diff --check

A full xcodebuild was blocked before compilation because this fork worktree is missing vendor/bonsplit/Package.swift (uninitialized dependency).

@teamleaderleo

Copy link
Copy Markdown
Owner Author

Consolidated into the coherent upstream slices #78 (UI-test infrastructure), #79 (session lifecycle), #80 (window ownership), and #82 (terminal diagnostics). The original branch remains available for history.

@teamleaderleo
teamleaderleo deleted the refactor/appdelegate-uitest-harness branch September 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant