Repository navigation
refactor: extract configured group workspace observer - #72
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AppDelegate.swiftcontainedConfiguredGroupActionAsyncWorkspaceObserver, a standalone@MainActorobserver that watches asynchronous workspace creation and joins the first new workspace to a group. It owned no AppDelegate state.Change
Move the observer into
Sources/App/ConfiguredGroupActionAsyncWorkspaceObserver.swift, preserving its static install/finish/dispose API, Combine subscription behavior, and lifecycle cleanup. Wire the new source into the Xcode project.This PR is stacked on #71.
Validation
swiftc -D DEBUG -parse Sources/App/ConfiguredGroupActionAsyncWorkspaceObserver.swift Sources/AppDelegate.swiftgit diff --checkAppDelegate.swift.A full
xcodebuildremains blocked by the fork worktree's missingvendor/bonsplit/Package.swiftdependency.