Skip to content

refactor: extract configured group workspace observer - #72

Closed
teamleaderleo wants to merge 1 commit into
refactor/typing-diagnostics-filesfrom
refactor/group-action-observer
Closed

teamleaderleo wants to merge 1 commit into
refactor/typing-diagnostics-filesfrom
refactor/group-action-observer

Conversation

@teamleaderleo

Copy link
Copy Markdown
Owner

Problem

AppDelegate.swift contained ConfiguredGroupActionAsyncWorkspaceObserver, a standalone @MainActor observer that watches asynchronous workspace creation and joins the first new workspace to a group. It owned no AppDelegate state.

Change

Move the observer into Sources/App/ConfiguredGroupActionAsyncWorkspaceObserver.swift, preserving its static install/finish/dispose API, Combine subscription behavior, and lifecycle cleanup. Wire the new source into the Xcode project.

This PR is stacked on #71.

Validation

  • swiftc -D DEBUG -parse Sources/App/ConfiguredGroupActionAsyncWorkspaceObserver.swift Sources/AppDelegate.swift
  • git diff --check
  • Confirmed the original type definition is removed from AppDelegate.swift.

A full xcodebuild remains blocked by the fork worktree's missing vendor/bonsplit/Package.swift dependency.

@teamleaderleo

Copy link
Copy Markdown
Owner Author

Consolidated into the coherent upstream slices #78 (UI-test infrastructure), #79 (session lifecycle), #80 (window ownership), and #82 (terminal diagnostics). The original branch remains available for history.

@teamleaderleo
teamleaderleo deleted the refactor/group-action-observer branch September 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant