Skip to content

Commit

Permalink
Fork update (#6)
Browse files Browse the repository at this point in the history
* Make the navigation easier to read on small devices

* Add section about how to get started

* Add section about updating

* Add a few more features to the bottom

* Fix indentation mess

* Add missing period

* Remove punctuation for consistency

* Make `Getting Started` consistent

* Order docs in footer

Rename to match page "About The Docs"

These seem redundant, consider just "Getting Started"? Add more links?

* Edits to Getting Started 

- Copy edits for consistency
- Remove <br>'s for readability

Should all headers be Title Case? I see `Creating an App` but `Installing A Dependency`. I tend to use https://titlecaseconverter.com/, thoughts?

* Fix eslint config docs. (facebook#5416)

Update peer dependency versions in README.

* Add the new SVGs feature from the template README to the root README (facebook#5374)

* Updates to clarify the "waiting" SW behavior (facebook#5410)

* use the correct dependency for babel-plugin-dynamic-import-node (facebook#4984)

* use the correct dependency for babel-plugin-dynamic-import-node

* Update package.json

* Fix click-to-open on Windows (facebook#5431)

* Fix click-to-open on Windows

* Oops

* Correct instructions for HTTPS and PowerShell (facebook#5394)

Current instructions for running using HTTPS in a PowerShell prompt are incorrect and do not work on Windows 10 v1809

* Added note on update to .flowconfig for .scss imports (facebook#5321)

* Added note on update to .flowconfig for .scss imports

Added a note aimed at Flow users on how to get Flow to recognize the .scss imports.

* Mentioned .sass extension in note, added backticks

* Downgrade lerna-changelog because it has a bug

* Update cached lockfile

* Changelog for 2.0.5

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Remove dot from the end of the link (facebook#5449)

* Fix typo

explictly seems like a typo for explicitly

* New copy, by me

* Port documentation updates

* doc tweaks

* fix url

* Point README to docs

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Fixed typo in getting-started (facebook#5493)

changed amy to any

* Fix typo (facebook#5494)

* Remove --dev flag

* TypeScript syntax support (facebook#4837)

* Fix title on Safari (facebook#5499)

* Update doc links in template README (facebook#5512)

* Update required version in README

* Add "edit" feature to Docusaurus pages (facebook#5492)

* Always type check TypeScript when being used (facebook#5515)

* Always type check TypeScript when being used

* Use alternate version

* Check for TypeScript install in preflight (facebook#5516)

* Check for TypeScript install in preflight

* Remove unused import

* Validate tsconfig when using TypeScript (facebook#5524)

* Sanity check TypeScript config

* Check more options

* Set all defaults and suggestions

* Update docs

* Update doc notes

* Automatically copy react app declared types to project on start

* Remove note about loaders.d.ts

* Automatically create a `tsconfig.json` when entrypoint is TypeScript

* Hoist compiler options

* Print friendly message on first time use

* Fix TypeScript file detection

* Properly exclude test files from typechecking

* Add an advanced typescript test case

* Update Workbox dependency (facebook#5527)

* Add TypeScript error formatting (facebook#5529)

* Update adding-typescript.md

* Enable TypeScript json module resolver (facebook#5531)

* Enable TypeScript json module resolver

* Update verifyTypeScriptSetup.js

* Use TypeScript parser to read tsconfig.json (facebook#5532)

* Simplified TypeScript steps (facebook#5533)

* Respect tsconfig.json extends when validating config (facebook#5537)

* Use TS to resolve tsconfig extends

* Prevent modifications to original tsconfig

* Print friendly error

* Avoid pushing .pnp folder to git (facebook#5469)

* Add .pnp folder ro gitignore file

Avoid pushing .pnp folder to git

* Add .pnp.js to ignore list

* Remove service worker types from the main install

* Automatically setup TypeScript when detected (facebook#5549)

* Don't resolve TS files if it's not detected in the project

* Automatically create tsconfig.json file for user

* Remove always false check

* Add missing file

* Don't filter paths too early

* Add Algolia search bar to Docusaurus (facebook#5551)

* Simplify TypeScript setup instructions

* Adjust notes

* Change import syntax from typescript declaration (facebook#5559)

* Add typings for process.env (facebook#5557)

* Add TypeScript app creation (facebook#5550)

* Add TypeScript app creation

* Actually specify new extension

* Check for ts and tsx

* Fix types in default service worker file

* Mirror changes in JS version of SW

* Separate templates

* Use separate template directory

* Remove unused function

* Add a tsconfig file to the template

* Test install of typescript

* Add e2e for TypeScript

* Check for index.tsx to make sure we're not in the JS template

* Ensure TypeScript doesn't leak into normal installs

* Ignore some files

* Print version of CRA

* Fix script

* Add new template

* Move test to correct location

* Use `verifyTypeScriptSetup` routine to populate files

* Ensure tsconfig is created

* Don't auto exclude test files

* Enable forceConsistentCasingInFileNames by default

* Fix tests

* Fix tests x2

* Remove publish time waste

* Always publish with npm

* Add instructions for a prerelease

* Prompt for 2fa auth code

* Update lockfile

* Check for CI in publish

* Update App.tsx (facebook#5588)

* Fixing the code splitting links in the ESLint output (facebook#5586)

* Fix process.env types (facebook#5589)

Fix facebook#5576

* Refine how TypeScript env types are handled (facebook#5593)

* Specify types in package

* Do not remove types file on eject

* Stop copying types into generated project

* Reference react and react-dom

* Reference node types

* Install node types as well

* Restore copying

* Add Node to the list of installed types

* Reference Jest types

* Remove jest types from install

* Remove jest from CRA install

* Remove Jest reference and let user do this themselves

* Stop copying types file

* Add types key to package.json

* Add appTypeDeclarations and create when missing

* Rename declarations file

* Add Jest back to install instructions

* Minimize diff

* Turn on certain TypeScript options (facebook#5607)

* Ignore test files from reported type errors (facebook#5608)

* Ignore test files from reported type errors

* Ignore setup proxy & test files

* Remove unsupported TS options (facebook#5609)

* Compile lock file on publish

* Ignore json files from TypeScript type checking (facebook#5614)

Fix facebook#5613

* Fixing Internal Links (facebook#5552)

* Fixing Internal Links

Internal links, like those found on [Available Scripts](https://facebook.github.io/create-react-app/docs/available-scripts)
use absolute urls and therefore link to https://facebook.github.io/docs/deployment instead of
https://facebook.github.io/create-react-app/docs/deployment.

* changing to markdown links and fixing various broken internal links

* Remove react-scripts type reference on eject (facebook#5611)

* Remove react-scripts type reference on eject

* Check for env file

* Check eject for typescript

* Shuffle appTypeDeclarations

* Append internal types on eject

* Ensure lib is published for types

* Adjust comment

* Don't add a bunch of new lines

* File should exist and not be deleted

* Add debug

* Set file explicitly

* Revert "Set file explicitly"

This reverts commit bcd58a3.

* Copy file before destroying ourselves

* Revert "Add debug"

This reverts commit 0068ba8.

* Update lockfile

* Add release documentation

* Update lockfile

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Add note about react-scripts version

* Update docs url

* Add link to cra-ts migration guide (facebook#5629)

For users coming from create-react-app-typescript, the added link provides instructions on how to port their app to Create React App.

* Update minimum node version to 8.10 in README (facebook#5635)

* fix: Duplicate string index signature in ProcessEnv (facebook#5621)

* Make serviceWorker config argument optional in template (facebook#5651)

* add tests for named-asset-imports plugin (facebook#5575)

* add tests for named-asset-imports plugin

* add ticketFormats store/saga

* change import to require on test file to avoid using babel when running tests

* remove all babel dependencies as not needed more for running tests

* update tests and rename file to index.test.js

* remove npmignore as it is whitelisted in package.json

* add babel-plugin-named-asset-import tests to e2e

* Update making-a-progressive-web-app.md (facebook#5658)

* Add support for decorators (facebook#5659)

* Turn on decorators

* Add decorator test

* Expose `reportRuntimeError` (facebook#4709)

* factor out crashWithFrames and expose reportRuntimeError

* address code review and move error call to handleRuntimeError

* Add changelog for 2.1.1

* Update cached lock file

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Add bot config (facebook#4483)

* Add stale config

* Update stale config

* Add lock config

* Update lock.yml

* update envinfo to 5.11.1 (facebook#5685)

* ignore intellij module files when generating an app (facebook#4605)

* Make stale bot configuration more aggressive

* Lock issues more aggressively

* Add permissive TS lib defaults (facebook#5694)

* Fix tsconfig.json lib suggested value (facebook#5701)

* Fix broken documentation link (facebook#5670)

Fix public folder documentation link

* Fixed link to manifest.json file (facebook#5704)

* Updated the link to firebase hosting (facebook#5710)

* Version bump postcss-preset-env to latest (facebook#5721)

* Fix typo (facebook#5727)

* Update stale.yml

* Tweak bot settings

* Merge webpack configuration (facebook#5722)

* Rename production configuration

* Upgrade lint staged

* Merge mode, bail, devtool, and entry

* Merge output settings

* Remove old comment

* Merge some trivial differences

* Disable minimize in development mode

* Only minify html and generate SW in production

* Adjust comment

* Toggle development plugins

* Add missing imports

* Scope settings

* Delete development config

* Use new config file

* Remove unnecessary config import

* Suggest Encore when not building a SPA with Symfony (facebook#5730)

* Suggest Encore when not building a SPA with Symfony

* Update README.md

* Add PR welcoming badge  (facebook#5759)

* add pr badge 🎉

* add rounded badge 💥

* Update README.md

* docs: Change Storybook install documentation (facebook#5779)

* Don't polyfill fetch for Node -- additional files (facebook#5789)

* docs: Simplify installing Storybook with npx (facebook#5788)

Reduce two-step install to just one step (per the latest storybook docs)

Change (i) `npm install -g @storybook/cli` and (ii) `sb init` to `npx -p @storybook/cli sb init`

Refs: https://storybook.js.org/basics/quick-start-guide/

* Rename 'getting started' link to 'docs' (facebook#5806)

* extra polyfills must be included manually (facebook#5814)

* extra polyfills must be included manually, fixes facebook#5795

* make note italicized

* React native repository updated in README.md (facebook#5849)

Create React Native App (https://github.com/react-community/create-react-native-app ) has been archived by the owner. It is now read-only.

* Make named-asset-import plugin work with export-as syntax (facebook#5573)

* update named-asset-import babel plugin

* add tests to named-asset-import plugin

* add more plugin test

* extract generateNewSource method, renaming variables

* extract replaceNotVisitedSpecifiers for export and import visitors

* remove visited list update from importDeclaration

* renaming methods and removing return directly instead of saving

* Add allowESModules option to babel-preset-react-app (facebook#5487)

* Add allowESModules option to babel-preset-react-app

* changes after feedback

* Apply suggestions from code review

Co-Authored-By: Pajn <[email protected]>

* fix: add `sideEffects: false` to react-error-overlay (facebook#5451)

This allows us to leave the import in the code, and webpack will still tree shake it out

* Fix TypeScript decorator support (facebook#5783)

* Fix TypeScript decorator support

* Update babel flow override

* WIP

* Fix annotated var test

* Upgrade babel deps

* Fix propertyDecorator test

* Always test with the latest stable Node version on Travis (facebook#5546)

* fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)

* Fix link to page about running tests (facebook#5883)

* Some Grammar fixes (facebook#5858)

* Grammar fixes

1- For `Here's a `: The singular verb form ’s does not seem to agree with the plural subject a few common cases where you might want to try something else. Consider changing the verb form.

2- Added `A` before Reasonably : The noun phrase Reasonably good configuration seems to be missing a determiner before it. Consider adding an article. An article (a, an, or the) is a type of determiner. Possessive adjectives (my, his, our), possessive nouns (Joe’s, mother’s), and quantifiers (each, every) are also determiners. Single countable nouns usually require a determiner.

* Update README.md

* Run prettier on HTML files (facebook#5839)

* Remove unnecessary whitespace in template HTML

* Support setupTests.ts (facebook#5698)

* Disable copy to clipboard in cra --info (facebook#5905)

* Disable copy to clipboard in cra --info

Fixes an issue where npx create-react-app --info throws an exception on Windows. The exception was caused by envinfo's copy to clipboard functionality; envinfo is distributed pre-bundled, but the dependency it uses for copying to the clipboard makes use of a binary on Windows that can't be found once the bundle is made. Disabling copy to clipboard fixes the issue. Closes facebook#5757.

* Explicitly set clipboard to false

* Add placeholders to template README for bit.ly links. (facebook#5808)

* Add placeholders to template README for bit.ly links.

* Add placeholders to template README for goo.gl links.

* Update PWA link in README (facebook#5907)

* Add note to docs about using Sass and Flow together (facebook#5823)

* Add default values to `file_ext` note

* Update note to include a link to the relevant docs

* Update copy to indicate the default values

* Add missing space

* Correct some comments (facebook#5927)

And remove some outdated info from 1.x

* Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930)

* commit toml

* full build path

* wow the path is long

* redirect

* Add pre-eject message about new features in v2 (facebook#5954)

* Add pre-eject message about new features in v2

* Make message bold

* Suggest a different default for speed reasons (facebook#5959)

Advanced users can opt into this behavior, but it's generally outside the users' control to fix and comes with performance concerns

* Add SASS_PATH instructions to Sass docs (facebook#5917)

`node-sass` supports the SASS_PATH variable that we can use. This PR adds that to the documentation.

* Add removeItem to localStorage mock in docs (facebook#5919)

* Improve error messaging in verifyPackageTree.js (facebook#5974)

* Use https for linked images in docs to fix mixed content warnings (facebook#5985)

* Update links to docs in all package README files (facebook#5912)

* Update links to docs in all package README files

* Fix formatting of issue template

* Fix formatting of issue template

* Added extension to .eslintrc (facebook#5988)

* Update eslint instructions in docs (facebook#5990)

* Add production build section to docs (facebook#5900)

* Make links to docs consistent in README (facebook#6000)

* Add docs for creating new TypeScript project (facebook#6015)

* add webp support for typescript (facebook#5978)

* add webp support for typescript

* moved webp declaration below png

* Fix Markdown comment in proxying docs (facebook#6009)

* Tweak contributing doc

* Prepare 2.1.2 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Add note to changelog

* Fix control comment fo CSS Grid prefixing (facebook#6061)

"on" value of "autoprefixer grid" is kinda deprecated. It's better to use "autoplace" or "no-autoplace" instead.
https://github.com/postcss/autoprefixer#options

"autoplace" enables PostCss' autoplace polyfill for ie and makes prefixes, "no-autoplace" only makes prefixes
https://github.com/postcss/autoprefixer#does-autoprefixer-polyfill-grid-layout-for-ie

* Update eslint instructions in docs (facebook#6084)

Add a note that it will work in IDE with 2.0.3 and later

* Generalize the Bootstrap documentation (facebook#5631)

* Generalize the adding bootstrap documentation

* Update adding-bootstrap.md

* Update adding-bootstrap.md

* Update adding-bootstrap.md

* Update lock bot config

* Typo fixes (facebook#6104)

<!--
Thank you for sending the PR!

If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!

Happy contributing!
-->

* Fix comment typo (facebook#6036)

* Replace deprecated VSCode launch.json variable (facebook#6110)

Replace deprecated ${workspaceRoot} variable with ${workspaceFolder} in VSCode launch.json. See https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented

* Update webpack-dev-server 3.1.9 -> 3.1.14 (facebook#6064)

* Update webpack-dev-server 3.1.9 -> 3.1.14

* Update adding-typescript.md

* Fix typo in CSS modules docs (facebook#6067)

* Prepare 2.1.3 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Update CHANGELOG.md

* Fix CI and upgrade dependencies (facebook#6137)

* Upgrade a bunch of dependencies

* Turn off nightly Yarn

* Bump eslint-plugin-react version and update webpack config (facebook#6132)

* Bump eslint-plugin-react version

* Move eslint-plugin-react settings into eslint-config-react-app

* Add react/no-typos rule

* Switch to eval-source-map (facebook#5060)

Switches to eval-source-map, which is easier for webpack to recompute
when a file changes and has column based mappings, which lets firefox
devtools show original variable in the debugger and evaluate original
expressions in the console.

* Remove extra table cell (facebook#6141)

* update link for difference between proposal stages (facebook#6149)

seems the page which the old link points to has removed the related information.

* Update react-dev-util globby dependency to v8.0.2 (facebook#6162)

v8.0.2 was recently released https://github.com/sindresorhus/globby/releases to fix some pathing issues with dir-glob.

* Add note for global install of CLI (facebook#6157)

* Add note for global install of CLI

Closes facebook#6140.

* Add react/react-dom dependencies to relative-paths test fixture (facebook#6165)

* Update local-test.sh to return test exit code (facebook#6179)

The `e2e:docker` command can run tests in a Docker container, but it always returns exit code 0 even if the tests failed. This PR resolves that and returns the exit code from the test command.

* Upgrade @svgr/webpack to 4.1.0 (facebook#5816)

* Upgrade svgr to 4.0.3

* Upgrade svgr to 4.0.4

* Remove unnecessary prettier option

* Update to 4.1.0

* Move chalk dependency to react-dev-utils (facebook#6150)

Related to facebook#751

* Ignore node_modules in verifyNoTypeScript (facebook#6022)

* Add empty mock for module (facebook#5798)

* Changes to steps for publishing GitHub User Page (facebook#6095)

* Changes to steps for publishing GitHub User Page

Remove the the step for switching to gh-pages branch as it is no longer a viable option.

* Changed projects to project

* Update updating-to-new-releases.md with note about global installs (facebook#6190)

* Update updating-to-new-releases.md

Related to facebook#6140

* Update updating-to-new-releases.md

Linking to getting started following discussion on facebook#6190. 
Adapt terminology to current installation methods.

* Update updating-to-new-releases.md

typo, rleative link

* Update docusaurus/docs/updating-to-new-releases.md

Co-Authored-By: carpben <[email protected]>

* Update `serve` change listening port documentation (facebook#6229)

* [docs] Change serve port flag and add example

* [docs] Add --listen flag

* Fix e2e:docker test failure (facebook#6050)

* fix e2e:docker issue

* fix e2e tests

* Update stale config to ignore additional labels

* Prevent cursor events on app-logo svg (facebook#6276)

* Add '--no-watch' flag for tests (facebook#6285)

* Check for multiple project names when initializing (facebook#6080)

* Add `--no-watch` test flag to docs (facebook#6331)

* Add empty mock for dns (facebook#6292)

* Fix order of args in tasks/cra test (facebook#6342)

* Fix missing article in README (facebook#6346)

* Make manifest.json description more generic (facebook#6355)

* Speed up TypeScript projects (facebook#5903)

As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker.

These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project.

The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser.

Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow.

The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.

![nov-26-2018 15-47-01](https://user-images.githubusercontent.com/5549148/49021284-9446fe80-f192-11e8-952b-8f83d77d5fbc.gif)


I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me.

cc @brunolemos as he is an initiator of an original TypeScript PR.

Should fix facebook#5820

* Update ZEIT Now deployment instructions (facebook#6359)

* Sass source map for dev (facebook#5713)

Sass source map for dev

* Upgrade Docusaurus and enable new features

* Use semicolons in the ProcessEnv interface (facebook#6364)

* Update babel-plugin-macros 2.4.4 -> 2.4.5 (facebook#6307)

As part of the latest babel-plugin-macros [2.4.5 release](https://github.com/kentcdodds/babel-plugin-macros/releases/tag/v2.4.5), there was a small fix that went in that fixes a [bug](kentcdodds/babel-plugin-macros#100) specifying the `babelMacros` entry in `package.json` no longer working. This patch version increase should remedy the issue and allow specifying babel macro configuration in the `package.json` file again (as stated in the [user docs](https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md#config-experimental) of babel-plugin-macros)

* [docs] Warn/clarify that env vars are NOT "SECRET" (facebook#6062)

* [docs] Warn about storing secrets in env vars

Fixes facebook#5676

Co-Authored-By: Ian Schmitz <[email protected]>

* [docs] Add NOT to REACT_APP_SECRET_CODE

Fixes facebook#5676

* [docs] Remove line breaks

* Add Jest typeahead plugin (facebook#5213)

* Add Jest typeahead plugin

* Update jest-watch-typeahead to 0.2.1

* Update docs links to prefer HTTPS for supported domains (facebook#6383)

* Update docs links to prefer HTTPS for supported domains

* Fix existing typos

* Revert "Check for multiple project names when initializing (facebook#6080)"

This reverts commit a78be99.

* Upgrade dependencies (facebook#6393)

* Prepare 2.1.4 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (facebook#6395)

* Revert "Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (facebook#6395)"

This reverts commit c2b7158.

* Revert "Speed up TypeScript projects (facebook#5903)"

This reverts commit 5ce09db.

* Prepare 2.1.5 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

* Add information for usage custom registries on e2e testing facebook#4488 (facebook#5767)

* Update stale.yml

* Add forward ref to SVG Component (facebook#5457)

* Add forward ref to SVG component

* Write proper component for the ref test

* Add ref to jest svg transform and fix tests

* Fix SVG file location

* Use proper `ref` instead of svgRef in tests

* Add ref to svgr loader

* Update the docs to match facebook#5846

* Exclude `.d.ts` files from TypeScript glob

* Revert "Switch to eval-source-map (facebook#5060)" (facebook#6444)

This reverts commit 773d103.

* Only use `yarn.lock.cached` if using the default Yarn registry (facebook#6253)

* Fix typo in doc (facebook#6454)

"Collocation" insead of "Colocation".

* Speed up TypeScript v2 (facebook#6406)

* Revert "Revert "Speed up TypeScript projects (facebook#5903)""

This reverts commit 544a594.

* Move fork-ts-checker dep to react-dev-utils

* Convert WebpackDevServerUtils.createCompiler to take in options arg

* Update README.md for react-dev-utils

* Add CODEOWNERS

* Convert all bit.ly links from http to https (facebook#6239)

* revert css sourcemaps in development (facebook#6472)

This fixes facebook#6399.

* Remove latest Node version from Travis config (facebook#6474)

* Use contenthash instead of chunkhash for better long-term caching (facebook#6387)

* Fix a typo

* Analyse also dependencies bundle (facebook#6438)

The current `analyze` script only analises the `/src` code. This change leverages new version of `source-map-explorer` that is able to analyse multiple bundles at once, including the  3rd party dependencies bundle which is in my opinion even more important to analyze.

* minor typo fix in openBrowser

* Improved language used in markdown code blocks. (facebook#6419)

* Improved language used in code blocks.

* removed redundant statements (facebook#6254)

The enabled by default statement made sense when the developer was supposed to disable flow in order to use ts. Both those statements in there create some confusion about it in my opinion.

* Remove AppVeyor config files (facebook#6493)

* Fix build deployment instruction link appends comma at end (facebook#6511)
  • Loading branch information
stromsky authored Mar 2, 2019
1 parent cb1608b commit 04eedd2
Show file tree
Hide file tree
Showing 329 changed files with 30,839 additions and 6,365 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ build
my-app*
packages/react-scripts/template
packages/react-scripts/fixtures
fixtures/
2 changes: 1 addition & 1 deletion .eslintrc → .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"es6": true
},
"parserOptions": {
"ecmaVersion": 6
"ecmaVersion": 2018
},
"rules": {
"no-console": "off",
Expand Down
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
packages/ @amyrlam @bugzpodder @gaearon @ianschmitz @iansu @mrmckeb @petetnt @timer
docusaurus/ @amyrlam @iansu
76 changes: 44 additions & 32 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@

(write your answer here)


<!--
If you answered "Yes":
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
Expand All @@ -24,30 +25,40 @@
You can find webpack docs at https://webpack.js.org/.
-->


### Can you also reproduce the problem with npm 4.x?
### Did you try recovering your dependencies?

<!--
Many errors, especially related to "missing modules", are due to npm bugs.
Which version of npm are you running? You can find out by checking:
Your module tree might be corrupted, and that might be causing the issues.
Let's try to recover it. First, delete these files and folders in your project:
npm -v
* node_modules
* package-lock.json
* yarn.lock
If it is 5.x, please be aware that it has more than 50 known bugs, and
is not guaranteed to work with Create React App.
Then you need to decide which package manager you prefer to use.
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
However, **they can't be used together in one project** so you need to pick one.
If it's not starting with 4, try to install npm 4.x:
If you decided to use npm, run this in your project directory:
npm install -g npm@4
cd your_project_directory
rm -rf node_modules
npm cache clear
npm install -g npm@latest
npm install
Then try to reproduce the issue again.
Can you still reproduce it?
This should fix your project.
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
Then run in your project directory:
yarn
This should fix your project.
Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
Otherwise your project will break again.
Note: Please try this even if you are using Yarn so that we know whether it's a Yarn-only bug.
Have you done all these steps and still see the issue?
Please paste the output of `npm --version` and/or `yarn --version` to confirm.
-->

(Write your answer here.)
Expand All @@ -59,13 +70,13 @@
There are a few common documented problems, such as watcher not detecting changes, or build failing.
They are described in the Troubleshooting section of the User Guide:
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
https://facebook.github.io/create-react-app/docs/troubleshooting
Please scan these few sections for common problems.
Additionally, you can search the User Guide itself for something you're having issues with:
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md
https://facebook.github.io/create-react-app/
If you didn't find the solution, please share which words you searched for.
This helps us improve documentation for future readers who might encounter the same problem.
-->
Expand All @@ -76,18 +87,18 @@
### Environment

<!--
Please fill in all the relevant fields by running these commands in terminal.
-->
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
1. `node -v`:
2. `npm -v`:
3. `yarn --version` (if you use Yarn):
4. `npm ls react-scripts` (if you haven’t ejected):
`npx create-react-app --info`
Then, specify:
Paste the output of the command in the section below.
-->

1. Operating system:
2. Browser and version (if relevant):
(paste the output of the command here)


### Steps to Reproduce
Expand Down Expand Up @@ -146,13 +157,14 @@ Then, specify:

(Paste the link to an example project and exact instructions to reproduce the issue.)


<!--
What happens if you skip this step?
We will try to help you, but in many cases it is impossible because crucial
information is missing. In that case we'll tag an issue as having a low priority,
and eventually close it if there is no clear direction.
We still appreciate the report though, as eventually somebody else might
create a reproducible example for it.
Expand Down
11 changes: 11 additions & 0 deletions .github/lock.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Configuration for lock-threads - https://github.com/dessant/lock-threads

# Number of days of inactivity before a closed issue or pull request is locked
daysUntilLock: 5

# Issues and pull requests with these labels will not be locked. Set to `[]` to disable
exemptLabels: []

# Do not comment when locking
setLockReason: false
lockComment: false
56 changes: 56 additions & 0 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 30

# Number of days of inactivity before a stale Issue or Pull Request is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
daysUntilClose: 5

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
exemptLabels:
- "contributions: claimed"
- "contributions: up for grabs!"
- "good first issue"
- "issue: announcement"
- "issue: bug"
- "issue: needs investigation"
- "issue: proposal"
- "tag: bug fix"
- "tag: breaking change"

# Set to true to ignore issues in a project (defaults to false)
exemptProjects: true

# Set to true to ignore issues in a milestone (defaults to false)
exemptMilestones: true

# Label to use when marking as stale
staleLabel: stale

# Limit the number of actions per hour, from 1-30. Default is 30
limitPerRun: 30

issues:
# Comment to post when marking Issues as stale.
markComment: >
This issue has been automatically marked as stale because it has not had any
recent activity. It will be closed in 5 days if no further activity occurs.
# Comment to post when closing a stale Issue.
closeComment: >
This issue has been automatically closed because it has not had any recent
activity. If you have a question or comment, please open a new issue.
pulls:
# Comment to post when marking Pull Request as stale.
markComment: >
This pull request has been automatically marked as stale because it has not
had any recent activity. It will be closed in 5 days if no further activity
occurs.
# Comment to post when closing a stale Pull Request.
closeComment: >
This pull request has been automatically closed because it has not had any
recent activity. If you have a question or comment, please open a new
issue. Thank you for your contribution!
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*
/.changelog
.npm/
5 changes: 5 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"trailingComma": "es5",
"singleQuote": true,
"semi": true
}
29 changes: 18 additions & 11 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,33 @@ dist: trusty
language: node_js
node_js:
- 8
- 9
- 10
cache:
yarn: true
directories:
- node_modules
- packages/create-react-app/node_modules
- packages/react-scripts/node_modules
- .npm
before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash -s
- export PATH="$HOME/.yarn/bin:$PATH"
install: true
script:
- 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi'
- 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
- 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
- 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi'
- 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi'
- 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
- 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
- 'if [ $TEST_SUITE = "kitchensink-eject" ]; then tasks/e2e-kitchensink-eject.sh; fi'
- 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi'
- 'if [ $TEST_SUITE = "behavior" ]; then tasks/e2e-behavior.sh; fi'
env:
matrix:
- TEST_SUITE=simple
- TEST_SUITE=installs
- TEST_SUITE=kitchensink
- TEST_SUITE=kitchensink-eject
- TEST_SUITE=behavior
matrix:
include:
- node_js: 0.10
env: TEST_SUITE=old-node
- os: osx
node_js: 8
env: TEST_SUITE=behavior
- node_js: 6
env: TEST_SUITE=kitchensink
env: TEST_SUITE=old-node
3 changes: 0 additions & 3 deletions .yarnrc

This file was deleted.

Loading

0 comments on commit 04eedd2

Please sign in to comment.