Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production build section to docs #5900

Merged
merged 5 commits into from
Dec 8, 2018

Conversation

ianschmitz
Copy link
Contributor

Adds a production build section to the docs to help clear up some of the confusion around the chunks that are generated during a build, as well as to suggest caching techniques to improve application performance.

Closes #5754.

@iansu iansu self-requested a review November 28, 2018 03:41
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool @ianschmitz, and I think it's an important addition.

I've added two suggested changes, I'll let you accept or reject, and then we can merge.

docusaurus/docs/production-build.md Outdated Show resolved Hide resolved
docusaurus/docs/production-build.md Outdated Show resolved Hide resolved
@iansu
Copy link
Contributor

iansu commented Dec 8, 2018

Can you please rebase this with master before merging?

@ianschmitz ianschmitz merged commit 8985924 into facebook:master Dec 8, 2018
@ianschmitz ianschmitz deleted the code-splitting-docs branch December 8, 2018 22:17
hisapy pushed a commit to iporaitech/create-react-app that referenced this pull request Dec 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants