Add Node DNS module to empty mocks #6292
Conversation
DNS is required by some popular node.js modules; presently a require statement for DNS will throw an error if it is not wrapped in a try catch block.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
This PR came from this conversation: |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
seems like this failed for unrelated reasons (build broken?) |
|
Yes, this is not related to your work @Downchuck. |
DNS is required by some popular node.js modules; presently a require statement for DNS will throw an error if it is not wrapped in a try catch block.
Closes #6277.