Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating updating-to-new-releases.md for users who installed CRA globally #6190

Merged
merged 4 commits into from
Jan 20, 2019
Merged

Updating updating-to-new-releases.md for users who installed CRA globally #6190

merged 4 commits into from
Jan 20, 2019

Conversation

carpben
Copy link
Contributor

@carpben carpben commented Jan 13, 2019

I opened #6140 a few days ago, after experiencing two bugs which were a result of CRA global install. #6157 solves half of the problem, but programmers who already installed CRA globally, are even more likely to check "updating-to-new-releases.md".
I think part of the current version of "updating-to-new-releases.md" is a bit outdated.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@carpben carpben mentioned this pull request Jan 13, 2019
Closed
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

Looks like you copied from one of my earlier commits in #6157.

@ianschmitz ianschmitz added this to the 2.1.4 milestone Jan 13, 2019
@carpben
Copy link
Contributor Author

carpben commented Jan 13, 2019 •
edited
Loading

Why change something good?
You are correct - I should have mentioned clearly that I used the comment from #6157. The comment is relevant in updating-to-new-releases.md as well.

@iansu
Copy link
Contributor

iansu commented Jan 13, 2019

Can we just link to the warning in the Getting Started section instead of duplicating it here? Something like:

If you've previously installed create-react-app globally see these instructions...

@ianschmitz
Copy link
Contributor

@carpben what I meant was the language was out of date - it was changed in that PR. However I agree with @iansu

@carpben
Update updating-to-new-releases.md
3644557 
Linking to getting started following discussion on facebook#6190. 
Adapt terminology to current installation methods.
@carpben
Copy link
Contributor Author

carpben commented Jan 14, 2019 •
edited
Loading

@iansu, Linking to the Getting Started page seems better. See my last commit. Please keep in mind that besides the comment this PR also updates terminology.

@ianschmitz
Copy link
Contributor

We'll want to use a relative link instead of absolute. Also installation typo

@carpben
Copy link
Contributor Author

carpben commented Jan 14, 2019

Thanks @ianschmitz, Fixed in last commit.

@iansu iansu merged commit ed5fb10 into facebook:master Jan 20, 2019
@iansu
Copy link
Contributor

iansu commented Jan 20, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iansu iansu iansu left review comments

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@carpben @facebook-github-bot @ianschmitz @iansu