Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically setup TypeScript when detected #5549

Merged
merged 5 commits into from
Oct 24, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 24, 2018

This causes weird behavior that allows the user to think types are being checked when they're really not.

@Timer Timer added this to the 2.1 milestone Oct 24, 2018
@Timer Timer mentioned this pull request Oct 24, 2018
3 tasks
@gaearon
Copy link
Contributor

gaearon commented Oct 24, 2018

👋 I'm that user

@gaearon
Copy link
Contributor

gaearon commented Oct 24, 2018

Can we also show some error?

@Timer
Copy link
Contributor Author

Timer commented Oct 24, 2018

How about this?

@Timer
Copy link
Contributor Author

Timer commented Oct 24, 2018

Actually, that's goofy. We can do better.

@Timer
Copy link
Contributor Author

Timer commented Oct 24, 2018

How about this?

Second run only shows this:

@Timer Timer changed the title Don't resolve TS files if it's not detected in the project Automatically setup TypeScript when detected Oct 24, 2018
@Timer Timer merged commit 5ead915 into facebook:master Oct 24, 2018
chanand pushed a commit to chanand/create-react-app that referenced this pull request Oct 25, 2018
* Don't resolve TS files if it's not detected in the project

* Automatically create tsconfig.json file for user

* Remove always false check

* Add missing file

* Don't filter paths too early
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
* Don't resolve TS files if it's not detected in the project

* Automatically create tsconfig.json file for user

* Remove always false check

* Add missing file

* Don't filter paths too early
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
* Don't resolve TS files if it's not detected in the project

* Automatically create tsconfig.json file for user

* Remove always false check

* Add missing file

* Don't filter paths too early
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants