Release: Patch 8.5.4#30459
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
18 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
1c4ea25 to
87b1981
Compare
|
View your CI Pipeline Execution ↗ for commit caa8a9b.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 56 | 🎉 -3 🎉 |
| Self size | 228 KB | 332 KB | 🚨 +104 KB 🚨 |
| Dependency size | 13.46 MB | 12.71 MB | 🎉 -753 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-docs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 17 | 15 | 🎉 -2 🎉 |
| Self size | 2.20 MB | 2.24 MB | 🚨 +44 KB 🚨 |
| Dependency size | 7.91 MB | 9.66 MB | 🚨 +1.75 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 34 | 🎉 -2 🎉 |
| Self size | 12 KB | 12 KB | 0 B |
| Dependency size | 13.87 MB | 15.66 MB | 🚨 +1.79 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 154 | 189 | 🚨 +35 🚨 |
| Self size | 232 KB | 232 KB | 0 B |
| Dependency size | 44.78 MB | 48.27 MB | 🚨 +3.50 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 138 | 177 | 🚨 +39 🚨 |
| Self size | 43 KB | 43 KB | 0 B |
| Dependency size | 19.94 MB | 23.49 MB | 🚨 +3.55 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 88 | 129 | 🚨 +41 🚨 |
| Self size | 13 KB | 13 KB | 0 B |
| Dependency size | 16.10 MB | 19.67 MB | 🚨 +3.57 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
…boxes-step Build: Update CircleCI configuration to remove build-sandboxes job (cherry picked from commit 0d7da86)
…lcted-addon UI: Fix default selected addon panel (cherry picked from commit e80ab8d)
CI: Fix E2E tests for react-vite sandboxes (cherry picked from commit 7440832)
…dboxes CI: Disable test-runner for Svelte 4 sandboxes (cherry picked from commit 4762624)
…-generation-in-link-mode Build: Fix sandbox generation in linked mode (cherry picked from commit 02baa78)
…-generation-in-link-mode-2 Build: Fix local sandbox generation in linked mode (cherry picked from commit 374ee3d)
…-generation Build: Set TypeScript resolution for sandbox generation (cherry picked from commit 9c05f2b)
…solution-in-hot-module-calls Builder-Vite: Fix resolve id warning (cherry picked from commit 4b2c5d9)
e6ab69b to
ed2252c
Compare
Build: Update NX (cherry picked from commit af66c82)
…-sandbox-generation Build: Fix Angular sandbox generation in no-link mode (cherry picked from commit 05b3fac)
…ypescript React: Update react-docgen-typescript to fix CI hanging issues (cherry picked from commit 24038de)
Builder-Vite: Fix allowedHosts handling for custom hosts (cherry picked from commit cfedafb)
…ptional Addon A11y: Make Vitest Axe optional (cherry picked from commit b2d8a3c)
dd9e9ed to
caa8a9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.3to8.5.4.Once this pull request is merged, it will trigger a new release of version
8.5.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x b2d8a3c06b7730abb903465c09045d05475caff3git cherry-pick -m1 -x cfedafbba7ecfd6593dd1c6b2061a5989ce308b1git cherry-pick -m1 -x 24038de38d3fbf709cdb732f4a68d7718c968f12git cherry-pick -m1 -x 05b3fac5ae979d8998bcdfc7bd47ad2e38211318git cherry-pick -m1 -x af66c82e5544db0ae0406b4ad5840807dae13d44If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.4