CI: Disable test-runner for Svelte 4 sandboxes#30483
Conversation
|
View your CI Pipeline Execution ↗ for commit 53c996a.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Self-merging |
FYI @dummdidumm @eltigerchino in case you think any of the recent changes could cause this test failure |
…dboxes CI: Disable test-runner for Svelte 4 sandboxes (cherry picked from commit 4762624)
What I did
Test runner in CI has been failing for a couple of days now with a flaky, hard to track error.
This solution just disables the test runner for the two offending Svelte sandboxes, and leaves it enabled for the 3 others. What's noticeable about the two failing is that they are using Svelte 4 + SvelteKit.
The timing of the flaky failures aligns with the release of SvelteKit 2.17.0 so that could be the reason, but I haven't confirmed this.
FYI @benmccann, not something you need to worry about, but might worth knowing for you if you get other user reports about similar issues. The failures indicate that for some reason the browser sometimes navigates when/after rendering a story, which causes the Playwright tests to fail. But only for SvelteKit+Svelte 4.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Based on the provided files and context, I'll create a concise summary of the changes in this PR:
Disabled test runner for specific Svelte 4 sandboxes and adjusted CI parallelism to address flaky test failures.
svelte-kit/skeleton-jsandsvelte-kit/skeleton-tssandboxes incode/lib/cli-storybook/src/sandbox-templates.ts.circleci/config.ymlnormal workflow