React: Update react-docgen-typescript to fix CI hanging issues#30422
Merged
Conversation
yannbf
added
bug
ci:merged
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 8737633.
☁️ Nx Cloud last updated this comment at |
yannbf
added
the
patch:yes
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 7 | 7 | 0 |
| Self size | 1.89 MB | 1.89 MB | 0 B |
| Dependency size | 10.74 MB | 10.80 MB | 🚨 +63 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 153 | 188 | 🚨 +35 🚨 |
| Self size | 232 KB | 232 KB | 0 B |
| Dependency size | 44.74 MB | 48.24 MB | 🚨 +3.49 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 137 | 176 | 🚨 +39 🚨 |
| Self size | 43 KB | 43 KB | 0 B |
| Dependency size | 19.90 MB | 23.45 MB | 🚨 +3.55 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 87 | 128 | 🚨 +41 🚨 |
| Self size | 13 KB | 13 KB | 0 B |
| Dependency size | 16.07 MB | 19.64 MB | 🚨 +3.56 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 388 | 0 |
| Self size | 503 KB | 503 KB | 0 B |
| Dependency size | 75.28 MB | 75.34 MB | 🚨 +63 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 277 | 277 | 0 |
| Self size | 612 KB | 612 KB | 0 B |
| Dependency size | 65.36 MB | 65.42 MB | 🚨 +63 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/source-loader
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 5 | 5 | 0 |
| Self size | 41 KB | 41 KB | 0 B |
| Dependency size | 10.68 MB | 10.75 MB | 🚨 +63 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
valentinpalkovic
approved these changes
Jan 30, 2025
kylegach
reviewed
Jan 31, 2025
11 tasks
Merged
20 tasks
valentinpalkovic
added a commit
that referenced
this pull request
Feb 11, 2025
…ypescript React: Update react-docgen-typescript to fix CI hanging issues (cherry picked from commit 24038de)
github-actions
Bot
added
the
patch:done
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29828
What I did
This PR updates react-docgen-typescript so that it fixes the ongoing issues. It also adds documentation for users who would like to opt-in to the new behavior, which is now under an experimental flag.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30422-sha-3b8c2a95. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30422-sha-3b8c2a95 sandboxor in an existing project withnpx storybook@0.0.0-pr-30422-sha-3b8c2a95 upgrade.More information
0.0.0-pr-30422-sha-3b8c2a95yann/update-react-docgen-typescript3b8c2a951738234454)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30422Greptile Summary
Based on the provided information, I'll create a concise summary of the pull request changes:
Updates the @joshwooding/vite-plugin-react-docgen-typescript dependency to version 0.5.0 to resolve CI hanging issues in Storybook's React frameworks.
code/frameworks/react-native-web-vite/package.jsonto fix CI build hangscode/frameworks/react-vite/package.jsonfor consistent version across frameworksdocs/api/main-config/main-config-typescript.mdxfor Vite-specific configurationMIGRATION.mdfor new experimental performance flag and development mode feature