Skip to content

Build: Update NX#30460

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/update-nx
Feb 4, 2025
Merged

Build: Update NX#30460
valentinpalkovic merged 1 commit into
nextfrom
valentin/update-nx

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 4, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78 MB 78 MB 0 B 1.68 0%
initSize 131 MB 131 MB 0 B 1.4 0%
diffSize 53 MB 53 MB 0 B 0.91 0%
buildSize 7.17 MB 7.17 MB 0 B 0.67 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B 0.58 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -0.9 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B 0.55 0%
buildPreviewSize 3.26 MB 3.26 MB 0 B 0.65 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 11.1s 7.5s -3s -543ms -2 🔰-46.8%
generateTime 23.7s 19.3s -4s -430ms -0.43 -22.9%
initTime 16.7s 12.1s -4s -585ms -0.69 -37.7%
buildTime 9.3s 8.8s -494ms 0.05 -5.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.8s 5.7s 840ms 0.11 14.7%
devManagerResponsive 3.6s 4.2s 638ms 0.15 15%
devManagerHeaderVisible 707ms 907ms 200ms 1.11 22.1%
devManagerIndexVisible 734ms 919ms 185ms 0.77 20.1%
devStoryVisibleUncached 4s 4.3s 368ms 0.99 8.4%
devStoryVisible 734ms 944ms 210ms 0.92 22.2%
devAutodocsVisible 680ms 718ms 38ms -0.01 5.3%
devMDXVisible 646ms 683ms 37ms 0 5.4%
buildManagerHeaderVisible 789ms 778ms -11ms -0.07 -1.4%
buildManagerIndexVisible 892ms 938ms 46ms 0.12 4.9%
buildStoryVisible 779ms 755ms -24ms -0.07 -3.2%
buildAutodocsVisible 890ms 645ms -245ms -0.22 -38%
buildMDXVisible 575ms 587ms 12ms -0.09 2%

Greptile Summary

Updated dependencies in package.json, focusing on NX upgrade and TypeScript dependency reordering for improved build configuration.

  • Updated NX from 20.2.2 to ^20.4.0 in package.json
  • Reordered typescript dependency within resolutions section
  • Changes are focused on build tooling and dependency management
  • No breaking changes or major version bumps introduced
  • Maintains compatibility with existing Storybook functionality

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Feb 4, 2025
@valentinpalkovic valentinpalkovic self-assigned this Feb 4, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Feb 4, 2025

View your CI Pipeline Execution ↗ for commit 131285c.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-04 13:50:38 UTC

@valentinpalkovic valentinpalkovic merged commit af66c82 into next Feb 4, 2025
@valentinpalkovic valentinpalkovic deleted the valentin/update-nx branch February 4, 2025 14:05
@github-actions github-actions Bot mentioned this pull request Feb 4, 2025
13 tasks
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 6, 2025
@github-actions github-actions Bot mentioned this pull request Feb 11, 2025
20 tasks
valentinpalkovic added a commit that referenced this pull request Feb 11, 2025
Build: Update NX
(cherry picked from commit af66c82)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 11, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants