Skip to content

CI: Fix E2E tests for react-vite sandboxes#30485

Merged
valentinpalkovic merged 10 commits into
nextfrom
valentin/fix-ci-react-vite
Feb 6, 2025
Merged

CI: Fix E2E tests for react-vite sandboxes#30485
valentinpalkovic merged 10 commits into
nextfrom
valentin/fix-ci-react-vite

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented Feb 6, 2025

Closes #

What I did

npm create vite -- --template react-ts and the equivalent command to produce JavaScript sandboxes are shipping React 19 per default. The E2E tests were adjusted to ensure we compare the installed/aliased React version to the right one.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 80.4 MB 80.4 MB 0 B 4.15 0%
initSize 80.4 MB 80.4 MB 0 B -1.66 0%
diffSize 97 B 97 B 0 B -1.73 0%
buildSize 7.25 MB 7.25 MB -708 B 2.28 0%
buildSbAddonsSize 1.87 MB 1.87 MB 0 B 1.28 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.88 MB 1.88 MB 0 B 1.36 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.94 MB 3.94 MB 0 B 1.31 0%
buildPreviewSize 3.3 MB 3.3 MB -708 B 3.84 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 18.4s 7.9s -10s -530ms -1.27 🔰-132.9%
generateTime 18.5s 20.3s 1.8s 0.39 8.9%
initTime 5.5s 5s -494ms -1.51 🔰-9.7%
buildTime 11.4s 9.7s -1s -722ms 0.35 -17.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.8s 4.8s -1s -18ms -0.77 -20.9%
devManagerResponsive 4.2s 3.6s -642ms -0.82 -17.6%
devManagerHeaderVisible 810ms 727ms -83ms -0.53 -11.4%
devManagerIndexVisible 887ms 733ms -154ms -0.9 -21%
devStoryVisibleUncached 4.3s 3.7s -672ms -1.16 -18.1%
devStoryVisible 893ms 814ms -79ms -0.22 -9.7%
devAutodocsVisible 734ms 687ms -47ms -0.61 -6.8%
devMDXVisible 816ms 784ms -32ms 0.61 -4.1%
buildManagerHeaderVisible 760ms 634ms -126ms -1.56 🔰-19.9%
buildManagerIndexVisible 879ms 788ms -91ms -1.24 🔰-11.5%
buildStoryVisible 684ms 621ms -63ms -1.55 🔰-10.1%
buildAutodocsVisible 783ms 749ms -34ms 0.69 -4.5%
buildMDXVisible 670ms 554ms -116ms -0.89 -20.9%

@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Feb 6, 2025
@valentinpalkovic valentinpalkovic self-assigned this Feb 6, 2025
@valentinpalkovic valentinpalkovic changed the title CI: Fix E2E test for react-vite/default-ts CI: Fix E2E tests for react-vite sandboxes Feb 6, 2025
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-ci-react-vite branch from 68ade39 to fc4af7d Compare February 6, 2025 09:39
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Feb 6, 2025

View your CI Pipeline Execution ↗ for commit fd05477.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-06 14:38:47 UTC

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Feb 6, 2025
@storybook-app-bot
Copy link
Copy Markdown

storybook-app-bot Bot commented Feb 6, 2025

Package Benchmarks

Commit: fd05477, ran on 6 February 2025 at 14:41:52 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-docs

Before After Difference
Dependency count 17 15 🎉 -2 🎉
Self size 2.26 MB 2.26 MB 🚨 +33 B 🚨
Dependency size 7.92 MB 9.66 MB 🚨 +1.75 MB 🚨
Bundle Size Analyzer Link Link

@storybook/addon-essentials

Before After Difference
Dependency count 36 34 🎉 -2 🎉
Self size 12 KB 12 KB 0 B
Dependency size 13.93 MB 15.68 MB 🚨 +1.75 MB 🚨
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-ci-react-vite branch from 97c9691 to fd05477 Compare February 6, 2025 14:32
@valentinpalkovic valentinpalkovic merged commit 7440832 into next Feb 6, 2025
@valentinpalkovic valentinpalkovic deleted the valentin/fix-ci-react-vite branch February 6, 2025 14:56
@github-actions github-actions Bot mentioned this pull request Feb 6, 2025
11 tasks
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 6, 2025
@github-actions github-actions Bot mentioned this pull request Feb 11, 2025
20 tasks
valentinpalkovic added a commit that referenced this pull request Feb 11, 2025
CI: Fix E2E tests for react-vite sandboxes
(cherry picked from commit 7440832)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 11, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants