Skip to content

Conversation

@riccardo-ssvlabs
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Changes to gas cost

Generated at commit: 5778f53ad5ac7e7a85268ff6f2f09e6ed5272f93, compared to commit: 0e9024818d510319518b14eef6086c8484bf1f77

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
BasedAppMock4 optInToBApp
slash
+1,179 ❌
+1,428 ❌
+4.98%
+6.10%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
BasedAppMock4 909,375 (0) optInToBApp
slash
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
4 (0)
1 (0)
StrategyManager 3,036,082 (+488) createStrategy
finalizeUpdateObligation
optInToBApp
proposeUpdateObligation
656 (0)
3,176 (0)
3,760 (0)
3,283 (0)
0.00%
0.00%
0.00%
0.00%
62,377 (+56)
10,033 (+1)
63,645 (+29)
24,457 (+2)
+0.09%
+0.01%
+0.05%
+0.01%
75,123 (0)
7,852 (0)
64,705 (0)
32,827 (+3)
0.00%
0.00%
0.00%
+0.01%
92,223 (0)
18,496 (+3)
102,729 (0)
32,827 (+3)
0.00%
+0.02%
0.00%
+0.01%
3,005 (+8)
192 (0)
2,296 (+4)
348 (0)
SSVBasedApps 2,859,330 (0) createStrategy
finalizeUpdateObligation
initialize
optInToBApp
proposeUpdateObligation
registerBApp
6,384 (0)
8,799 (0)
3,183 (0)
10,112 (0)
9,019 (0)
8,866 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
68,104 (+56)
15,649 (0)
169,808 (+20)
69,988 (+30)
30,184 (+2)
60,297 (-7)
+0.08%
0.00%
+0.01%
+0.04%
+0.01%
-0.01%
80,850 (0)
13,469 (0)
171,499 (0)
71,047 (0)
38,553 (+3)
55,928 (0)
0.00%
0.00%
0.00%
0.00%
+0.01%
0.00%
97,950 (0)
24,109 (+3)
191,399 (0)
109,083 (0)
38,553 (+3)
151,228 (0)
0.00%
+0.01%
0.00%
0.00%
+0.01%
0.00%
3,005 (+8)
192 (0)
533 (+6)
2,296 (+4)
348 (0)
2,481 (+4)
NonCompliantBApp 503,872 (+12) slash 52,310 (-12) -0.02% 52,314 (-8) -0.02% 52,310 (-12) -0.02% 52,322 (0) 0.00% 5 (0)
BasedAppsManager 615,708 (0) registerBApp 3,022 (0) 0.00% 54,451 (-7) -0.01% 50,082 (0) 0.00% 145,340 (0) 0.00% 2,481 (+4)
WhitelistExample 894,099 (+12)

@mtabasco mtabasco changed the base branch from release/v0.1.1 to develop June 17, 2025 10:07
@mtabasco mtabasco changed the base branch from develop to release/v0.1.1 June 17, 2025 10:08
@mtabasco mtabasco merged commit 727e648 into release/v0.1.1 Jun 17, 2025
3 checks passed
@mtabasco mtabasco deleted the fix/storage-obligation-update-2 branch June 17, 2025 11:39
mtabasco pushed a commit that referenced this pull request Jun 17, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* Add Security Checks for Config (#49)
* feat: add and enforce basic checks for config vars
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: update prettier dependency (#62)
* chore: add Renovate config
* chore: sepolia deployment, bump version
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
mtabasco added a commit that referenced this pull request Jun 18, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* test(strategy): revert slash not opted in strategy
* Add Security Checks for Config (#49)
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: add Renovate config
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants