Skip to content

Remove IERC165 Interface Check #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v0.2.0
merged 2 commits into from
May 28, 2025
Merged

Remove IERC165 Interface Check #52

merged 2 commits into from
May 28, 2025

Conversation

@riccardo-ssvlabs
Copy link
Contributor

@riccardo-ssvlabs riccardo-ssvlabs commented May 23, 2025 •
edited
Loading

This PR implies the following changes:
A BApp can now be only either an EOA or a Contract. There is no more concept of compliant and non-compliant.

@github-actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: 7bdbaa068913517221674c2968b511954245257c, compared to commit: f3efb28458d7859b43e23ab09abb6375f4cc25b4

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
NonCompliantBApp slash -33,674 ✅ -41.34%
StrategyManager slash -3,147 ✅ -6.06%
SSVBasedApps slash -3,148 ✅ -5.43%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
NonCompliantBApp 485,061 (0) slash 47,783 (-33,681) -41.34% 47,790 (-33,674) -41.34% 47,795 (-33,669) -41.33% 47,795 (-33,669) -41.33% 5 (0)
StrategyManager 2,990,236 (-86,596) optInToBApp
slash		 3,760 (0)
3,427 (0)		 0.00%
0.00%		 63,022 (-1,905)
48,806 (-3,147)		 -2.93%
-6.06%		 62,490 (-2,526)
49,312 (-2,457)		 -3.89%
-4.75%		 100,622 (-2,401)
77,358 (-2,504)		 -2.33%
-3.14%		 2,232 (0)
107 (0)
SSVBasedApps 2,708,189 (0) initialize
optInToBApp
slash		 3,183 (0)
10,112 (0)
9,424 (0)		 0.00%
0.00%
0.00%		 169,132 (-6)
69,365 (-1,905)
54,806 (-3,148)		 -0.00%
-2.67%
-5.43%		 169,946 (0)
68,832 (-2,526)
55,311 (-2,457)		 0.00%
-3.54%
-4.25%		 189,846 (0)
106,976 (-2,401)
83,357 (-2,504)		 0.00%
-2.20%
-2.92%		 514 (-4)
2,232 (0)
107 (0)
WhitelistExample 923,653 (-53,972) addWhitelisted
isWhitelisted
registerBApp
removeWhitelisted		 23,773 (-22)
2,529 (-22)
91,059 (+66)
22,042 (-22)		 -0.09%
-0.86%
+0.07%
-0.10%		 37,240 (-22)
2,529 (-22)
91,059 (+66)
22,916 (-22)		 -0.06%
-0.86%
+0.07%
-0.10%		 43,970 (-22)
2,529 (-22)
91,059 (+66)
22,916 (-22)		 -0.05%
-0.86%
+0.07%
-0.10%		 43,970 (-22)
2,529 (-22)
91,059 (+66)
23,791 (-22)		 -0.05%
-0.86%
+0.07%
-0.09%		 6 (0)
5 (0)
3 (0)
2 (0)
BasedAppMock4 910,685 (-53,900) optInToBApp
registerBApp
slash
updateBAppMetadataURI
updateBAppTokens
withdrawETHSlashingFund		 23,671 (+45)
64,494 (+44)
23,412 (-22)
40,615 (-22)
75,170 (-22)
48,038 (-22)		 +0.19%
+0.07%
-0.09%
-0.05%
-0.03%
-0.05%		 23,671 (+45)
96,236 (+44)
23,412 (-22)
41,675 (-22)
75,170 (-22)
48,038 (-22)		 +0.19%
+0.05%
-0.09%
-0.05%
-0.03%
-0.05%		 23,671 (+45)
91,799 (+44)
23,412 (-22)
41,675 (-22)
75,170 (-22)
48,038 (-22)		 +0.19%
+0.05%
-0.09%
-0.05%
-0.03%
-0.05%		 23,671 (+45)
190,299 (+44)
23,412 (-22)
42,735 (-22)
75,170 (-22)
48,038 (-22)		 +0.19%
+0.02%
-0.09%
-0.05%
-0.03%
-0.05%		 4 (0)
594 (0)
1 (0)
8 (0)
4 (0)
1 (0)

@riccardo-ssvlabs riccardo-ssvlabs changed the title feat: remove interface support in favor of contract check Remove IERC165 Interface Check May 23, 2025
@riccardo-ssvlabs riccardo-ssvlabs requested a review from mtabasco May 23, 2025 11:05
@riccardo-ssvlabs riccardo-ssvlabs added the Othentic Related to Othetic integration label May 23, 2025
@mtabasco mtabasco merged commit 58dae6b into release/v0.1.1 May 28, 2025
3 checks passed
@mtabasco mtabasco deleted the remove-interface-check branch May 28, 2025 12:43
mtabasco pushed a commit that referenced this pull request Jun 17, 2025
@riccardo-ssvlabs
Release/v0.2.0 (#48)
9a1fbd1 
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* Add Security Checks for Config (#49)
* feat: add and enforce basic checks for config vars
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: update prettier dependency (#62)
* chore: add Renovate config
* chore: sepolia deployment, bump version
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
mtabasco added a commit that referenced this pull request Jun 18, 2025
@mtabasco
v0.2.0 (#79)
2502cb9 
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* test(strategy): revert slash not opted in strategy
* Add Security Checks for Config (#49)
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: add Renovate config
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtabasco mtabasco Awaiting requested review from mtabasco

2 more reviewers

@0xtechdean 0xtechdean 0xtechdean approved these changes

@0xpanicError 0xpanicError 0xpanicError approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Othentic Related to Othetic integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@riccardo-ssvlabs @0xtechdean @0xpanicError @mtabasco