Skip to content

Conversation

@riccardo-ssvlabs
Copy link
Contributor

No description provided.

@riccardo-ssvlabs riccardo-ssvlabs requested a review from mtabasco May 23, 2025 14:09
@github-actions
Copy link

Changes to gas cost

Generated at commit: 54d130d67997898a3b4201f61d76b0fd35b48973, compared to commit: f3efb28458d7859b43e23ab09abb6375f4cc25b4

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
StrategyManager optInToBApp +591 ❌ +0.91%
SSVBasedApps optInToBApp +590 ❌ +0.83%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
StrategyManager 3,094,434 (+17,602) optInToBApp 3,760 (0) 0.00% 65,518 (+591) +0.91% 67,231 (+2,215) +3.41% 105,238 (+2,215) +2.15% 2,292 (+60)
SSVBasedApps 2,708,189 (0) initialize
optInToBApp
3,183 (0)
10,112 (0)
0.00%
0.00%
169,143 (+5)
71,860 (+590)
+0.00%
+0.83%
169,946 (0)
73,573 (+2,215)
0.00%
+3.10%
189,846 (0)
111,592 (+2,215)
0.00%
+2.03%
521 (+3)
2,292 (+60)
NonCompliantBApp 485,061 (0) slash 81,452 (-12) -0.01% 81,456 (-8) -0.01% 81,452 (-12) -0.01% 81,464 (0) 0.00% 5 (0)

@mtabasco mtabasco merged commit 5c94bda into release/v0.1.1 May 28, 2025
3 checks passed
@mtabasco mtabasco deleted the fix/opt-in-add-check branch May 28, 2025 12:45
mtabasco pushed a commit that referenced this pull request Jun 17, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* Add Security Checks for Config (#49)
* feat: add and enforce basic checks for config vars
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: update prettier dependency (#62)
* chore: add Renovate config
* chore: sepolia deployment, bump version
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
mtabasco added a commit that referenced this pull request Jun 18, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* test(strategy): revert slash not opted in strategy
* Add Security Checks for Config (#49)
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: add Renovate config
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants