Skip to content

Conversation

@riccardo-ssvlabs
Copy link
Contributor

No description provided.

@riccardo-ssvlabs riccardo-ssvlabs changed the base branch from main to release/v0.1.1 June 10, 2025 15:19
Copy link

@RaekwonIII RaekwonIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had a doubt on the double verification...

Copy link
Contributor

@mtabasco mtabasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! small changes and we are good to go!

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Changes to gas cost

Generated at commit: 24831f0b8e5ae503c0a55947be21525353972121, compared to commit: 0e9024818d510319518b14eef6086c8484bf1f77

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
BasedAppMock4 optInToBApp
slash
+1,179 ❌
+1,428 ❌
+4.98%
+6.10%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
BasedAppMock4 909,375 (0) optInToBApp
slash
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
24,850 (+1,179)
24,840 (+1,428)
+4.98%
+6.10%
4 (0)
1 (0)
StrategyManager 3,035,594 (0) createStrategy
optInToBApp
656 (0)
3,760 (0)
0.00%
0.00%
62,377 (+56)
63,645 (+29)
+0.09%
+0.05%
75,123 (0)
64,705 (0)
0.00%
0.00%
92,223 (0)
102,729 (0)
0.00%
0.00%
3,005 (+8)
2,296 (+4)
SSVBasedApps 2,859,330 (0) createStrategy
initialize
optInToBApp
registerBApp
6,384 (0)
3,183 (0)
10,112 (0)
8,866 (0)
0.00%
0.00%
0.00%
0.00%
68,104 (+56)
169,808 (+20)
69,988 (+30)
60,297 (-7)
+0.08%
+0.01%
+0.04%
-0.01%
80,850 (0)
171,499 (0)
71,047 (0)
55,928 (0)
0.00%
0.00%
0.00%
0.00%
97,950 (0)
191,399 (0)
109,083 (0)
151,228 (0)
0.00%
0.00%
0.00%
0.00%
3,005 (+8)
533 (+6)
2,296 (+4)
2,481 (+4)
BasedAppsManager 615,708 (0) registerBApp 3,022 (0) 0.00% 54,451 (-7) -0.01% 50,082 (0) 0.00% 145,340 (0) 0.00% 2,481 (+4)
NonCompliantBApp 503,872 (+12) slash 52,310 (-12) -0.02% 52,319 (-3) -0.01% 52,322 (0) 0.00% 52,322 (0) 0.00% 5 (0)
WhitelistExample 894,099 (+12)

@riccardo-ssvlabs riccardo-ssvlabs marked this pull request as ready for review June 11, 2025 08:47
@mtabasco mtabasco merged commit 1b5c742 into release/v0.1.1 Jun 11, 2025
3 checks passed
@mtabasco mtabasco deleted the example/ecdsa branch June 11, 2025 11:00
mtabasco pushed a commit that referenced this pull request Jun 17, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* Add Security Checks for Config (#49)
* feat: add and enforce basic checks for config vars
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: update prettier dependency (#62)
* chore: add Renovate config
* chore: sepolia deployment, bump version
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
mtabasco added a commit that referenced this pull request Jun 18, 2025
* fix(strategy-manager): change slashing and obligationUpdate event order
* fix(strategy): revert slashing if strategy not opted in
* test(strategy): revert slash not opted in strategy
* Add Security Checks for Config (#49)
* Enrich SSVBasedApps interface (#51)
* Remove IERC165 Interface Check (#52)
* feat: check bApp registered during OptIn (#53)
* Use `ICore.TokenConfig` for `registerBApp()` (#50)
* chore: add Renovate config
* Example ECDSA verifier (#72)
* Fix: Propose Obligation Update storage ref (#74)
* feat: add script for implementation update and solidity 0.8.30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants