Skip to content

Conversation

@riccardo-ssvlabs
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented May 14, 2025

Changes to gas cost

Generated at commit: 260ef589fd55b2b0d216b152de0a46df9c18db7f, compared to commit: 9574c438bee55aac993e128ae84c947d0674921f

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ProtocolManager 564,217 (+127,752) updateFeeExpireTime
updateFeeTimelockPeriod
updateMaxFeeIncrement
updateMaxShares
updateObligationExpireTime
updateObligationTimelockPeriod
updateTokenUpdateTimelockPeriod
updateWithdrawalExpireTime
updateWithdrawalTimelockPeriod
364 (-3,368)
365 (-6,160)
365 (-6,168)
326 (-6,127)
387 (-6,168)
386 (-6,168)
344 (-6,157)
343 (-6,168)
342 (-6,168)
-90.25%
-94.41%
-94.41%
-94.95%
-94.10%
-94.11%
-94.71%
-94.73%
-94.75%
2,064 (-1,668)
4,493 (-2,032)
3,465 (-3,068)
3,402 (-3,051)
3,487 (-3,068)
3,486 (-3,068)
3,438 (-3,063)
3,443 (-3,068)
3,442 (-3,068)
-44.69%
-31.14%
-46.96%
-47.28%
-46.80%
-46.81%
-47.12%
-47.12%
-47.13%
2,064 (-1,668)
6,557 (+32)
3,465 (-3,068)
3,402 (-3,051)
3,487 (-3,068)
3,486 (-3,068)
3,438 (-3,063)
3,443 (-3,068)
3,442 (-3,068)
-44.69%
+0.49%
-46.96%
-47.28%
-46.80%
-46.81%
-47.12%
-47.12%
-47.13%
3,764 (+32)
6,557 (+32)
6,565 (+32)
6,479 (+26)
6,587 (+32)
6,586 (+32)
6,533 (+32)
6,543 (+32)
6,542 (+32)
+0.86%
+0.49%
+0.49%
+0.40%
+0.49%
+0.49%
+0.49%
+0.49%
+0.49%
2 (+1)
3 (+1)
2 (+1)
2 (+1)
2 (+1)
2 (+1)
2 (+1)
2 (+1)
2 (+1)
NonCompliantBApp 503,872 (+18,811) registerBApp
slash
86,702 (-2,244)
52,310 (-29,007)
-2.52%
-35.67%
86,702 (-2,244)
52,317 (-29,007)
-2.52%
-35.67%
86,702 (-2,244)
52,322 (-29,007)
-2.52%
-35.67%
86,702 (-2,244)
52,322 (-29,007)
-2.52%
-35.67%
25 (0)
5 (0)
SSVBasedApps 2,859,330 (+151,141) acceptOwnership
createStrategy
depositERC20
initialize
optInToBApp
registerBApp
slash
updateBAppMetadataURI
updateBAppsTokens
updateDelegatedBalance
updateDisabledFeatures
updateFeeExpireTime
updateFeeTimelockPeriod
updateMaxFeeIncrement
updateMaxShares
updateObligationExpireTime
updateObligationTimelockPeriod
updateTokenUpdateTimelockPeriod
updateWithdrawalExpireTime
updateWithdrawalTimelockPeriod
withdrawSlashingFund
12,108 (-23)
6,384 (0)
6,411 (0)
3,183 (0)
10,112 (0)
8,866 (-533)
9,424 (0)
8,411 (+44)
44,150 (+163)
6,111 (0)
2,677 (+22)
2,678 (0)
2,699 (0)
2,676 (+22)
2,631 (0)
2,678 (0)
2,654 (0)
2,635 (0)
2,678 (0)
2,634 (-64)
6,258 (+22)
-0.19%
0.00%
0.00%
0.00%
0.00%
-5.67%
0.00%
+0.53%
+0.37%
0.00%
+0.83%
0.00%
0.00%
+0.83%
0.00%
0.00%
0.00%
0.00%
0.00%
-2.37%
+0.35%
12,108 (-23)
68,104 (+56)
104,871 (+118)
169,808 (+670)
69,988 (-1,282)
60,297 (-939)
58,295 (+462)
9,470 (+44)
44,150 (+163)
11,995 (0)
26,745 (+22)
7,390 (+345)
9,822 (-562)
8,322 (-100)
8,236 (-123)
8,339 (-118)
8,314 (-118)
8,264 (-123)
8,310 (-125)
8,265 (-189)
17,276 (+22)
-0.19%
+0.08%
+0.11%
+0.40%
-1.80%
-1.53%
+0.80%
+0.47%
+0.37%
0.00%
+0.08%
+4.90%
-5.41%
-1.19%
-1.47%
-1.40%
-1.40%
-1.47%
-1.48%
-2.24%
+0.13%
12,108 (-23)
80,850 (0)
122,574 (0)
171,499 (+1,553)
71,047 (-311)
55,928 (-1,368)
59,838 (+2,209)
9,470 (+44)
44,150 (+163)
9,721 (0)
31,283 (+22)
8,049 (+1,004)
11,165 (-3,062)
8,048 (-374)
7,964 (-395)
8,072 (-385)
8,047 (-385)
7,986 (-401)
8,028 (-407)
7,983 (-471)
6,301 (+22)
-0.19%
0.00%
0.00%
+0.91%
-0.44%
-2.39%
+3.83%
+0.47%
+0.37%
0.00%
+0.07%
+14.25%
-21.52%
-4.44%
-4.73%
-4.55%
-4.57%
-4.78%
-4.83%
-5.57%
+0.35%
12,108 (-23)
97,950 (0)
122,574 (0)
191,399 (+1,553)
109,083 (-294)
151,228 (-1,589)
87,884 (+2,192)
10,529 (+44)
44,150 (+163)
18,926 (-1)
31,283 (+22)
11,445 (+32)
14,259 (+32)
14,244 (+54)
14,113 (+26)
14,268 (+32)
14,243 (+32)
14,171 (+32)
14,224 (+32)
14,179 (-32)
53,330 (+22)
-0.19%
0.00%
0.00%
+0.82%
-0.27%
-1.04%
+2.56%
+0.42%
+0.37%
-0.01%
+0.07%
+0.28%
+0.22%
+0.38%
+0.18%
+0.22%
+0.23%
+0.23%
+0.23%
-0.23%
+0.04%
1 (0)
3,005 (+76)
301 (+2)
533 (+15)
2,296 (+64)
2,481 (-23)
109 (+2)
32 (0)
16 (0)
6 (0)
27 (0)
3 (+1)
4 (+1)
3 (+1)
3 (+1)
3 (+1)
3 (+1)
3 (+1)
3 (+1)
3 (+1)
7 (0)
WhitelistExample 894,099 (-83,526) addWhitelisted
isWhitelisted
registerBApp
removeWhitelisted
23,773 (-22)
2,529 (-22)
88,989 (-2,004)
22,042 (-22)
-0.09%
-0.86%
-2.20%
-0.10%
37,240 (-22)
2,529 (-22)
88,989 (-2,004)
22,916 (-22)
-0.06%
-0.86%
-2.20%
-0.10%
43,970 (-22)
2,529 (-22)
88,989 (-2,004)
22,916 (-22)
-0.05%
-0.86%
-2.20%
-0.10%
43,970 (-22)
2,529 (-22)
88,989 (-2,004)
23,791 (-22)
-0.05%
-0.86%
-2.20%
-0.09%
6 (0)
5 (0)
3 (0)
2 (0)
StrategyManager 3,036,082 (-34,239) createStrategy
depositERC20
optInToBApp
slash
updateDelegatedBalance
656 (0)
821 (0)
3,760 (0)
3,427 (0)
572 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
62,377 (+56)
99,285 (+118)
63,645 (-1,282)
52,295 (+462)
6,457 (-1)
+0.09%
+0.12%
-1.97%
+0.89%
-0.02%
75,123 (0)
116,988 (0)
64,705 (-311)
53,839 (+2,209)
4,182 (0)
0.00%
0.00%
-0.48%
+4.28%
0.00%
92,223 (0)
116,988 (0)
102,729 (-294)
81,885 (+2,192)
13,391 (-1)
0.00%
0.00%
-0.29%
+2.75%
-0.01%
3,005 (+76)
301 (+2)
2,296 (+64)
109 (+2)
6 (0)
BasedAppMock4 909,375 (-55,210) registerBApp
updateBAppMetadataURI
updateBAppTokens
withdrawETHSlashingFund
62,950 (-1,500)
40,681 (+44)
75,419 (+227)
48,038 (-22)
-2.33%
+0.11%
+0.30%
-0.05%
94,500 (-1,692)
41,741 (+44)
75,419 (+227)
48,038 (-22)
-1.76%
+0.11%
+0.30%
-0.05%
89,624 (-2,131)
41,741 (+44)
75,419 (+227)
48,038 (-22)
-2.32%
+0.11%
+0.30%
-0.05%
187,647 (-2,608)
42,801 (+44)
75,419 (+227)
48,038 (-22)
-1.37%
+0.10%
+0.30%
-0.05%
587 (-7)
8 (0)
4 (0)
1 (0)
BasedAppsManager 615,708 (-72,979) registerBApp
updateBAppMetadataURI
updateBAppsTokens
3,022 (-271)
2,815 (+22)
38,511 (+110)
-8.23%
+0.79%
+0.29%
54,451 (-676)
3,876 (+22)
38,511 (+110)
-1.23%
+0.57%
+0.29%
50,082 (-1,106)
3,876 (+22)
38,511 (+110)
-2.16%
+0.57%
+0.29%
145,340 (-1,327)
4,937 (+22)
38,511 (+110)
-0.90%
+0.45%
+0.29%
2,481 (-23)
32 (0)
16 (0)

@riccardo-ssvlabs riccardo-ssvlabs changed the title Release/v0.1.1 Release/v0.2.0 Jun 12, 2025
* fix(obligationRequests): set correct storage location

* fix(obligationRequests): set correct storage location

* feat: add script for module update

* feat: add script for implementation update and solidity 0.8.30

* fix: script in package.json
@mtabasco mtabasco changed the base branch from main to develop June 17, 2025 11:44
@mtabasco mtabasco marked this pull request as ready for review June 17, 2025 12:20
@mtabasco mtabasco merged commit 9a1fbd1 into develop Jun 17, 2025
3 checks passed
@mtabasco mtabasco deleted the release/v0.1.1 branch June 17, 2025 12:24
@mtabasco mtabasco restored the release/v0.1.1 branch June 18, 2025 15:02
@mtabasco mtabasco deleted the release/v0.1.1 branch June 18, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants