Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update authors in setup.py etc. #444

Closed
ctb opened this issue Mar 10, 2018 · 6 comments · Fixed by #1358
Closed

update authors in setup.py etc. #444

ctb opened this issue Mar 10, 2018 · 6 comments · Fixed by #1358
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Mar 10, 2018

right now it's just me!
@luizirber
Copy link
Member

Related: #674

@ctb ctb added the 4.0 issues to address for a 4.0 release label Jul 18, 2020
@ctb
Copy link
Contributor Author

ctb commented Jul 25, 2020

related: #622

@ctb ctb mentioned this issue Feb 7, 2021
Closed
@ctb
Copy link
Contributor Author

ctb commented Mar 1, 2021 •
edited
Loading

a thought and question -

  • do we put just the maintainers in the authors section for pypi, or do we limit it to core maintainers, and if so, who? I could go either way; main operational question is, what downsides are there for large numbers of authors in pypi?
  • we should do a JOSS update for 4.0. I'm thinking that submission can wait until 4.0 is officially released, and then we can do what we did for 2.0 and release a 2.0.x with updates from the JOSS review.

@ctb
Copy link
Contributor Author

ctb commented Mar 1, 2021

as of today, rev 47a294b

git shortlog --summary --numbered v3.0.0..
    87  C. Titus Brown
    57  Luiz Irber
     6  Erik Young
     3  dependabot-preview[bot]
     3  Tessa Pierce
     2  Daniel Standage
     1  Fabian Klötzl
     1  Olga Botvinnik
     1  Ivan Ogasawara

@ctb
Copy link
Contributor Author

ctb commented Mar 1, 2021

I think this accurately reflects the idea that the maintainers are me and luiz. So the question is, do we want to list everyone, or just the maintainers, in setup.cfg/pypi?

@ctb
Copy link
Contributor Author

ctb commented Mar 1, 2021

Hot take, since pypi has separate authors and maintainers, we should provide opt-in so that any code base contributor can choose to be listed as an author, while keeping luiz and myself as the maintainers.

we would then make the blanket offer to all contributors and add them into setup.py as they respond positively.

@ctb ctb mentioned this issue Mar 2, 2021
Merged
5 tasks
@ctb ctb closed this as completed in #1358 Mar 2, 2021
@ctb ctb mentioned this issue Mar 4, 2021
Merged
5 tasks
ctb added a commit that referenced this issue Aug 16, 2023
@ctb @bluegenes @katrinleinweber
[MRG] update JOSS paper for v4 (#1361)
6c28366 
Per openjournals/joss#423, we are planning to
make a new submission to JOSS for sourmash v4.x. The first paper from
2016 is [here](https://joss.theoj.org/papers/10.21105/joss.00027).

Fixes #1321.

Ref #622,
#444.

- [x] update authors per #1367
- [x] fix `@@@` in paper.md YAML header
- [x] review [JOSS
guidelines](https://joss.readthedocs.io/en/latest/submitting.html) and
think about what to add, if anything.
- [x] add funding acks - Moore esp
- [ ] let's fix citation issue finally
#511

---------

Co-authored-by: Tessa Pierce Ward <[email protected]>
Co-authored-by: N. Tessa Pierce-Ward <[email protected]>
Co-authored-by: Katrin Leinweber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] update authors in setup.cfg sourmash-bio/sourmash
2 participants
@luizirber @ctb