Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit code authorship discovery approaches #1367

Open
ctb opened this issue Mar 4, 2021 · 1 comment
Open

revisit code authorship discovery approaches #1367

ctb opened this issue Mar 4, 2021 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Mar 4, 2021

I was positive that @camillescott had contributed to sourmash, and indeed, there is the PR and commit.

Camille is not showing up in

git shortlog --summary --numbered

so we need to look into that.

@ctb
Copy link
Contributor Author

ctb commented Mar 4, 2021

Oh... it looks like I was wrong. Interesting, how did I miss that?

git shortlog --summary --numbered
   857  C. Titus Brown
   180  Luiz Irber
    34  Laurent Gautier
    17  Tim Head
     8  Olga Botvinnik
     7  Connor Tiffany
     6  Erik Young
     5  Pranathi Vemuri
     5  Taylor Reiter
     4  Tessa Pierce
     3  S. Joshua Swamidass
     3  Daniel Standage
     3  brooksph
     3  dependabot-preview[bot]
     2  Camille Scott
     2  Harriet Alexander
     2  Titus Brown
     1  swamidass
     1  Arfon Smith
     1  Connor T. Skennerton
     1  Daniel Dsouza
     1  Fabian Klötzl
     1  Ivan Ogasawara
     1  Katrin Leinweber
     1  NapsterInBlue
     1  Phillip Brooks
     1  Ricky Lim
     1  ljcohen
     1  pyup.io bot
     1  Andreas Sjödin

So we need to include Camille, Ricky Lim, NapsterInBlue, Daniel Dsouza, and Pranathi Vemuri in our author list.

@ctb ctb mentioned this issue Mar 4, 2021
5 tasks
ctb added a commit that referenced this issue Aug 16, 2023
Per openjournals/joss#423, we are planning to
make a new submission to JOSS for sourmash v4.x. The first paper from
2016 is [here](https://joss.theoj.org/papers/10.21105/joss.00027).

Fixes #1321.

Ref #622,
#444.

- [x] update authors per #1367
- [x] fix `@@@` in paper.md YAML header
- [x] review [JOSS
guidelines](https://joss.readthedocs.io/en/latest/submitting.html) and
think about what to add, if anything.
- [x] add funding acks - Moore esp
- [ ] let's fix citation issue finally
#511

---------

Co-authored-by: Tessa Pierce Ward <[email protected]>
Co-authored-by: N. Tessa Pierce-Ward <[email protected]>
Co-authored-by: Katrin Leinweber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant